[PR #834] [MERGED] refactor(browser): align inspector exclusions with canonical vocabulary #2272

New issue

Closed

opened 2026-10-16 21:16:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:16:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/834
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: cleanup/browser-capture

📝 Commits (1)

9febf8c refactor(browser): align inspector exclusions with canonical vocabulary

📊 Changes

5 files changed (+76 additions, -10 deletions)

View changed files

📝 docs/browser-observation.md (+11 -0)
➕ src/browser/JavaScriptRuntimeScope.test.ts (+34 -0)
📝 src/browser/JavaScriptRuntimeScope.ts (+21 -6)
📝 src/browser/V8InspectorCaptureProjection.ts (+5 -2)
📝 src/browser/V8InspectorProvider.ts (+5 -2)

📄 Description

Summary

Area 6 of the duplicate-ownership cleanup.

authorizeRuntimeLocation now reports canonical BrowserExclusionReason values (unsupported_url, not_approved) instead of one coarse literal; inspectorExclusionKey collapses them onto the fixed V8 wire bucket so schemas are unchanged and limitation text is stable.
New scope tests pin the per-case reasons and the wire mapping.
Docs: records the provider authority split (attach-only CDP/V8 vs owned-runtime Playwright) as the reason providers stay separate while sharing the exclusion vocabulary. Full session/provider merges deliberately out of scope: they would mix lifecycles and need real-Electron + real-browser lanes per increment.

Verification

Scope, document-script, runtime-observation, target-locations, unresolved-target, V8-cleanup suites green.
npm run check: 5/5; docs:check clean.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/834 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cleanup/browser-capture` --- ### 📝 Commits (1) - [`9febf8c`](https://github.com/morluto/rea/commit/9febf8c42e059417840bd96ce9345ca33df6c5a2) refactor(browser): align inspector exclusions with canonical vocabulary ### 📊 Changes **5 files changed** (+76 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `docs/browser-observation.md` (+11 -0) ➕ `src/browser/JavaScriptRuntimeScope.test.ts` (+34 -0) 📝 `src/browser/JavaScriptRuntimeScope.ts` (+21 -6) 📝 `src/browser/V8InspectorCaptureProjection.ts` (+5 -2) 📝 `src/browser/V8InspectorProvider.ts` (+5 -2) </details> ### 📄 Description ## Summary Area 6 of the duplicate-ownership cleanup. - `authorizeRuntimeLocation` now reports canonical `BrowserExclusionReason` values (`unsupported_url`, `not_approved`) instead of one coarse literal; `inspectorExclusionKey` collapses them onto the fixed V8 wire bucket so schemas are unchanged and limitation text is stable. - New scope tests pin the per-case reasons and the wire mapping. - Docs: records the provider authority split (attach-only CDP/V8 vs owned-runtime Playwright) as the reason providers stay separate while sharing the exclusion vocabulary. Full session/provider merges deliberately out of scope: they would mix lifecycles and need real-Electron + real-browser lanes per increment. ## Verification - Scope, document-script, runtime-observation, target-locations, unresolved-target, V8-cleanup suites green. - npm run check: 5/5; docs:check clean. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:16:34 +00:00