mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #5103] [Bug] Electron scenario CLI rejects an existing application path after symlink/.. #3139
Closed
opened 2026-10-31 00:37:06 +00:00 by bsakaguchi
·
5 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#3139
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 18, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/5103
Before submitting
Area
CLI
Observed behavior
The registered
capture-electron-scenarioCLI rewritesapplication_path: "link/../app"lexically before filesystem admission. Withlink -> real/inner, the selected directory isreal/app, but the CLI looks for siblingappand returnsinvalid_requestwith anapplication_pathENOENT issue. A filesystem read through the original spelling succeeds.Observed through the production registered command's
Cli.serveentry point with inert local fixtures. No Electron executable or provider capture was run.Reproduction
From the repository root at the source revision below, with locked dependencies installed, run this source-level CLI probe. It creates an isolated home/config and removes its fixture directory afterward. The executable fixture is inert and is never executed: the application-path failure stops admission first. The control calls the shared service with an absent provider to check path admission without launching anything.
The asserted replay and an initial independent probe each reproduced the failure.
Expected behavior
Anchoring an operator-relative JSON path should preserve the directory selected by POSIX filesystem traversal.
link/../appshould pass the same path-admission stage as its filesystem-resolved spelling. This expectation concerns admission only; it does not assert that the inert fixture is a runnable Electron application.The caller-selected path contract requires preservation of caller inputs. The path owner documentation explicitly explains why lexical symlink/.. collapse can change file selection. The JSON CLI boundary defines these fields as operator-relative paths resolved before validation.
Impact and scope
A bounded class of existing POSIX application paths fails admission with a misleading missing-path error. This is a behavior defect with a practical workaround: filesystem-resolve the application path before supplying it. That control passed path admission in the probe. Real-world frequency is NOT_ENOUGH_INFO.
Only the Electron
application_pathfailure was executed. Wrong-executable launches, other JSON fields, browser execution, Linux and Windows behavior were not runtime-tested. No file modification by REA or security-boundary crossing was observed.REA version
Source package version 6.7.0, exact tested SHA
3537e58c1ab29309f06eabf50bc52adba9817a0c. The relevant normalization, schema, CLI callback and Electron admission source files have no differences from stable tagrea-agents-6.7.0(release SHA27dc42d10249f0410904a75c0997842eb03b931c). The stable package runtime was not executed.Runtime and platform
Node.js v26.12.0; macOS 27.0.1; darwin arm64. Source workflow with locked dependencies, including Incur and tsx. No Electron/browser runtime was involved.
Target and artifact context
Owned local directory symlink, marker text file, and inert executable-permission file. No third-party application or external service.
Interface
CLI
Earliest failure stage
Request parsing or validation
Relevant output or evidence
Executed the source probe above. Its assertions passed and printed:
WORKis the disposable directory prefix, not literal CLI output. The actual registered command returnedcode: "invalid_request", operationcapture_electron_scenario, issue path["application_path"], reasoninvalid_value, and ENOENT for the siblingapplocation. The control returnedAnalysisCapabilityUnavailableErrorafter successful path canonicalization, with provider deliberately absent.The registered CLI callback applies normalization before shared validation and service invocation. The normalizer calls
resolve(entry). The service admission resolves the already-altered paths and returns failure before provider capture.Typed outcome or recovery expected
Do not emit an application-path ENOENT for the missing sibling when the caller selected the existing directory through symlink/.. traversal. Preserve filesystem selection through anchoring, while retaining ordinary relative-path admission and genuine missing-path errors.
Analysis or suspected cause
Source-derived:
resolveCliJsonPathsremoves the symlink/.. segment usingnode:path.resolve. Later filesystem canonicalization cannot reconstruct the original selection. This produces the observed admission failure before provider execution.Additional context
Related #2577 concerns file URLs becoming invented local paths in this JSON boundary; #2272 concerns attribution of genuinely unresolvable fields. Neither covers this existing-path symlink-parent trigger. No duplicate was found in the complete open-and-closed issue snapshot.
Built executable-dispatcher behavior and real-provider outcomes are NOT_ENOUGH_INFO because those entry points were not executed.
@XinwangTao commented on GitHub (Oct 19, 2026):
Confirmed — lexical normalization before symlink resolution breaks valid paths: link/../app is collapsed to sibling app before the filesystem sees that link is a symlink, so an existing caller-selected directory gets rejected with ENOENT. That's an ordering bug in admission, not a path-ownership issue.
I'd resolve against the real filesystem first (realpath on the existing segment) and only then normalize for display/use — or at minimum do symlink-aware resolution before the lexical pass — plus a regression test using a symlink + .. combination (as reproduced) so the path contract stays honest for both spellings.
@dxqlovestudy commented on GitHub (Oct 19, 2026):
Taking this one.
Plan: route caller-selected CLI JSON paths through the existing
absoluteCallerPathowner insrc/filesystem/callerPath.tsinstead ofpath.resolve()insrc/cliJsonInput.ts. That helper already keeps every..for the POSIX filesystem to resolve after the preceding symlink (and resolves lexically on Win32, where that is exact), solink/../appkeeps namingreal/appwhile blank/URL handling and non-existent-path behavior stay unchanged.Validation: a regression test will build
link -> real/innerunder a temp root and assert the CLI-normalizedapplication_pathstill names the existingreal/app, with the previous lexical result (<root>/app, missing) as the control; existingsrc/cliJsonPaths.test.tscases must stay green, plusnpm run check:fast.@XinwangTao commented on GitHub (Oct 19, 2026):
Thanks @dxqlovestudy — routing through absoluteCallerPath matches the realpath-first direction: it keeps the
..for the POSIX filesystem to resolve after the symlink, while lexical collapse stays exact on Win32. One boundary worth asserting in the regression test: a genuinely missing path should still surface the original ENOENT (the #2272 attribution case), so the fix restores symlink-parent selection without blurring real missing-path errors.@xu91102 commented on GitHub (Oct 20, 2026):
I reproduced this through the actual built public CLI at main
833136507dd79d959340b09862a53af344e4f1b3, using the pinned Node24.18.0 on macOS arm64.Nine isolated controls completed with unchanged authored input bytes:
invalid_request/ENOENT: relative and absoluteapplication_pathcontaininglink/../app, relativeexecutable_pathcontaining a symlink-parent traversal, and the same traversal inapplication_root. The OS filesystemrealpathresolves every selected input successfully; the diagnostic instead names the lexically collapsed sibling. These failures occur before the selected executable is invoked.execution_failure; this is not a successful Electron capture or real Electron qualification.The producing
resolveCliJsonPathsboundary calls lexicalpath.resolvebefore the service's filesystem canonicalization, so the latter cannot recover the original selection. The existingabsoluteCallerPathowner already preserves POSIX symlink/parent traversal and retains native Windows normalization. I am preparing a small correction at that shared CLI JSON boundary, without changing the Electron provider or MCP path contract.Related actual production diffs for #5029/#1273/#1412/#1472 were read: they concern JSON source-selection input, regular-file admission, decoding and capacity; they do not fix this named-path anchoring. Public CLI path admission and the finite launcher controls above are the observed scope. At that initial reproduction stage, full Electron application/browser capture, Windows/Linux hosts, installed-package and performance coverage had not yet been run.
Update: the three-file correction is now normally committed and pushed to my fork as d4ac83892, based on the tested main833 baseline. The shared adapter uses the existing caller-path owner; no provider, schema or MCP absolute-path change. There is currently no upstream PR or upstream CI for this fix.
Independent Standards and Spec review both passed on identical frozen inputs. Eleven affected test files passed98 tests across separate runs; fresh README5 gives12 distinct files103PASS/0skip, without adding overlapping/RED counts. Code checks (0 errors/1795 warnings), docs,1704-file discovery, actual installed-package CLI/MCP209tools/6prompts, exact-release update and awaited cleanup passed. The four original wrong rejections are corrected on the same compiled and installed inputs, with ordinary positives and missing/URL/blank refusals retained. The finite launcher still deliberately exits77; no successful Electron capture is claimed.
The other shared consumer, nested browser executable paths, was checked with20 existing regressions and30 additional public CLI controls across baseline/fixed compiled/installed entries. Controlled sessions and finite executables verify handoff/Evidence/error/cleanup behavior; the browser provider's existing second lexical resolve is unchanged. A separate native Chrome baseline probe completed one absolute-path scenario, then failed for a nested-relative executable with cleanup_incomplete; both raw outcomes were retained and no owned Chrome/profile remained at readback. These two baseline calls are excluded from the103PASS and do not qualify the fixed source. Fixed-source full native Electron/browser/CDP/agent/model, Windows/Linux hosts and performance remain unverified.
Later-main note: main
f93a0335a8c1a60bbf6debdca16675ba303e4422subsequently added a thirdresolveCliJsonPathsconsumer for evidence-filesource.pathininspect-analysis-view. I read that actual production diff; it adds the consumer and leaves the shared normalizer unchanged. The source/package/103PASS and two-consumer preservation evidence above remain bound to833. No later-main or new-consumer runtime pass is claimed; that preservation needs fresh integration checks before an upstream PR.Main coverage update (2026-10-21)
Main commit 1bfa60ac2 now fixes this report's core issue. I read the actual change and confirmed it is included in captured main
d0067ba34a39ea47dd7e11bb2e6169bc0938cc3f. My unsubmitted fork preparation is now on read-only HOLD to avoid a duplicate PR. I have not run the main fix through the complete original workflow, and do not transfer the fork's validation results to main or claim source adoption or author credit. No upstream PR was created from my branch.@morluto commented on GitHub (Oct 21, 2026):
Closing as fixed on main by
github.com/morluto/rea@1bfa60ac20, retained at current main67a6477f01.The shared CLI JSON input owner now uses absoluteCallerPath rather than lexical path.resolve, preserving POSIX symlink/parent traversal. Registered Electron, browser and analysis-view boundaries have regression coverage, including relative/absolute selection and invalid/missing suffix refusals; an acceptance test checks the selected Evidence identity through the built CLI. This also matches the current-main coverage update already posted in this issue.
This audit verified the committed producer and regression coverage by source inspection. It did not rerun the runtime reproduction or establish additional real-provider/platform coverage.