mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #4619] [Bug] Firmware input growth past the snapshot limit is reported as a provider execution failure #2400
Closed
opened 2026-10-17 21:04:10 +00:00 by bsakaguchi
·
2 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#2400
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 16, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/4619
Before submitting
Area
Evidence, artifacts, or reconstruction
Observed behavior
If a firmware input grows from 134217728 to 134217729 bytes after size admission but during snapshot copying, REA reports the primary failure as
execution_failure/execution_failure,retryable: false, with generic advice to runrea doctor. An input already at 134217729 bytes instead returnsinvalid_request/invalid_input,retryable: true, with apathissue explaining the 134217728-byte allowance. No producer command has run at the point of the snapshot failure.Both public commands,
inspect-firmware-regionsandextract-firmware, reproduced this in 3/3 growth attempts per command on each tested build. The release reportsexecution_failuredirectly. Themainbuild reports top-levelcleanup_incomplete, with the sameexecution_failurepreserved as its nested primary error. This report concerns the primary input-limit classification; it does not request hiding a real cleanup failure.Reproduction
This deterministic reproduction appends a real byte to an ordinary sparse input when its source read stream emits its first data chunk. It changes neither REA's error objects nor the 128 MiB allowance. It uses a preloader to set the platform value to Linux and existing placeholder executables to pass prerequisite admission on the tested macOS host. No real Binwalk, Unblob, or Linux resource limiter is exercised, and this does not establish real Linux provider behavior.
rea-agentsat the version below into a disposable directory. For source, install locked dependencies and runnpm run build:cached. Setentryto the absolute path of that build'sscripts/rea.mjs.preload.mjsin a fresh disposable directory. The hook acts only on the selected input handle and only whenAPPEND_DURING_COPY=1.entryset, run this shell block. Each invocation has its own empty HOME and TMPDIR. The first case grows during copying; the second starts oversized and is the control. Repeat the block against the other build. All four growth command/build combinations were run three times; each static control ran once.Both cases exit 1 and finish with a 134217729-byte input. Growth stderr confirms the append. The growth result contains
Firmware grew beyond the input byte budget; the static result contains the typedpathissue. Use a shell withouterrexit, since failures are the expected output.Expected behavior
Report exceeding the firmware input-size allowance during copying as a typed input/admission failure with the size allowance and stable-input correction guidance, consistently with rejecting an already oversized file. The existing firmware admission branch supplies
invalid_request/invalid_inputfor this same allowance. The firmware guide documents the 128 MiB limit and copying before analysis, but does not explicitly specify a category for growth during copying. This expectation is grounded in that existing admission behavior, rather than a claim that every changing-artifact workflow must useinvalid_input.Impact and scope
The refusal remains enforced. The observed defect is machine-readable attribution, retryability, and recovery guidance for a selected file that grows past the input limit. No successful oversized snapshot, source corruption, limit bypass, or downstream incident was observed. Natural race frequency, real Linux engines, and MCP transport were not measured.
REA version
Published npm
rea-agents6.5.0, confirmed byscripts/rea.mjs --version; currentmainsource commit0c7b6d834af2d044b23196e0e522cc2468327a1e, built locally. Both declare package version 6.5.0.Runtime and platform
Node.js v26.12.0; Darwin arm64. The CLI reproduction uses the controlled Linux platform value described above. A separate native production snapshot-boundary check retained Darwin and the unchanged byte allowance. The source build used this supported runtime rather than the repository's preferred development Node version.
Target and artifact context
Self-generated ordinary sparse firmware files, initially 128 MiB or 128 MiB plus one byte. The growth hook appends one real byte after streaming starts. No selected input is executed.
Interface
CLI
Earliest failure stage
Setup or provider admission
Relevant output or evidence
docs/firmware-analysis.md:153-157andsrc/firmware/FirmwareFiles.ts:102-103,282-289, withsrc/domain/analysisErrorProjection.ts:200andsrc/domain/analysisErrorPresentation.ts:220defining the existing input classification.src/firmware/FirmwareFiles.ts:107-111,255-262,src/firmware/FirmwareFailures.ts:101-106, andsrc/domain/analysisErrorProjection.ts:215in the tested main tree.Meaningful CLI output, omitting input paths and repeated cleanup wrappers:
A separate compiled production-boundary check on native Darwin, without the platform override, exercised
FirmwareFileAccess.snapshotand the normal firmware error projection. Stable 32-byte and exactly-at-limit inputs copied and closed successfully; the stable oversized file returnedinvalid_request/invalid_input; a real append past the allowance returned the same primaryexecution_failureinsidecleanup_incomplete. Each native firmware case ran once. The same native check observed Android's snapshot reader reject a 32-to-33-byte input change asinvalid_request/invalid_input, while its stable control succeeded. This is comparison evidence, not a universal artifact-category contract.Typed outcome or recovery expected
Keep refusing an input that crosses the limit during copying. Preserve a typed input/admission primary error with the byte allowance and stable-file recovery, matching the static oversized control. Keep successful snapshots at or below the allowance. If descriptor cleanup remains independently incomplete, retain that truthful cleanup wrapper and ownership diagnostics around the corrected primary outcome.
Analysis or suspected cause
Source-derived reasoning: the copy meter creates an ordinary Error for the known input-budget condition. The admission translator only converts nonregular-file errors, so the growth error reaches the generic
ProviderAdapterErrorfallback and its provider-oriented projection. Snapshotting occurs inFirmwareProvider.ts:328before the first producer version command at line 355. No existing firmware test was found that pins this growth classification. REA also has anartifact_changed/integrity_mismatchoutcome for other changing artifacts; maintainers may prefer that explicit mutation outcome, but generic provider recovery does not explain this detected input condition.Additional context
Related #4475 concerns firmware read-handle cleanup ownership and primary-outcome preservation; the cleanup wrapper above is separate from this report's primary classification. #4192 concerns PE resource-kind attribution, and #1855 concerns retry guidance after a missing firmware producer report. Open and closed issues and PRs were searched for firmware snapshot growth, the size allowance, and error-category terms. No matching report or last-known-good revision was found.
@morluto commented on GitHub (Oct 17, 2026):
Addressed the input-growth primary failure and related stream ownership in
0a51b246c. The meter now emits the same typed input/admission failure as static oversize rejection, with the byte allowance and stable-copy guidance. Independent cleanup failure remains truthful.Firmware now uses the existing owner-preserving
readArtifactFileChunksfor hashing, snapshot/range copying and publication. Destroying a pipeline no longer closes the source descriptor outside its owner. The canonical source also owns cancellation: competing pipeline signals and obsolete stream-error reinterpretation were removed after snapshot/range controls reproduced EIO being replaced by cancellation (2 failed, 29 passed in that intermediate candidate).Final validation on Node 24.18.0: 46 focused tests across four files passed, including actual native file growth from 128 MiB to one byte above the unchanged allowance, successful and denied close for both operations, exact-owner retry, a stable file exactly at the allowance, same-read EIO/cancellation, and existing finalization/mixed-owner/publication controls. Docs checks and five conformance tests passed. Native file IO and controlled faults on Darwin; no Linux firmware engines or public CLI growth reproduction claimed. Two separately selected Linux workspace checks were skipped on this host.
Bounded completed snapshot comparison against immediate parent
8451d2839: 32 MiB sparse source, identical size/digest, two alternating warm repeats/build plus separate first processes. Warm medians baseline/candidate: elapsed 0.07248/0.06984 s, CPU 0.06910/0.06844 s, sampled process-family RSS 64790528/57565184 bytes, result JSON tokens 51/51 (cl100k_base). No speed/memory improvement is established by these repeats; true cold, CLI/MCP/whole-agent/schema/request/retry and native-engine costs are unmeasured. Heavy Qodo tests remained stopped.Related remaining shared error-model defect: #4628. After a composite cleanup dependency resolves, its old wrapper still projects execution_failure while the typed primary survives in diagnostics. The firmware patch preserves the corrected primary and exact cleanup ownership; it does not claim to repair that shared post-recovery projection.
@coygeek commented on GitHub (Oct 18, 2026):
Closing as addressed on
mainby 0a51b246c. Firmware snapshot growth past the input allowance now produces the same typed input/admission failure as initial oversize rejection, with stable-copy guidance, while retaining independent cleanup failures. I verified the committed source and regression coverage; I have not rerun the runtime reproduction.