[PR #2400] [CLOSED] feat(native): retain LLDB source coordinates and verify Pascal call entries #5202

New issue

Closed

opened 2026-10-31 01:04:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:04:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2400
Author: @matbrgz
Created: 10/12/2026
Status: ❌ Closed

Base: main ← Head: feat/native-call-source-locations

📝 Commits (2)

72e0888 feat(native): retain LLDB source coordinates and verify Pascal call entries
6103051 docs: namespace native specifications by domain and feature

📊 Changes

15 files changed (+371 additions, -2 deletions)

View changed files

📝 bridge/native/rea_lldb_tracer.py (+15 -0)
📝 bridge/native/test_rea_lldb_tracer.py (+45 -0)
📝 docs/native-investigation.md (+19 -0)
➕ docs/specs/native/call-source-locations/plan.md (+39 -0)
➕ docs/specs/native/call-source-locations/spec.md (+36 -0)
➕ docs/specs/native/call-source-locations/tasks.md (+9 -0)
➕ docs/specs/native/call-source-locations/verification.md (+22 -0)
📝 package.json (+1 -0)
📝 scripts/verify-native-calls.mjs (+18 -0)
➕ scripts/verify-native-pascal-calls.mjs (+97 -0)
📝 src/domain/native/nativeCallObservation.ts (+9 -0)
📝 tests/boundary/mcp/nativeCallObservationMcp.test.ts (+15 -1)
📝 tests/boundary/providers/native/lldbRetainedObservations.test.ts (+19 -0)
📝 tests/boundary/providers/native/nativeCallObservation.test.ts (+11 -1)
➕ tests/conformance/native/calls.pas (+16 -0)

📄 Description

Native call entries, resolved breakpoint locations and caller frames now retain optional nullable LLDB source coordinates. Valid partial line metadata is preserved without reading source files; older captures can omit the field.

The same existing bounded macOS call-observation lane now has an owned Free Pascal fixture and an explicit caller-selected compiler verifier. It verified three expected Pascal entries, integer-register values and source locations through actual CLI and stdio MCP on Free Pascal 3.2.2 / Darwin AArch64 and LLDB 2103.0.34.103. This does not add a GDB adapter, typed Pascal local inspection, source breakpoints or interactive stepping.

Validation: 10 Python tests; 18 focused provider/retained-journal/MCP tests; all six repository static tasks and architecture guards; exact discovery of 982 test files. A single-feature spec/plan/tasks and verification record are included.

Draft: the broader real native-call verifier failed in event-limit and launch start-identity scenarios. #2397 records the actual observations and the need to isolate them against unchanged upstream. Normal source-coordinate scenarios completed before those failures. This PR does not weaken those assertions or claim a fully passing real lane.

Refs #2382, #2372, #2397. Parent language tracker: #2383.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2400 **Author:** [@matbrgz](https://github.com/matbrgz) **Created:** 10/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/native-call-source-locations` --- ### 📝 Commits (2) - [`72e0888`](https://github.com/morluto/rea/commit/72e0888c363c5497b004dd3c57df8457fbe91def) feat(native): retain LLDB source coordinates and verify Pascal call entries - [`6103051`](https://github.com/morluto/rea/commit/6103051782821952b4271d27ebf0c254d2fe2326) docs: namespace native specifications by domain and feature ### 📊 Changes **15 files changed** (+371 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bridge/native/rea_lldb_tracer.py` (+15 -0) 📝 `bridge/native/test_rea_lldb_tracer.py` (+45 -0) 📝 `docs/native-investigation.md` (+19 -0) ➕ `docs/specs/native/call-source-locations/plan.md` (+39 -0) ➕ `docs/specs/native/call-source-locations/spec.md` (+36 -0) ➕ `docs/specs/native/call-source-locations/tasks.md` (+9 -0) ➕ `docs/specs/native/call-source-locations/verification.md` (+22 -0) 📝 `package.json` (+1 -0) 📝 `scripts/verify-native-calls.mjs` (+18 -0) ➕ `scripts/verify-native-pascal-calls.mjs` (+97 -0) 📝 `src/domain/native/nativeCallObservation.ts` (+9 -0) 📝 `tests/boundary/mcp/nativeCallObservationMcp.test.ts` (+15 -1) 📝 `tests/boundary/providers/native/lldbRetainedObservations.test.ts` (+19 -0) 📝 `tests/boundary/providers/native/nativeCallObservation.test.ts` (+11 -1) ➕ `tests/conformance/native/calls.pas` (+16 -0) </details> ### 📄 Description Native call entries, resolved breakpoint locations and caller frames now retain optional nullable LLDB source coordinates. Valid partial line metadata is preserved without reading source files; older captures can omit the field. The same existing bounded macOS call-observation lane now has an owned Free Pascal fixture and an explicit caller-selected compiler verifier. It verified three expected Pascal entries, integer-register values and source locations through actual CLI and stdio MCP on Free Pascal 3.2.2 / Darwin AArch64 and LLDB 2103.0.34.103. This does not add a GDB adapter, typed Pascal local inspection, source breakpoints or interactive stepping. Validation: 10 Python tests; 18 focused provider/retained-journal/MCP tests; all six repository static tasks and architecture guards; exact discovery of 982 test files. A single-feature spec/plan/tasks and verification record are included. **Draft:** the broader real native-call verifier failed in event-limit and launch start-identity scenarios. #2397 records the actual observations and the need to isolate them against unchanged upstream. Normal source-coordinate scenarios completed before those failures. This PR does not weaken those assertions or claim a fully passing real lane. Refs #2382, #2372, #2397. Parent language tracker: #2383. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:04:46 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5202

No description provided.

Rows
Columns