[PR #949] [MERGED] fix(mcp): advertise reserved process environment key #2526

New issue

Closed

opened 2026-10-17 21:07:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/949
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: codex/luna-schema-contracts

📝 Commits (2)

5bf8380 fix(mcp): advertise reserved process environment key
638da94 Merge remote-tracking branch 'origin/main' into codex/luna-schema-contracts

📊 Changes

8 files changed (+122 additions, -26 deletions)

View changed files

📝 docs/product-catalog.json (+2 -2)
📝 docs/verification/managed-conformance-manifest.json (+2 -2)
📝 skills/reverse-engineer-anything/SKILL.md (+1 -1)
📝 src/contracts/sessionToolContracts.ts (+1 -1)
📝 src/domain/processScenario.test.ts (+31 -7)
📝 src/domain/processScenario.ts (+8 -12)
📝 src/generatedMcpToolCatalog.ts (+1 -1)
📝 tests/boundary/mcp/toolSchemaValidity.test.ts (+76 -0)

📄 Description

Summary

Advertise the exact reserved process environment key in the canonical capture_process_scenario contract so SDK clients reject REA_PROCESS_RUN_ID before invocation. The Zod schema keeps the same exact-key semantics: a terminal newline remains accepted, matching the existing server behavior, and empty keys retain an actionable diagnostic.

Regenerated the canonical MCP catalog and derived product/skill/conformance metadata.

Verification

npm run format:check
npm run build:cached
npm run check:fast
npm run docs:check
npm run test:focused -- src/domain/processScenario.test.ts tests/boundary/mcp/toolSchemaValidity.test.ts

The SDK client regression validates the advertised Ajv schema against the canonical Zod parser and confirms an exact reserved-key call is rejected before the handler runs. docs:check reports the existing managed conformance manifest as complete:false.

No live Hopper or Ghidra verification was relevant to this contract change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/949 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/luna-schema-contracts` --- ### 📝 Commits (2) - [`5bf8380`](https://github.com/morluto/rea/commit/5bf8380e29508960f00f9427e1c3088d4147b067) fix(mcp): advertise reserved process environment key - [`638da94`](https://github.com/morluto/rea/commit/638da94b635d7980e388feb3e86ab918d276606d) Merge remote-tracking branch 'origin/main' into codex/luna-schema-contracts ### 📊 Changes **8 files changed** (+122 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `docs/product-catalog.json` (+2 -2) 📝 `docs/verification/managed-conformance-manifest.json` (+2 -2) 📝 `skills/reverse-engineer-anything/SKILL.md` (+1 -1) 📝 `src/contracts/sessionToolContracts.ts` (+1 -1) 📝 `src/domain/processScenario.test.ts` (+31 -7) 📝 `src/domain/processScenario.ts` (+8 -12) 📝 `src/generatedMcpToolCatalog.ts` (+1 -1) 📝 `tests/boundary/mcp/toolSchemaValidity.test.ts` (+76 -0) </details> ### 📄 Description ## Summary Advertise the exact reserved process environment key in the canonical `capture_process_scenario` contract so SDK clients reject `REA_PROCESS_RUN_ID` before invocation. The Zod schema keeps the same exact-key semantics: a terminal newline remains accepted, matching the existing server behavior, and empty keys retain an actionable diagnostic. Regenerated the canonical MCP catalog and derived product/skill/conformance metadata. ## Verification - `npm run format:check` - `npm run build:cached` - `npm run check:fast` - `npm run docs:check` - `npm run test:focused -- src/domain/processScenario.test.ts tests/boundary/mcp/toolSchemaValidity.test.ts` The SDK client regression validates the advertised Ajv schema against the canonical Zod parser and confirms an exact reserved-key call is rejected before the handler runs. `docs:check` reports the existing managed conformance manifest as `complete:false`. No live Hopper or Ghidra verification was relevant to this contract change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:11 +00:00