[PR #2946] [CLOSED] test(package): require exact client backup bytes #5509

New issue

Closed

opened 2026-10-31 01:07:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2946
Author: @AICodeLion
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: codex/claude-backup-readback

📝 Commits (1)

6fb2672 test(package): require exact client backup bytes

📊 Changes

3 files changed (+90 additions, -6 deletions)

View changed files

➕ scripts/verify-package-setup.d.mts (+6 -0)
📝 scripts/verify-package-setup.mjs (+12 -6)
➕ tests/boundary/filesystem/packageClientBackup.test.ts (+72 -0)

📄 Description

Fixes #2526. The packaged client backup check accepted any file containing existing, including the post-setup configuration. Capture each client configuration before setup and require its backup to match those exact bytes. The existing live-registration checks still run for Claude Desktop and Cursor.

Validation on Windows x64, pinned Node 24.18.0/npm 11.16.0, base ebaaa79c:

Restoring the old predicate makes both wrong-backup regressions fail because the verifier accepts the files. Final filesystem-boundary suite: 3 tests pass, including substituted active settings, changed trailing text, malformed UTF-8 bytes that decode identically, and invalid live registration.
build:cached, check:fast, knip, test discovery (1,113 files), changed-file formatting, git diff --check and npm pack --dry-run pass.
Required npm run check is blocked by unchanged formatting on docs/readme/README_tr.md and scripts/lib/clean-linux-hopper-runtime.mjs. Both are identical to the pinned base.
Required npm run verify:package fails at the pre-existing repository-skill stage on Windows with spawn npm ENOENT, before setup verification. The complete package lane was not established; the focused regression crosses the actual backup filesystem boundary. No live Claude Desktop claim.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2946 **Author:** [@AICodeLion](https://github.com/AICodeLion) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/claude-backup-readback` --- ### 📝 Commits (1) - [`6fb2672`](https://github.com/morluto/rea/commit/6fb2672b58d6be4716f5ae5cfab4ca993e43f18a) test(package): require exact client backup bytes ### 📊 Changes **3 files changed** (+90 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `scripts/verify-package-setup.d.mts` (+6 -0) 📝 `scripts/verify-package-setup.mjs` (+12 -6) ➕ `tests/boundary/filesystem/packageClientBackup.test.ts` (+72 -0) </details> ### 📄 Description Fixes #2526. The packaged client backup check accepted any file containing `existing`, including the post-setup configuration. Capture each client configuration before setup and require its backup to match those exact bytes. The existing live-registration checks still run for Claude Desktop and Cursor. Validation on Windows x64, pinned Node 24.18.0/npm 11.16.0, base ebaaa79c: - Restoring the old predicate makes both wrong-backup regressions fail because the verifier accepts the files. Final filesystem-boundary suite: 3 tests pass, including substituted active settings, changed trailing text, malformed UTF-8 bytes that decode identically, and invalid live registration. - build:cached, check:fast, knip, test discovery (1,113 files), changed-file formatting, git diff --check and npm pack --dry-run pass. - Required npm run check is blocked by unchanged formatting on docs/readme/README_tr.md and scripts/lib/clean-linux-hopper-runtime.mjs. Both are identical to the pinned base. - Required npm run verify:package fails at the pre-existing repository-skill stage on Windows with spawn npm ENOENT, before setup verification. The complete package lane was not established; the focused regression crosses the actual backup filesystem boundary. No live Claude Desktop claim. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:11 +00:00