[PR #998] [MERGED] fix(build): clarify generated-file check hint and drop redundant catalog step #2567

New issue

Closed

opened 2026-10-17 21:07:40 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:07:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/998
Author: @morluto
Created: 10/7/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @morluto

Base: main ← Head: fix/generated-check-hint

📝 Commits (1)

a24e479 fix(build): clarify generated-file check hint and drop redundant catalog step

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 package.json (+1 -1)
📝 scripts/lib/generated-file.mjs (+1 -1)

📄 Description

Summary

Follow-up to #997 (build-generated MCP catalog).

scripts/lib/generated-file.mjs: stale-file hint no longer says "commit the result" unconditionally — it now says to regenerate and commit only if the file is tracked. The old wording was wrong for the gitignored catalog.
mcp-catalog:generate is now npm run build:cached (build:unlocked already runs the generator; the trailing explicit invocation was pure redundancy with identical output).

Verification

npm run docs:check, git diff --check clean (pre-change, same tree)
No logic changes; message string + npm script wiring only

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/998 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/7/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/generated-check-hint` --- ### 📝 Commits (1) - [`a24e479`](https://github.com/morluto/rea/commit/a24e479cca5f1b2d9d8f0a0644a17ef682ef7fd9) fix(build): clarify generated-file check hint and drop redundant catalog step ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -1) 📝 `scripts/lib/generated-file.mjs` (+1 -1) </details> ### 📄 Description ## Summary Follow-up to #997 (build-generated MCP catalog). - `scripts/lib/generated-file.mjs`: stale-file hint no longer says "commit the result" unconditionally — it now says to regenerate and commit only if the file is tracked. The old wording was wrong for the gitignored catalog. - `mcp-catalog:generate` is now `npm run build:cached` (build:unlocked already runs the generator; the trailing explicit invocation was pure redundancy with identical output). ## Verification - `npm run docs:check`, `git diff --check` clean (pre-change, same tree) - No logic changes; message string + npm script wiring only --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:07:40 +00:00