[PR #1281] [MERGED] fix(ci): pass selected environment to Windows Ghidra fixture #2763

New issue

Closed

opened 2026-10-17 21:09:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:09:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1281
Author: @N0zoM1z0
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/windows-ghidra-launcher-ci

📝 Commits (1)

a85ecdd fix(ci): pass selected environment to Windows Ghidra fixture

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 tests/boundary/providers/ghidra/ghidraLauncher.test.ts (+2 -1)

📄 Description

The Windows Ghidra batch-launcher test supplied an empty environment after launchers changed to caller-selected environment snapshots. The fixture could no longer find Node, so both recent main CI runs timed out waiting for launch-capture.json.ready.

Pass the test's selected environment explicitly. This also includes the injected JVM options that the existing isolation assertions must exercise. Production launch behavior and the descriptor, authority, environment-isolation and cleanup assertions are unchanged.

Validation:

Focused Ghidra launcher tests: 7 passed on Linux; the Windows batch-launcher case is platform-skipped locally and requires Windows CI.
npm run check:fast: passed.
Failure evidence: latest main Windows lane.

No real Hopper or Ghidra analysis was performed for this fixture-only correction.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1281 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/9/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/windows-ghidra-launcher-ci` --- ### 📝 Commits (1) - [`a85ecdd`](https://github.com/morluto/rea/commit/a85ecdd927becffd6fc76927ba65d7c072f58998) fix(ci): pass selected environment to Windows Ghidra fixture ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/providers/ghidra/ghidraLauncher.test.ts` (+2 -1) </details> ### 📄 Description The Windows Ghidra batch-launcher test supplied an empty environment after launchers changed to caller-selected environment snapshots. The fixture could no longer find Node, so both recent main CI runs timed out waiting for `launch-capture.json.ready`. Pass the test's selected environment explicitly. This also includes the injected JVM options that the existing isolation assertions must exercise. Production launch behavior and the descriptor, authority, environment-isolation and cleanup assertions are unchanged. Validation: - Focused Ghidra launcher tests: 7 passed on Linux; the Windows batch-launcher case is platform-skipped locally and requires Windows CI. - `npm run check:fast`: passed. - Failure evidence: [latest main Windows lane](https://github.com/morluto/rea/actions/runs/37930960082/job/113822705056). No real Hopper or Ghidra analysis was performed for this fixture-only correction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:09:58 +00:00