[GH-ISSUE #561] Test hygiene: platform-dependent assertions, absence-of-failure checks, and unlinked real claims #286

New issue

Closed

opened 2026-10-15 18:23:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 18:23:28 +00:00

Owner

Originally created by @morluto on GitHub (Oct 5, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/561

Remaining scope

Removed replay/permission tests and the renamed updater no longer define this scope. Live findings include host-dependent assertions in runtime acceptance. The process.env/API_URL snippets in JavaScriptSemanticGraphResources tests are analyzed source text, not live environment reads; that allegation is removed. Improve weak assertions only where they fail to establish the named result, and connect fake-backed provider suites to existing real verification lanes. Successful Result assertions and explicit invariant failures are not inherently defects.

Verification

Exercise representative valid and malformed producer data through the consumer boundary and assert the resulting observations, unknowns, or actionable failure. Keep CLI/MCP behavior aligned where applicable.

This scope was refreshed after removal of replay and permission plumbing and merge of PR #538; implementation is being addressed in the boundary root-cause cleanup.

Originally created by @morluto on GitHub (Oct 5, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/561 ## Remaining scope Removed replay/permission tests and the renamed updater no longer define this scope. Live findings include host-dependent assertions in runtime acceptance. The process.env/API_URL snippets in JavaScriptSemanticGraphResources tests are analyzed source text, not live environment reads; that allegation is removed. Improve weak assertions only where they fail to establish the named result, and connect fake-backed provider suites to existing real verification lanes. Successful Result assertions and explicit invariant failures are not inherently defects. ## Verification Exercise representative valid and malformed producer data through the consumer boundary and assert the resulting observations, unknowns, or actionable failure. Keep CLI/MCP behavior aligned where applicable. This scope was refreshed after removal of replay and permission plumbing and merge of PR #538; implementation is being addressed in the boundary root-cause cleanup.

bsakaguchi

2026-10-15 18:23:28 +00:00