[PR #286] [MERGED] test(ci): guard Windows Ghidra workflow isolation #1925

New issue

Closed

opened 2026-10-16 21:12:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:12:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/286
Author: @morluto
Created: 7/16/2026
Status: ✅ Merged
Merged: 7/16/2026
Merged by: @morluto

Base: main ← Head: test/windows-ghidra-workflow-guards

📝 Commits (1)

98540c8 test(ci): guard Windows Ghidra workflow isolation

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 tests/realGhidraWindowsWorkflow.test.ts (+2 -0)

📄 Description

Description

The real Windows Ghidra workflow already selects the Ghidra provider explicitly and avoids rebuilding the unrelated node-pty native dependency. Its trust-boundary test did not preserve either property, so a future workflow edit could expand the proof lane without failing CI.

This adds regression assertions that require REA_ANALYSIS_PROVIDER to remain ghidra and prohibit npm run rebuild:native in the self-hosted proof workflow. No workflow behavior changes.

Type of Change

Test coverage
CI guard

Testing Performed

npx vitest run --coverage.enabled=false tests/realGhidraWindowsWorkflow.test.ts
npm run format:check
npm run typecheck
git diff --check

Tool Contract Impact

None.

The missing invariants were identified by comparing the current workflow with Cossackx/rea PRs #3 and #4. The cache-upload prohibition from PR #4 was already tested; this closes the remaining regression-test gaps without importing the fork's older Windows provider design.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/286 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/16/2026 **Status:** ✅ Merged **Merged:** 7/16/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `test/windows-ghidra-workflow-guards` --- ### 📝 Commits (1) - [`98540c8`](https://github.com/morluto/rea/commit/98540c8a12722aaa005102518746916018107ccb) test(ci): guard Windows Ghidra workflow isolation ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tests/realGhidraWindowsWorkflow.test.ts` (+2 -0) </details> ### 📄 Description ## Description The real Windows Ghidra workflow already selects the Ghidra provider explicitly and avoids rebuilding the unrelated node-pty native dependency. Its trust-boundary test did not preserve either property, so a future workflow edit could expand the proof lane without failing CI. This adds regression assertions that require REA_ANALYSIS_PROVIDER to remain ghidra and prohibit npm run rebuild:native in the self-hosted proof workflow. No workflow behavior changes. ## Type of Change - [x] Test coverage - [x] CI guard ## Testing Performed - [x] npx vitest run --coverage.enabled=false tests/realGhidraWindowsWorkflow.test.ts - [x] npm run format:check - [x] npm run typecheck - [x] git diff --check ## Tool Contract Impact None. ## Related Context The missing invariants were identified by comparing the current workflow with Cossackx/rea PRs #3 and #4. The cache-upload prohibition from PR #4 was already tested; this closes the remaining regression-test gaps without importing the fork's older Windows provider design. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:12:34 +00:00