[PR #1408] [MERGED] fix(javascript): retain shorter literal metadata encodings #2864

New issue

Closed

opened 2026-10-17 21:11:09 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:11:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1408
Author: @N0zoM1z0
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/javascript-short-literal-metadata

📝 Commits (1)

ba1db3c fix(javascript): retain shorter literal metadata encodings

📊 Changes

2 files changed (+23 additions, -12 deletions)

View changed files

📝 docs/javascript-application-workflows.md (+10 -8)
📝 src/application/javascript/JavaScriptSemanticGraphValueProjection.ts (+13 -4)

📄 Description

#1407 removes large literal payload copies, but an always-hashed key and string literal label expand small values such as "ok". Compare the complete JSON representation with the digest/type representation and keep the shorter one. Exact values stay in properties.value; no limits or truncation are introduced. Short literal IDs and labels from 6.3.0 are preserved.

Follow-up to #1407; refs #723. On the owned "ok" fixture, CLI JSON drops from 37,601 to 37,522 bytes; the role key shrinks from 129 to 56 characters and the original label returns. The large fixture still retains the complete 1,572,864-character value with the earlier 69% CLI reduction and default stdio MCP recovery.

Validation:

56 focused tests on the current main base: semantic graph builder and real compiled CLI/default SDK stdio MCP regression, including typed 1/"1" seeds, empty strings and trace/ping continuation.
npm run check:fast (normal pre-push hook).
Integrated verification includes the provider Evidence deduplication changes that landed alongside #1407.

Static JavaScript change; no Hopper/Ghidra verification required. New IDs for hashed large literals remain documented; existing stored graphs continue to work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1408 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/javascript-short-literal-metadata` --- ### 📝 Commits (1) - [`ba1db3c`](https://github.com/morluto/rea/commit/ba1db3c701b76b1ad9c8ecd50a4381b0515b82e3) fix(javascript): retain shorter literal metadata encodings ### 📊 Changes **2 files changed** (+23 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `docs/javascript-application-workflows.md` (+10 -8) 📝 `src/application/javascript/JavaScriptSemanticGraphValueProjection.ts` (+13 -4) </details> ### 📄 Description #1407 removes large literal payload copies, but an always-hashed key and `string literal` label expand small values such as `"ok"`. Compare the complete JSON representation with the digest/type representation and keep the shorter one. Exact values stay in `properties.value`; no limits or truncation are introduced. Short literal IDs and labels from 6.3.0 are preserved. Follow-up to #1407; refs #723. On the owned `"ok"` fixture, CLI JSON drops from 37,601 to 37,522 bytes; the role key shrinks from 129 to 56 characters and the original label returns. The large fixture still retains the complete 1,572,864-character value with the earlier 69% CLI reduction and default stdio MCP recovery. Validation: - 56 focused tests on the current main base: semantic graph builder and real compiled CLI/default SDK stdio MCP regression, including typed `1`/`"1"` seeds, empty strings and trace/ping continuation. - `npm run check:fast` (normal pre-push hook). - Integrated verification includes the provider Evidence deduplication changes that landed alongside #1407. Static JavaScript change; no Hopper/Ghidra verification required. New IDs for hashed large literals remain documented; existing stored graphs continue to work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:11:09 +00:00