[PR #2864] [CLOSED] fix(mcp): declare binary session prerequisite process effects #5449

New issue

Closed

opened 2026-10-31 01:06:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2864
Author: @morluto
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: fix/recover-binary-session-process-effects

📝 Commits (1)

579ecbd fix(mcp): declare binary session prerequisite process effects

📊 Changes

2 files changed (+19 additions, -4 deletions)

View changed files

📝 src/contracts/toolEffects.test.ts (+18 -3)
📝 src/contracts/toolEffects.ts (+1 -1)

📄 Description

binary_session checks configured Android prerequisites, which can launch java --list-modules. Its canonical effect declaration now records launchesProcess: true, so the advertised MCP hints report readOnlyHint: false and openWorldHint: true.

The existing annotation-algebra test now constructs a typed effect-free base and preserves its assertions. Scope is limited to canonical metadata and that fixture. This recovers the isolated correction from #1669, originally contributed by @pompiliodonatoapp; the commit retains contributor credit.

Validation: traced the production handler through Android availability and the Java launcher, inspected the annotation consumers, formatted the two changed files with pinned Node 24.18.0 and two formatter threads, and completed git diff --check. Tests, typechecks, lint, builds, provider workloads and CI reruns were skipped at the maintainer's explicit request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2864 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/recover-binary-session-process-effects` --- ### 📝 Commits (1) - [`579ecbd`](https://github.com/morluto/rea/commit/579ecbd032e0f0390d0569c2706b621ec05cbf12) fix(mcp): declare binary session prerequisite process effects ### 📊 Changes **2 files changed** (+19 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/contracts/toolEffects.test.ts` (+18 -3) 📝 `src/contracts/toolEffects.ts` (+1 -1) </details> ### 📄 Description `binary_session` checks configured Android prerequisites, which can launch `java --list-modules`. Its canonical effect declaration now records `launchesProcess: true`, so the advertised MCP hints report `readOnlyHint: false` and `openWorldHint: true`. The existing annotation-algebra test now constructs a typed effect-free base and preserves its assertions. Scope is limited to canonical metadata and that fixture. This recovers the isolated correction from [#1669](https://github.com/morluto/rea/pull/1669), originally contributed by @pompiliodonatoapp; the commit retains contributor credit. Validation: traced the production handler through Android availability and the Java launcher, inspected the annotation consumers, formatted the two changed files with pinned Node 24.18.0 and two formatter threads, and completed `git diff --check`. Tests, typechecks, lint, builds, provider workloads and CI reruns were skipped at the maintainer's explicit request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:43 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5449

No description provided.

Rows
Columns