[PR #1448] [MERGED] test(javascript): reuse comparison node fixtures #2894

New issue

Closed

opened 2026-10-17 21:11:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:11:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1448
Author: @N0zoM1z0
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @N0zoM1z0

Base: main ← Head: test/javascript-comparison-node-fixture-reuse

📝 Commits (1)

c80985e test(javascript): reuse comparison node fixtures

📊 Changes

2 files changed (+13 additions, -17 deletions)

View changed files

📝 src/domain/javascript/javascriptApplicationChangeGraph.test.ts (+12 -16)
📝 src/domain/javascript/javascriptApplicationGraph.fixture.ts (+1 -1)

📄 Description

Combined main exceeds the duplicate-code gate after the comparison regressions were integrated: 8,476 duplicated lines out of 338,754 (approximately 2.5021%), above the unchanged 2.5% threshold. This also blocks the unrelated Android diagnostic PR #1443.

Reuse the existing application-graph fixture's typed node constructor in the changed-from provenance regression. Keep all assertion semantics, production code, scan exclusions and the threshold. The complete scan now passes at 8,459 / 338,750 lines (approximately 2.4971%).

Validation: all nine adjacent change-graph, version-comparison and relationship tests pass; full serial typecheck, lint, formatting and the complete npm run jscpd gate pass with the documented resource guard. The real tiny-target CLI/stdio MCP comparison for #1434 already produced byte-identical results and preserved right-hand provenance; this follow-up changes only test construction. No provider verification claim is added.

Closes #1446. Refs #1434, #1443, #1065.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1448 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `test/javascript-comparison-node-fixture-reuse` --- ### 📝 Commits (1) - [`c80985e`](https://github.com/morluto/rea/commit/c80985ef24ab567c1a495f249defc8211e2e6b3e) test(javascript): reuse comparison node fixtures ### 📊 Changes **2 files changed** (+13 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptApplicationChangeGraph.test.ts` (+12 -16) 📝 `src/domain/javascript/javascriptApplicationGraph.fixture.ts` (+1 -1) </details> ### 📄 Description Combined main exceeds the duplicate-code gate after the comparison regressions were integrated: 8,476 duplicated lines out of 338,754 (approximately 2.5021%), above the unchanged 2.5% threshold. This also blocks the unrelated Android diagnostic PR #1443. Reuse the existing application-graph fixture's typed node constructor in the changed-from provenance regression. Keep all assertion semantics, production code, scan exclusions and the threshold. The complete scan now passes at 8,459 / 338,750 lines (approximately 2.4971%). Validation: all nine adjacent change-graph, version-comparison and relationship tests pass; full serial typecheck, lint, formatting and the complete `npm run jscpd` gate pass with the documented resource guard. The real tiny-target CLI/stdio MCP comparison for #1434 already produced byte-identical results and preserved right-hand provenance; this follow-up changes only test construction. No provider verification claim is added. Closes #1446. Refs #1434, #1443, #1065. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:11:30 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:57 +00:00

[PR #2894] [CLOSED] fix(setup): keep Devin configuration JSON-formatted #5476

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2894

No description provided.

Rows
Columns