[PR #2894] [CLOSED] fix(setup): keep Devin configuration JSON-formatted #5476

New issue

Closed

opened 2026-10-31 01:06:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2894
Author: @morluto
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: cursor/restore-main-checks-1ffc

📝 Commits (3)

0e6d8ed fix(setup): keep Devin configuration JSON-formatted
d31485f test(ghidra): drop the duplicated path join import
d5ec547 test(cli): type the retained skill directory pairs

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 src/application/SupportedClients.ts (+1 -1)
📝 tests/boundary/cli/clientProfileLifecycle.test.ts (+3 -2)
📝 tests/boundary/mcp/ghidraInventoryMcp.test.ts (+0 -1)

📄 Description

Summary

Current main does not pass the local typecheck or lint gate. The empty DSH_HOME fix also changed Devin's configuration format from json to devin, and two tests no longer typecheck or lint. This restores those checks without changing Devin's mcp_config.json behavior.

Problem and expected behavior

npm run check:fast fails on current main:

SupportedClients.ts declares format: "devin", which is not a member of SetupClient["format"], so tsc fails.
tests/boundary/mcp/ghidraInventoryMcp.test.ts imports join twice.
tests/boundary/cli/clientProfileLifecycle.test.ts passes a string | undefined directory into join under noUncheckedIndexedAccess.

Devin configuration remains JSON. The retained-skill test still checks both skill directories.

Change and scope

Restore Devin's format to json. The client name stays devin; the format names the file shape.
Remove the duplicate node:path import.
Give the retained skill directory pairs a const tuple so each directory stays a string.

Contribution scope fit: ordinary fix inside existing setup and test boundaries. Maintainer scope decision: not applicable.

Contract and boundary impact

Semantic owner and earliest changed stage: SupportedClients owns client format. The test edits stay in their existing tests.
Contribution scope fit and linked maintainer decision: not applicable.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: Devin setup still writes mcp_config.json.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata: none.

Expected effects:

Read existing files or captured data.
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated: the retained-skill assertion is typed; no new behavior test. The Devin format change is a type-level restoration of the previous value.
Base reproduction: npm run check:fast failed on 855ed968 before these commits and passes after them.
User-visible CLI/MCP output: none.
Remaining proof gaps: no separate Devin setup run. The format value is the same string main had before af782dd5f.

Validation performed

npm run check:fast — typecheck and lint passed.
npm run test:focused -- tests/boundary/browser/cdpBrowserProvider.lifecycle_failures.test.ts — 14 passed, on the branch that also contains the browser cancellation fix.

Compatibility, safety, and release

No breaking change. Devin registrations stay JSON.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2894 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cursor/restore-main-checks-1ffc` --- ### 📝 Commits (3) - [`0e6d8ed`](https://github.com/morluto/rea/commit/0e6d8ed90fdb45850e203061b1f7660fb39c579b) fix(setup): keep Devin configuration JSON-formatted - [`d31485f`](https://github.com/morluto/rea/commit/d31485fd2af528644413e1d959c250fac2edd242) test(ghidra): drop the duplicated path join import - [`d5ec547`](https://github.com/morluto/rea/commit/d5ec547a91993dea67db87b11b8951355d611921) test(cli): type the retained skill directory pairs ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/application/SupportedClients.ts` (+1 -1) 📝 `tests/boundary/cli/clientProfileLifecycle.test.ts` (+3 -2) 📝 `tests/boundary/mcp/ghidraInventoryMcp.test.ts` (+0 -1) </details> ### 📄 Description  ## Summary Current `main` does not pass the local typecheck or lint gate. The empty `DSH_HOME` fix also changed Devin's configuration format from `json` to `devin`, and two tests no longer typecheck or lint. This restores those checks without changing Devin's `mcp_config.json` behavior. ## Problem and expected behavior `npm run check:fast` fails on current `main`: - `SupportedClients.ts` declares `format: "devin"`, which is not a member of `SetupClient["format"]`, so `tsc` fails. - `tests/boundary/mcp/ghidraInventoryMcp.test.ts` imports `join` twice. - `tests/boundary/cli/clientProfileLifecycle.test.ts` passes a `string | undefined` directory into `join` under `noUncheckedIndexedAccess`. Devin configuration remains JSON. The retained-skill test still checks both skill directories. ## Change and scope - Restore Devin's format to `json`. The client name stays `devin`; the format names the file shape. - Remove the duplicate `node:path` import. - Give the retained skill directory pairs a const tuple so each directory stays a string. Contribution scope fit: ordinary fix inside existing setup and test boundaries. Maintainer scope decision: not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: `SupportedClients` owns client format. The test edits stay in their existing tests. - Contribution scope fit and linked maintainer decision: not applicable. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: Devin setup still writes `mcp_config.json`. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details: not applicable. - Generated metadata: none. Expected effects: - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: the retained-skill assertion is typed; no new behavior test. The Devin format change is a type-level restoration of the previous value. - Base reproduction: `npm run check:fast` failed on `855ed968` before these commits and passes after them. - User-visible CLI/MCP output: none. - Remaining proof gaps: no separate Devin setup run. The format value is the same string `main` had before `af782dd5f`. ## Validation performed - `npm run check:fast` — typecheck and lint passed. - `npm run test:focused -- tests/boundary/browser/cdpBrowserProvider.lifecycle_failures.test.ts` — 14 passed, on the branch that also contains the browser cancellation fix. ## Compatibility, safety, and release No breaking change. Devin registrations stay JSON.  <div><a href="https://cursor.com/agents/bc-e320bc38-6035-49f1-a48a-b356ac8c1ffc?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-e320bc38-6035-49f1-a48a-b356ac8c1ffc&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:57 +00:00