[PR #1566] [CLOSED] fix(reference): preserve cancellation at traversal completion #2975

New issue

Closed

opened 2026-10-17 21:12:27 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:12:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1566
Author: @rudycelekli
Created: 10/10/2026
Status: ❌ Closed

Base: main ← Head: fix/reference-final-entry-cancellation-20261010

📝 Commits (1)

19e1789 fix(reference): preserve cancellation at traversal completion

📊 Changes

2 files changed (+26 additions, -0 deletions)

View changed files

📝 src/reference/ReferenceSourceReader.ts (+6 -0)
➕ tests/boundary/reference/finalEntryCancellation.test.ts (+20 -0)

📄 Description

A caller exclusion predicate can cancel traversal while excluding the final entry, but the reader still returns success. Check cancellation before publishing the completed source-tree result.

Validation: real filesystem boundary regression fails on baseline and passes fixed. Pinned Node24.18; npm run check and test discovery pass. No real-provider workflow was required or run.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1566 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/10/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/reference-final-entry-cancellation-20261010` --- ### 📝 Commits (1) - [`19e1789`](https://github.com/morluto/rea/commit/19e1789c712c586551301adf6c8c473eca16a3e1) fix(reference): preserve cancellation at traversal completion ### 📊 Changes **2 files changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/reference/ReferenceSourceReader.ts` (+6 -0) ➕ `tests/boundary/reference/finalEntryCancellation.test.ts` (+20 -0) </details> ### 📄 Description A caller exclusion predicate can cancel traversal while excluding the final entry, but the reader still returns success. Check cancellation before publishing the completed source-tree result. Validation: real filesystem boundary regression fails on baseline and passes fixed. Pinned Node24.18; npm run check and test discovery pass. No real-provider workflow was required or run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:12:27 +00:00