morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #1592] [MERGED] feat(ghidra): recover signed AArch64 relative jump tables #2992

New issue

Closed

opened 2026-10-17 21:12:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:12:39 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1592
Author: @RishTheFish21
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @morluto

Base: main ← Head: fix/487-signed-relative-tables

📝 Commits (4)

8ab1453 feat(ghidra): recover signed AArch64 relative jump tables
c7bd2cb chore: merge main into signed relative table recovery
4ca6d8e chore: sync latest main after conflict resolution
df04a99 fix(ghidra): preserve typed labels for normalized switch selectors

📊 Changes

6 files changed (+649 additions, -210 deletions)

View changed files

📝 bridge/ghidra/ReaGhidraBridge.java (+389 -184)
📝 docs/testing.md (+9 -9)
📝 scripts/verify-real-ghidra-function.mjs (+107 -0)
📝 scripts/verify-real-ghidra.mjs (+53 -17)
📝 tests/conformance/ghidra/README.md (+8 -0)
➕ tests/conformance/ghidra/relative-switch-signed.S (+83 -0)

📄 Description

Summary

Part of #487. REA's AArch64 relative jump-table matcher only recognised one shape: unsigned ldrb/ldrh entries, lsl #2 offsets and a b.hi bound. Hand-written code like the RenderScript blend kernel from the issue thread uses ldrsh, a uxtw index, plain byte offsets, a b.cs bound and a cbz that skips zero entries. This PR extends the matcher to those forms, still only when the bound, registers and table bytes check out exactly.

Problem and expected behavior

On the new fixture (same instruction shape as rsdIntrinsicBlend_K), main maps cases 0, 1, 2 and 4 from Ghidra's typed case labels. Case 3 is a zero entry that the cbz sends to its own path. Ghidra doesn't model the cbz, so it decodes that entry as a branch to the table's base address, which the br can never reach. REA then reported the base as a target with an unknown case, and case 3's real destination was missing.

Expected: every case maps to the code it actually reaches, with evidence, and anything REA can't prove stays unknown.

Change and scope

The matcher accepts signed byte/halfword entries, uxtw indexes, byte or lsl #2 offsets, b.hi or b.cs/b.hs bounds, and an optional cbz on the loaded entry. It still requires one straight-line path with no other branches into it, and an index bounded by the compare.
It now also runs when Ghidra exposes its own load table. Its result is only used when both agree on table address, entry size and count; otherwise Ghidra's view is kept unchanged.
Zero entries routed by cbz map to the cbz target. The base address Ghidra decodes for them is no longer listed as an unknown target; a limitation explains why it's unreachable.
New fixture tests/conformance/ghidra/relative-switch-signed.S, wired into the aarch64-jump-table lane as ELF, plus Mach-O on arm64 hosts.

Not included: reporting computed branches Ghidra can't resolve, and returning a partial dossier when the decompiler fails. Both are planned as a follow-up.

Contract and boundary impact

Semantic owner and earliest changed stage: Ghidra bridge (ReaGhidraBridge.java), jump-table inference.
CLI and MCP/tool-catalog contract: none. No schema changes; only evidence and limitation text and which mappings are filled in.
Provider, bridge, target-format, or platform compatibility: AArch64 only; other architectures are untouched.
Evidence, artifact, provenance, or reconstruction contract: uses the existing provenance values. More cases can now be mapped with high confidence; a decoded result never overrides Ghidra when they disagree.
Process execution, authorization, cleanup, or containment impact: none.
Generated metadata, package, or installation impact: none.

Evidence and regression coverage

Tests added or updated: the new fixture and verifyRelativeSignedSwitch, which checks every case target against the immediate written in the source.
Base reproduction or other evidence: with the matcher not running (current main behavior when Ghidra exposes a load table), the new check fails with Signed relative switch case 3 was not verified, and 0x100030 is reported as an unlabelled target.
User-visible CLI/MCP output: inspect_native_api now reports case 3 → the cbz target with high confidence, plus a limitation naming the unreachable base address.
Remaining proof gaps: see Validation.

For evidence-bearing changes:

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

npm run verify:ghidra:aarch64-jump-table on an Apple Silicon Mac (Ghidra 12.1.4, JDK 21, decompiler built with buildNatives): passed. relative-signed was verified for ELF and Mach-O; the existing relative-1/relative-2 fixtures and the cross-format AArch64 fixture still pass.
npm run check:

I ran the lane with the entry-alias boundary check skipped locally (not part of this PR). That check already fails on macOS arm64 on main: the fixture's interior label lands on the function entry, and even when moved, the Mach-O linker records it as a function start, so Ghidra makes it a function. I'll open a separate issue. Because of the skip, the imported_entry_alias_selection: true in the report is not evidence. Not run against the real librenderscript-toolkit.so, only against a fixture with the same shape. Not run on Linux.

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: real Ghidra 12.1.4 on macOS arm64 (see above). No Linux run.
Package or release metadata impact: none.
Security, privacy, process, or containment review: static analysis only; no new process or file access.

Review checklist

This PR addresses a concrete problem or an agreed enhancement.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1592 **Author:** [@RishTheFish21](https://github.com/RishTheFish21) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/487-signed-relative-tables` --- ### 📝 Commits (4) - [`8ab1453`](https://github.com/morluto/rea/commit/8ab1453e513b16d964975601aca1a6c35057f6ab) feat(ghidra): recover signed AArch64 relative jump tables - [`c7bd2cb`](https://github.com/morluto/rea/commit/c7bd2cbb5d862e7996a29d89bfe9a53adb5ffc57) chore: merge main into signed relative table recovery - [`4ca6d8e`](https://github.com/morluto/rea/commit/4ca6d8e43bf923c2648b0c3ba636a6600a389607) chore: sync latest main after conflict resolution - [`df04a99`](https://github.com/morluto/rea/commit/df04a99f204621fa5175b7d7cdcb98b2ca2846f4) fix(ghidra): preserve typed labels for normalized switch selectors ### 📊 Changes **6 files changed** (+649 additions, -210 deletions) <details> <summary>View changed files</summary> 📝 `bridge/ghidra/ReaGhidraBridge.java` (+389 -184) 📝 `docs/testing.md` (+9 -9) 📝 `scripts/verify-real-ghidra-function.mjs` (+107 -0) 📝 `scripts/verify-real-ghidra.mjs` (+53 -17) 📝 `tests/conformance/ghidra/README.md` (+8 -0) ➕ `tests/conformance/ghidra/relative-switch-signed.S` (+83 -0) </details> ### 📄 Description ## Summary Part of #487. REA's AArch64 relative jump-table matcher only recognised one shape: unsigned `ldrb`/`ldrh` entries, `lsl #2` offsets and a `b.hi` bound. Hand-written code like the RenderScript blend kernel from the issue thread uses `ldrsh`, a `uxtw` index, plain byte offsets, a `b.cs` bound and a `cbz` that skips zero entries. This PR extends the matcher to those forms, still only when the bound, registers and table bytes check out exactly. ## Problem and expected behavior On the new fixture (same instruction shape as `rsdIntrinsicBlend_K`), `main` maps cases 0, 1, 2 and 4 from Ghidra's typed case labels. Case 3 is a zero entry that the `cbz` sends to its own path. Ghidra doesn't model the `cbz`, so it decodes that entry as a branch to the table's base address, which the `br` can never reach. REA then reported the base as a target with an unknown case, and case 3's real destination was missing. Expected: every case maps to the code it actually reaches, with evidence, and anything REA can't prove stays unknown. ## Change and scope - The matcher accepts signed byte/halfword entries, `uxtw` indexes, byte or `lsl #2` offsets, `b.hi` or `b.cs`/`b.hs` bounds, and an optional `cbz` on the loaded entry. It still requires one straight-line path with no other branches into it, and an index bounded by the compare. - It now also runs when Ghidra exposes its own load table. Its result is only used when both agree on table address, entry size and count; otherwise Ghidra's view is kept unchanged. - Zero entries routed by `cbz` map to the `cbz` target. The base address Ghidra decodes for them is no longer listed as an unknown target; a limitation explains why it's unreachable. - New fixture `tests/conformance/ghidra/relative-switch-signed.S`, wired into the `aarch64-jump-table` lane as ELF, plus Mach-O on arm64 hosts. Not included: reporting computed branches Ghidra can't resolve, and returning a partial dossier when the decompiler fails. Both are planned as a follow-up. ## Contract and boundary impact - Semantic owner and earliest changed stage: Ghidra bridge (`ReaGhidraBridge.java`), jump-table inference. - CLI and MCP/tool-catalog contract: none. No schema changes; only evidence and limitation text and which mappings are filled in. - Provider, bridge, target-format, or platform compatibility: AArch64 only; other architectures are untouched. - Evidence, artifact, provenance, or reconstruction contract: uses the existing provenance values. More cases can now be mapped with high confidence; a decoded result never overrides Ghidra when they disagree. - Process execution, authorization, cleanup, or containment impact: none. - Generated metadata, package, or installation impact: none. ## Evidence and regression coverage - Tests added or updated: the new fixture and `verifyRelativeSignedSwitch`, which checks every case target against the immediate written in the source. - Base reproduction or other evidence: with the matcher not running (current `main` behavior when Ghidra exposes a load table), the new check fails with `Signed relative switch case 3 was not verified`, and `0x100030` is reported as an unlabelled target. - User-visible CLI/MCP output: `inspect_native_api` now reports case 3 → the `cbz` target with high confidence, plus a limitation naming the unreachable base address. - Remaining proof gaps: see Validation. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npm run verify:ghidra:aarch64-jump-table` on an Apple Silicon Mac (Ghidra 12.1.4, JDK 21, decompiler built with `buildNatives`): passed. `relative-signed` was verified for ELF and Mach-O; the existing `relative-1`/`relative-2` fixtures and the cross-format AArch64 fixture still pass. - `npm run check`:  I ran the lane with the entry-alias boundary check skipped locally (not part of this PR). That check already fails on macOS arm64 on `main`: the fixture's interior label lands on the function entry, and even when moved, the Mach-O linker records it as a function start, so Ghidra makes it a function. I'll open a separate issue. Because of the skip, the `imported_entry_alias_selection: true` in the report is not evidence. Not run against the real `librenderscript-toolkit.so`, only against a fixture with the same shape. Not run on Linux. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: real Ghidra 12.1.4 on macOS arm64 (see above). No Linux run. - Package or release metadata impact: none. - Security, privacy, process, or containment review: static analysis only; no new process or file access. ## Review checklist - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:12:39 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:07:27 +00:00

[PR #2992] [CLOSED] test(captures): cover retained cleanup lifecycle #5545

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2992

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns