[PR #2992] [CLOSED] test(captures): cover retained cleanup lifecycle #5545

New issue

Closed

opened 2026-10-31 01:07:27 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2992
Author: @maxazure
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: fix/capture-cleanup-launch-identity-2656

📝 Commits (4)

d49e92a fix(process): preserve retained capture launch identity
3173fa4 fix(process): retain public pending workspace paths
0223926 test(captures): cover retained cleanup lifecycle after upstream fix
fff9c6d Merge upstream main to refresh CI baseline

📊 Changes

1 file changed (+149 additions, -1 deletions)

View changed files

📝 tests/boundary/captures/captureProvider.test.ts (+149 -1)

📄 Description

Summary

Preserve capture cleanup lifecycle coverage after the production fix was incorporated on main in 599a8ee11, which references this PR. Related: #2656.

Problem and expected behavior

Unresolved process cleanup must retain launch identity and block workspace removal. Once process cleanup succeeds, a remaining workspace failure must report only the workspace and must not retry the settled owner. Successful cleanup must make repeated close harmless, and public pendingPaths must survive failed cleanup and clear after success.

Change and scope

Merged main d9cd239c5e without rewriting history. The effective diff is only tests/boundary/captures/captureProvider.test.ts: three production-service lifecycle scenarios and one public getter lifecycle test. Production files match that main revision. Retry assertions express ordering and state rather than fixed invocation totals.

Evidence and regression coverage

Main has retained-launch diagnostic coverage but lacks these lifecycle combinations and pendingPaths assertions. This supplement protects the corrected behavior; current main already contains the fix. The capture seam is inert and refuses process signaling.

Validation performed

Verified the exact tree published at head fff9c6d04d in an assistant-cloud Linux checkout with Node 24.18.0 / npm 11.16.0:

npm ci and required runtime build passed.
Focused regression tests: 7 files, 89 tests passed, no skips.
npm run check and npm run check:fast passed.
npm run verify:test-discovery passed (1,291 files); git diff --check passed.
The effective test-only diff is byte-for-byte unchanged after merging main.

The previous CI failures were matched by full test name against failing push CI 38505561204 on the exact old base 5830088520. This refresh incorporates upstream fixes; Current-head CI completed successfully on 2026-10-14. Source tests, all five boundary shards, portable inventory and CI required passed. The separate PR readiness status has not yet appeared on this head.

Normal local commit hooks ran but auto-fixed two unrelated upstream tests. Those unrelated edits were excluded from publication. The GitHub-published merge tree exactly matches the tree tested above; original branch history is preserved.

Contract and boundary impact

Semantic owner: existing production owners are unchanged; only regression tests change.
Contribution scope: focused coverage within existing capture/JEB boundaries; a new capability scope decision is not applicable.
CLI/MCP, Evidence, provider compatibility and generated metadata: unchanged by the effective diff.
Test effects: disposable fixture files and existing fixture Node subprocesses; no caller target, real engine or external service is acquired.

Compatibility, safety, and release

No production, package, installation or breaking change. The tests use injected provider seams; they do not establish real-engine or native-platform behavior. Independent review inspected the final code and validation logs; it did not independently execute tests.

Before merge

Focused regression coverage with resolved scope and authority.
Related issue linked; effective diff checked for unrelated changes and secrets.
Relevant checks passed locally; real-provider verification limits stated.
Required CI passes for the current head.

Author readiness

Human owner: @maxazure

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

The human owner confirmed personal review and responsibility on 2026-10-14. The effective test-only diff is unchanged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2992 **Author:** [@maxazure](https://github.com/maxazure) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/capture-cleanup-launch-identity-2656` --- ### 📝 Commits (4) - [`d49e92a`](https://github.com/morluto/rea/commit/d49e92aa57f742a02d958ff6e7ca2dc965930532) fix(process): preserve retained capture launch identity - [`3173fa4`](https://github.com/morluto/rea/commit/3173fa4f6ce1502130f92d0d7b5a1e26b7a5a2e5) fix(process): retain public pending workspace paths - [`0223926`](https://github.com/morluto/rea/commit/0223926a0a7325cfef1fa184330efcc526132843) test(captures): cover retained cleanup lifecycle after upstream fix - [`fff9c6d`](https://github.com/morluto/rea/commit/fff9c6d04d1aed97d739014c6d1686645eed9e8e) Merge upstream main to refresh CI baseline ### 📊 Changes **1 file changed** (+149 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/captures/captureProvider.test.ts` (+149 -1) </details> ### 📄 Description ## Summary Preserve capture cleanup lifecycle coverage after the production fix was incorporated on main in [599a8ee11](https://github.com/morluto/rea/commit/599a8ee11de6b1a7fb270e669b88d78b6be982d2), which references this PR. Related: #2656. ## Problem and expected behavior Unresolved process cleanup must retain launch identity and block workspace removal. Once process cleanup succeeds, a remaining workspace failure must report only the workspace and must not retry the settled owner. Successful cleanup must make repeated close harmless, and public pendingPaths must survive failed cleanup and clear after success. ## Change and scope Merged main d9cd239c5ed7b078ac07e1bad633723fb49d8f80 without rewriting history. The effective diff is only tests/boundary/captures/captureProvider.test.ts: three production-service lifecycle scenarios and one public getter lifecycle test. Production files match that main revision. Retry assertions express ordering and state rather than fixed invocation totals. ## Evidence and regression coverage Main has retained-launch diagnostic coverage but lacks these lifecycle combinations and pendingPaths assertions. This supplement protects the corrected behavior; current main already contains the fix. The capture seam is inert and refuses process signaling. ## Validation performed Verified the exact tree published at head fff9c6d04d1aed97d739014c6d1686645eed9e8e in an assistant-cloud Linux checkout with Node 24.18.0 / npm 11.16.0: - npm ci and required runtime build passed. - Focused regression tests: 7 files, 89 tests passed, no skips. - npm run check and npm run check:fast passed. - npm run verify:test-discovery passed (1,291 files); git diff --check passed. - The effective test-only diff is byte-for-byte unchanged after merging main. The previous CI failures were matched by full test name against failing push CI 38505561204 on the exact old base 58300885207133422af235e0f2b10658cf958b03. This refresh incorporates upstream fixes; [Current-head CI](https://github.com/morluto/rea/actions/runs/38629115831) completed successfully on 2026-10-14. Source tests, all five boundary shards, portable inventory and CI required passed. The separate PR readiness status has not yet appeared on this head. Normal local commit hooks ran but auto-fixed two unrelated upstream tests. Those unrelated edits were excluded from publication. The GitHub-published merge tree exactly matches the tree tested above; original branch history is preserved. ## Contract and boundary impact - Semantic owner: existing production owners are unchanged; only regression tests change. - Contribution scope: focused coverage within existing capture/JEB boundaries; a new capability scope decision is not applicable. - CLI/MCP, Evidence, provider compatibility and generated metadata: unchanged by the effective diff. - Test effects: disposable fixture files and existing fixture Node subprocesses; no caller target, real engine or external service is acquired. ## Compatibility, safety, and release No production, package, installation or breaking change. The tests use injected provider seams; they do not establish real-engine or native-platform behavior. Independent review inspected the final code and validation logs; it did not independently execute tests. ## Before merge - [x] Focused regression coverage with resolved scope and authority. - [x] Related issue linked; effective diff checked for unrelated changes and secrets. - [x] Relevant checks passed locally; real-provider verification limits stated. - [x] Required CI passes for the current head. ## Author readiness Human owner: @maxazure - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. The human owner confirmed personal review and responsibility on 2026-10-14. The effective test-only diff is unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:27 +00:00