[GH-ISSUE #5463] test(browser): cover SAZ capture-level limitation text #3321

New issue

Closed

opened 2026-10-31 00:39:08 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 00:39:08 +00:00

Owner

Originally created by @jayykernel on GitHub (Oct 20, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/5463

Summary

Add regression coverage for the capture-level SAZ limitation describing absent and zero-byte HTTP members.

Context

Follow-up to PR #5453, which fixes #5411.

The PR updates the SAZ capture-level limitation in src/browser/history/NodeCaptureAdapter.ts to state that absent and zero-byte HTTP members are reported as null. The new boundary test checks the per-record limitations for empty request/response members, but the capture-level sentence itself is not directly asserted.

Proposed change

Add a focused test at the appropriate adapter or capture-service layer verifying that the SAZ capture-level limitations describe both absent and zero-byte HTTP members as null. Prefer asserting the relevant contract rather than the entire long sentence, so unrelated wording improvements do not make the test brittle.

Acceptance criteria

A regression to wording that mentions only absent members causes the test to fail.
SAZ still distinguishes a missing/zero-byte HTTP member from an HTTP message with an empty body.
Other capture formats' limitation behavior remains unchanged.

This is a non-blocking test-coverage follow-up, not a report of a known runtime defect.

Originally created by @jayykernel on GitHub (Oct 20, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/5463 ## Summary Add regression coverage for the capture-level SAZ limitation describing absent and zero-byte HTTP members. ## Context Follow-up to [PR #5453](https://github.com/morluto/rea/pull/5453), which fixes [#5411](https://github.com/morluto/rea/issues/5411). The PR updates the SAZ capture-level limitation in `src/browser/history/NodeCaptureAdapter.ts` to state that absent and zero-byte HTTP members are reported as null. The new boundary test checks the per-record limitations for empty request/response members, but the capture-level sentence itself is not directly asserted. ## Proposed change Add a focused test at the appropriate adapter or capture-service layer verifying that the SAZ capture-level limitations describe both absent and zero-byte HTTP members as null. Prefer asserting the relevant contract rather than the entire long sentence, so unrelated wording improvements do not make the test brittle. ## Acceptance criteria - A regression to wording that mentions only absent members causes the test to fail. - SAZ still distinguishes a missing/zero-byte HTTP member from an HTTP message with an empty body. - Other capture formats' limitation behavior remains unchanged. This is a non-blocking test-coverage follow-up, not a report of a known runtime defect.

bsakaguchi closed this issue

2026-10-31 00:39:08 +00:00

bsakaguchi commented

2026-10-31 00:39:09 +00:00

Author

Owner

@morluto commented on GitHub (Oct 23, 2026):

Covered on main in github.com/morluto/rea@dbf8e1eacc. The existing compiled SAZ zero-byte workflow now requires the capture-level limitation to describe absent and zero-byte HTTP members as null, while valid HTTP messages retain an empty body string. HAR/qlog controls keep this SAZ-specific limitation out of other formats.

Validation: four adapter checks and the selected SAZ CLI boundary case passed. Removing the zero-byte wording deliberately fails the semantic assertion. Inputs were controlled archives; no real Fiddler capture was claimed.

@morluto commented on GitHub (Oct 23, 2026): Covered on main in https://github.com/morluto/rea/commit/dbf8e1eacc22da774ce4e373ffd6499bae2060f1. The existing compiled SAZ zero-byte workflow now requires the capture-level limitation to describe absent and zero-byte HTTP members as null, while valid HTTP messages retain an empty body string. HAR/qlog controls keep this SAZ-specific limitation out of other formats. Validation: four adapter checks and the selected SAZ CLI boundary case passed. Removing the zero-byte wording deliberately fails the semantic assertion. Inputs were controlled archives; no real Fiddler capture was claimed.

bsakaguchi referenced this issue

2026-10-31 00:39:53 +00:00

[GH-ISSUE #5595] [Bug] analyze selects the wrong workflow for bundle aliases and JavaScript directories named .app #3395

bsakaguchi referenced this issue

2026-10-31 01:09:28 +00:00

[PR #3511] [MERGED] fix(cli): route app bundles with trailing separators to native analysis #5791