mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #5851] [Feature] Expose firmware analysis budgets independently of publication recovery #3547
Closed
opened 2026-10-31 00:41:44 +00:00 by bsakaguchi
·
2 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#3547
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gensokyo-dev on GitHub (Oct 21, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/5851
Before submitting
Area
MCP or agent integration
Current limitation (source-derived)
At
f801b2fbfd28f4e3713adefddc7bd73db44c284c:FirmwareProviderstarts a fixed 120000 ms analysis phase after queue/retained-cleanup admission. It covers tool resolution/fingerprinting, frozen input acquisition, version/analysis commands and report/inventory work. Inspection finalization remains in that phase. Extraction switches to a separately selected publication/final-cleanup phase.FirmwareCommandindependently starts another fixed 120000 ms clock for each command. Adding a public outer knob alone would still leave longer commands clipped by this hidden deadline.FirmwareFailureshas precise publication recovery, but analysis timeouts use generic guidance. Current public inputs exposepublication_timeout_ms, not an analysis control; changing publication or only the MCP client deadline cannot repair an analysis timeout.prlimitpolicy separately fixes 120 CPU seconds per process, 1 GiB per-process address space and report/file/diagnostic bounds. These are not the same as wall-clock analysis time and must not silently become adjustable.Desired outcome and success criteria
Expose optional per-call
analysis_timeout_ms/ CLI--analysis-timeout-mson both firmware operations, default 120000 and integer timer range 1..2147483647. One phase owner should drive all command/consumption checks; remove the hidden fixed command clock rather than adding competing budgets. Keep queue waiting, retained-cleanup admission, extraction analysis, publication and whole-client delivery scopes explicit.Current success and completed partial/publication observations must preserve the actual selected settings. Historical missing settings stay unknown; explicit caller selection remains explicit and omission remains omission. Shared CLI/MCP validation must reject missing/mismatched settings in fresh results.
Errors should name the exact supported repair, units/range, client headroom and cleanup-before-retry boundary. Preserve source path/digest/range and extraction question. A retry must respect absent-output-directory and retained publication receipt semantics. Fixed CPU/memory/byte limits remain fixed; do not infer the cause of an ambiguous kill or suggest that more wall time raises those limits.
Use cases / alternatives
A legitimate scan/extraction may need more wall time for tool startup, I/O or analysis. Exact input-range/depth/output-budget choices can reduce work only when they preserve the caller's question. Raising publication time, setting an unsupported field, restarting an unchanged server or blindly repeating the failed request are not repairs for a hidden analysis deadline.
Expected interaction with targets
Read/freeze caller-selected firmware and launch the existing caller-supplied analyzers with current one-worker limits, default sandbox and owned cleanup. Extraction publishes verified regular files only to an explicitly selected absent destination; no mounts, extracted-code execution, provider installation or protection bypass.
Verification available so far
Source inspection and existing guide/contract comparison only. In this shell, firmware command variables are unset and Binwalk/Unblob were not found on PATH; existing
prlimit, Python, C compiler and7zare available. This is not a runtime timeout reproduction or real-provider qualification.NOT_ENOUGH_INFO: natural slow-firmware frequency, large/vendor-image performance and current real-engine coverage. Proposed checks are not completed results.
Verification details proposed
Fail-before/pass-after owner/service guards; controlled real owned-command deadlines and delayed consumption; distinct analysis/publication phase recovery; queued non-default settings; opaque cancellation, late completion, failed cleanup and retry with one output copy. Validate SDK-converted schemas and exact CLI/MCP controls, default/invalid/max settings, immutable inputs and retained Evidence. Use the existing generated gzip/USTAR/ELF independent oracle and actual supplied tools where available; simulated producers do not establish real engine behavior. Exercise actual Codex CLI corrected success and honest missing-provider/fixed-limit blockers. Record whole-session tokens, elapsed, CPU and sampled family RSS, with cold/warm and unmeasured costs explicit; bound concurrency and memory.
@gensokyo-dev commented on GitHub (Oct 21, 2026):
Executed recovery verification — PR #5863
Final tested head:
272f9fb15910deb656f4c8786f61f2ba3d0c08c9, based on latest main when work began (f801b2fb). Runtime files are unchanged from320a4a436; subsequent changes migrate native/managed/pwntools consumer assertions and verify capture ownership, including matching text from separate owners. Concurrent main changes have been checked for touched-path overlap; no overlap was observed at the last fetch. Follow-up to RepoPrompt comparison #5598 / timeout tracker #5808.Regression and public contracts
The audit distinguishes the canonical primary capture from pwntools' existing cleanup-owner snapshot used by failed-close receipts. An exploratory one-total-text-copy assertion was too strong for that existing provider representation: the corrected oracle preserves both owner scopes, requires no third generic-primary-history copy, and pins preservation even when different owners' text matches. No pwntools runtime change or text-based evidence deduplication was introduced. Further consolidation of that provider-specific snapshot lifetime would require explicit ownership/reference semantics and is not claimed here.
c93e6f6b; final320a4a436run had 17/18 expected endpoint outcomes, with selected-budget MCP inspection blocked by the independently reproduced baseline report-missing issue #5876. All actual timer/refusal outcomes matched. This is not an all-green real-provider claim.Actual Codex CLI behavior
Model: installed Codex 0.161.0,
gpt-6.1-sol; ephemeral/read-only agent, only the two REA firmware tools enabled, sequential calls. Prompts prescribe the first failing request and exact analyst question, but no recovery procedure. Extraction writes only to expressly authorized absent destinations. Final facts/digests are checked independently against the generated oracle.analysis_timeout_msto 120000 and returned correct gzip offset/length, including the exact final headpublication_timeout_ms, not analysis time; verified extraction with remaining gaps18 qualification sessions: 16 reached REA, 10 corrected successes + 6 correct blockers. Two pre-dispatch model reports of unavailable tools made zero calls and are not product passes; their cause is unestablished. No unchanged failed agent retries, shell commands, unexpected tools or surviving sampled process identities in completed sessions.
Whole-session cost / resource evidence
Counts include schemas/context, MCP startup, retries and final answers. Fresh processes, uncontrolled filesystem/model caches; these are not isolated REA token costs, cold-cache measurements or speedup claims. CPU is local process-family CPU reported by
/usr/bin/time; peak RSS is a 500ms sampled family estimate, tracked by PID/start identity, not a hard maximum.The four harness mistakes omitted explicit provider environment forwarding and are excluded only from qualification, not measured cost. One additional interrupted harness session has incomplete usage/timing; its partial artifacts are retained. Build/tool-setup/full-CI costs, cloud inference CPU and naturally slow/vendor-image performance are unmeasured. Tests/builds requested a 2-GiB Node heap and serial task scheduling; Codex harnesses requested 1 GiB, cases were serial and Binwalk built with one job. Earlier Codex-filtered MCP heap-variable inheritance was not independently verified, so no hard child-heap claim is made; the harness now forwards that variable explicitly for subsequent checks. No observed OOM.
Controlled real-command wall-time experiment (121-second wrapper delay before executing the actual pinned tool, not naturally slow firmware): baseline failed its fixed 120000ms budget (121.95s wall, 4.02s CPU, 353.20 MiB sampled family). Selecting 135000ms on the implementation succeeded with oracle-matching facts (122.97s, 4.20s, 352.62 MiB), repeated after admission repair (124.68s, 5.11s, 347.38 MiB). A later
c93e6f6battempt passed the old wall cap but ended in the baseline report-missing failure (124.71s, 6.83s, 353.61 MiB); it is not counted as successful extraction/inspection or a fixed upstream failure. All sampled families ended. Fixed per-process 120 CPU seconds / memory / byte limits were not raised or newly qualified by this idle-time experiment.Review scope and remaining gaps
Fixed launcher signal identity, repeated CLI-close output duplication at the common projection owner (also reused by SQLite), and interruption during awaited command cleanup while preserving earlier failure precedence. Clarified existing inspection cleanup scope rather than inventing an inapplicable publication control; non-default committed partial settings are tested. Reviewer threads include root cause, structural fix, executed checks and limits.
Pre-existing, separately recorded: #5876 (missing real Binwalk report, reproduced 2/12 on baseline before verified non-signaling cleanup; root cause unknown), #5845 (WABT
.exactOptionalrequiredness-test false positive, already reproduced before SQLite/firmware; concurrent main corrected the assertion). Separately recorded #5889: an unchanged process-success progress test failed a two-frame upper bound in CI, then passed on the same PR head without code changes; baseline 7/7 passed, so no exact baseline runtime reproduction is claimed. Fail-fast-cancelled shards were rerun, not silently accepted as passes. Staging refusal classification #5846, other provider rows in #5808, provider-specific cleanup snapshot consolidation, native resource-limit attribution, large/vendor firmware and non-Linux real-provider coverage are not solved here. No unrelated runtime failures were patched or safety/report validation relaxed.@gensokyo-dev commented on GitHub (Oct 21, 2026):
Merged and verified against the actual merge
Merged as
aa53c065387c58b4189d82c47f1f3445fc505e30. All 23 PR files match reviewed head272f9fb15910deb656f4c8786f61f2ba3d0c08c9byte-for-byte. Merge attribution: noCo-authored-by, one canonical KogasaAssisted-byfor the counterexample/regression workflow. Fresh detached merged checkout: pinned Node 24.18.0/npm 11.16.0,npm ciandnpm run build:cachedpassed (build 39.403s).Executed post-merge checks:
provider_timeouton both adapters. Fixture: official OpenWrt 24.10.0 Archer C7 v2 sysupgrade image, 6,947,141 bytes, SHA-256a1dedf75082aa0d35910c839faf9a9f7ab3b8dad11b91d3f94d766f169d91f2b, matching the official listing. Release signature was not verified. Static inspection only; no extraction, mounting, flashing or target execution.gpt-6.1-sol) on that merged runtime/image made the requested 1ms MCP call, read its timeout remediation, then selected 120000ms and succeeded. The prompt supplied no recovery procedure. It preserved the input/question and reported the two candidates accurately:lzmaoffset 512 / reported size 2,613,741;squashfsoffset 2,614,256 / reported size 4,293,768. A separate verifier matched the final answer's facts, digest and Evidence ID to the actual returned Evidence and checked its explicit unvalidated-partition/length limitation. No shell calls, unchanged failed retries or surviving sampled process identities.The official-image check establishes source-hash provenance and cross-adapter consistency of provider-reported candidates, not independent partition/size validity. The synthetic oracle supplies a different, explicitly narrower correctness check.
Post-merge costs: the official-image three-pair batch took 35.66s wall / 50.77s local process-family CPU / 1269.89MiB sampled peak family RSS. The added complete Codex session took 37.16s / 16.38s / 1186.69MiB, using 143,531 input tokens (120,704 cached) and 838 output tokens. MCP heap configuration was explicitly forwarded; native worker/resource policy was unchanged. RSS sampled every 500ms is an estimate, not a hard memory maximum.
Including this additional agent case, 19 qualification attempts comprise 11 corrected successes, 6 correctly explained blockers (including missing/misconfigured providers, missing limiter and fixed capacity), and 2 zero-call unavailable-tool reports that are not product passes. Four initial harness-environment mistakes remain excluded only from qualification: all 23 completed measured sessions cost 2,308,255 input tokens (1,900,800 cached), 12,826 output tokens, 692.62s wall / 218.11s local CPU, maximum sampled family RSS 1261.93MiB. One interrupted harness session has incomplete measurements and remains separately disclosed. These are whole-session costs including startup, catalogs/context, retries and final answers; caches were uncontrolled, so no cold-cache or speedup claim. Cloud inference and full CI/setup resource costs were not measured.
The earlier 535-pass / 4-platform-skip affected suite, successful final technical CI and automated-review disposition remain recorded above. Only the human-review declaration gate used the user's explicit admin-merge authorization; no human review was falsely attested and no technical check was bypassed. Known report-missing intermittency #5876 and progress-check intermittency #5889 remain open and are not claimed fixed; neither recurred in this post-merge batch. Remaining provider timeout/limit work stays tracked in #5808.