mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #7662] [Bug] PE import and load-config inspection returns PE Evidence for a ZZ-prefixed file #4585
Closed
opened 2026-10-31 00:51:01 +00:00 by bsakaguchi
·
1 comment
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#4585
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 28, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/7662
Before submitting
Area
Native analysis or decompilation
Observed behavior
These public commands both exit 0 for a synthetic file beginning with
ZZthat contains PE32+ headers at the offset declared by the bytes at offset 60:Both return Evidence with
subject.format: "pe"andnormalized_result.format: "pe32-plus". Imports reports complete coverage with zero imports. Load-config returnstls: null,load_config: nulland zero examined callbacks; it has no coverage field.For the same file, resources and certificates reject the missing MZ header, artifact inspection rejects the binary format, and native exports rejects the target. An MZ-prefixed control succeeds through all six commands. The pair differs at exactly byte 0.
Reproduction
The comparison reproduced in two independent fixture passes, including a replay of this inline script. No target was executed and no package-manager fixture was invoked.
Expected behavior
Reject the missing MZ identity with a typed format failure, rather than returning successful PE Evidence. Preserve success for the admitted MZ control.
The import documentation promises failure for malformed PE headers. Both operation guides describe inspection of selected PE32/PE32+ images. Neither guide literally states an MZ prerequisite; the exact signature requirement is additionally grounded in REA's canonical DOS declarations and existing executable/resource/certificate admission boundaries. The load-config guide's separate fail-closed guarantee concerns directory and callback storage, rather than all header validation.
Impact and scope
P2: two static inspectors return an incorrect successful format classification for a bounded malformed-input case. Imports adds an explicit completeness claim, and both Evidence subjects identify the bytes as PE. A caller combining them with artifact inspection receives inconsistent format facts.
Preflight through
inspect-artifactis a verified workaround for rejecting this exact input before invoking the specialized inspectors. No affected real-world corpus, downstream agent reliance, crash, data loss, execution or security-boundary crossing was observed. Only CLI delivery and this fixture pair were exercised; MCP and other layouts remain untested. No prior working revision was established.REA version
Exact
node scripts/rea.mjs --versionoutput:Source baseline:
65f1c447344a423fa2785847dbcea1e9a9e2454a.Runtime and platform
Node.js v24.22.1; macOS 27.0.1; arm64. No Windows runtime or disassembler was used.
Target and artifact context
Paired 1024-byte synthetic header/section fixtures: PE header at offset 128, AMD64 machine, PE32+ optional header, one
.rdatasection at RVA 4096/file offset 512, and 16 absent data directories. Prefixes are MZ and ZZ. Inspector acceptance of the MZ control does not establish Windows-loader or DOS-program validity.Interface
CLI
Earliest failure stage
Native analysis or reconstruction
Relevant output or evidence
Observed output of the inline script:
Selected fields from the successful ZZ import result's
normalized_result:Both specialized results have
subject.format: "pe". Their normalized analysis fields equal their MZ controls after excludingartifact, whose path and SHA-256 correctly differ. Resources and certificates includedetails.issues[0].message: "Expected an MZ PE image."in their failures.Contract sources at the baseline:
docs/pe-imports.md:3–7establishes PE image scope; lines 65–66 promise malformed-header failure.docs/pe-load-config.md:3–5establishes PE image scope; lines 41–47 specify the directory/callback guarantee.src/domain/dosMz.ts:31–37admits only exact MZ fixed declarations.src/domain/binaryTarget.ts:124–129requires leading MZ bytes before Windows-header parsing.src/native/pe/PeResourceLayout.ts:91–94requires the same signature for resources/certificates.Failure and reachability sources:
src/native/metadata/PeImage.ts:18–49checks failed DOS evidence only when the independently observed Windows header is not declared.src/domain/dosMz.ts:275–321retains DOS validity and Windows-signature observation separately; a PE signature can be observed despite failed MZ declarations.src/native/pe/PeImportParser.ts:153–160andsrc/native/pe/PeLoadConfigParser.ts:144–151use that shared reader. The CLI reproduction establishes public reachability.Typed outcome or recovery expected
A nonzero exit and typed malformed-format refusal for the ZZ file, without successful PE Evidence or complete import coverage. The precise error code should follow the existing operation contract.
Analysis or suspected cause
Source-derived: the shared reader treats a declared Windows signature as sufficient admission even when the separately parsed leading DOS declaration failed. This explains the two successful public results. It does not justify requiring every legacy DOS load-module field to validate for a PE image; the missing invariant demonstrated here is the exact leading MZ signature.
Additional context
Duplicate searches covered open/closed issues and comments, plus open/closed/merged PRs, using MZ, missing/invalid/non-MZ, PE signature and both command names. Related #7403 and PR #7530 concern valid DOS-only error classification. #5168 and PR #5216 concern overlapping headers in MZ-prefixed inputs. PR #7024 discusses shared layout ownership without reporting this missing-prefix success. Closed #2343 and merged PR #2384 concern high-bit signature aliases, a separate failure from skipping MZ admission for an arbitrary ZZ prefix. No matching report was found.
@xu91102 commented on GitHub (Oct 28, 2026):
Independently reproduced on current main
3d5c73f35c1d089807bf70e74da0e3002e08e52d, using the compiled CLI with pinned Node 24.22.1 on macOS arm64.For both PE32 and PE32+,
inspect-pe-importsandinspect-pe-load-configincorrectly exit 0 and return PE Evidence after changing only the leadingMZbytes toZZ(4 failing cases). The matching MZ controls succeed (4 cases); changing the PE signature instead is refused with exit 1 (4 controls). All six source-file hashes remained unchanged across the 12 CLI calls. These were synthetic static inputs; no executable was run.The shared
readPeImageconsumes Windows-header evidence without first admitting the fixed DOS source header. DOS load-module validity is separate: the fix should reuse the existing fixed-declaration result, rather than reject otherwise supported PE files for legacy DOS page/load declarations. I reviewed the relevant production diffs in #7024, #7530, #5216, #2384, #7013, #5510 and #1196; they address other readers, compatibility, or existing container refactoring rather than this missing admission in the two affected consumers.Preparing a focused shared-owner fix and CLI/MCP regressions. This work is AI-assisted; full Windows execution and native-loader behavior are outside this static-inspection check.
Delivered as upstream Draft PR #7709 from
xu91102:codex/pe-mz-admission(head0534fc4ef79f9fe526b9ae8389681d1880fb4a3d). Final local evidence: 389 distinct passing tests including README checks, full static/docs/discovery checks, independent Standards/Spec review, and 12 installed CLI + 12 installed stdio MCP calls on the same immutable initial samples. The first package-verifier cleanup ambiguity remains explicitly retained/unknown; its independent repeat passed. Current-head upstream CI/Codex are separate pending checks. Human readiness declarations remain unchecked.