mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 07:47:29 +00:00
[PR #4595] [CLOSED] fix(electron): complete wrapper removal through mutated raw-listener metadata #6328
Closed
opened 2026-10-31 01:13:36 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/procedure-reference-stacked
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6328
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4595
Author: @jayinvers
Created: 10/16/2026
Status: ❌ Closed
Base:
main← Head:fix/electron-raw-listener-removal📝 Commits (6)
bd94ca4fix(electron): complete wrapper removal through mutated raw-listener metadataddb50a4fix(electron): scope wrapper completion to its removal slot3f843e4test(ci): fit the shared cli-boundary worker heap to current main852bcb4fix(electron): make wrapper completion shift-proof and cheap5f569defix(electron): observe removal forwarding instead of inferring it34fa335fix(electron): scope removal flights and treat unknown getters conservatively📊 Changes
4 files changed (+1509 additions, -6 deletions)
View changed files
📝
docs/electron-observation.md(+57 -0)📝
scripts/electron-active-hook.cjs(+200 -4)📝
tests/boundary/browser/electronActiveHook.test.ts(+1247 -0)📝
vitest.config.ts(+5 -2)📄 Description
Summary
Fixes #4513. An application that mutates the writable
.listenermetadata of an observedipcMainentry (or installs a removal decorator) can still leave one listener registered afterremoveAllListeners: the merged #4389 traversal translates a wrapper to the caller's original function only while its public.listenerdata link still carries that function, so mutated metadata defeats the translation and the decorator receives and rejects the wrapper. This PR is rebased onto that merged architecture and completes removal through it.Problem and expected behavior
Smallest trigger (the issue's probe): register a listener through the hook, mutate
rawListeners("ch")[0].listenerto a foreign function, decorateremoveListenerto reject anything but the original, thenremoveAllListeners("ch").unexpected callback, and one listener remains. Executed: both new regression tests below fail on main's hook files (2 of 75).Change and scope
scripts/electron-active-hook.cjs, inside the merged traversal architecture:removeListenercaptured at patch time. Public metadata is never temporarily restored or rewritten.docs/electron-observation.mddocuments the policy and its visible limits (the recording wrapper remains visible torawListeners()). Tests intests/boundary/browser/electronActiveHook.test.ts.Follow the contribution scope.
Not applicable: policy refinement inside the existing observation hook; no new capability or target interaction.
Contract and boundary impact
scripts/electron-active-hook.cjs); earliest stage is runtime observation behavior.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
tests/boundary/browser/electronActiveHook.test.tsseen: [false], remaining: 1, failure: "unexpected callback"); the merged hook here passes all 75 tests in the file, including every test anchored by #4389.electron): before →hooked: {seen: [false], remaining: 1, failure: "unexpected callback"}vsplaincontrol{seen: [true], remaining: 0, failure: null}; after → hooked equals plain.For evidence-bearing changes:
Validation performed
Rebased onto main
61e68807(includes #4389) as a single commitab50a37f.npx vitest run tests/boundary/browser/electronActiveHook.test.ts— 75 passed (75).npm run check:fast— pass (typecheck + lint).npx oxfmt --checkon the three changed files — formatted.npm run verify:test-discovery— "Discovered all 1442 test files exactly once."npm run docs:check— pass.fix/electron-raw-listener-removal, same head commit):Compatibility, safety, and release
Review follow-up (2026-10-17)
Addressed both Greptile findings in commit
ddb50a4e(rebased onto maina0405334):Commit
3f843e4acherry-picks the sibling #4585 CI heap budget bump (384->512 MiB) so this branch's full CI can pass on current main; it elides automatically when #4585 merges.New head after round 1:
3f843e4a. Fork CI: https://github.com/jayinvers/rea/actions/runs/39020750573 — success (79/79 hook tests in shard 2/6).Review follow-up round 2 (2026-10-17)
Addressed the second Greptile round in commit
852bcb41:removeListenermeta-listener, plainremoveAllListenersbypasses the decorator (removes); with one, traversal dispatches throughthis.removeListenerper entry and a swallowing decorator KEEPS the registration. Completion now also requires the wrapper data.listenerto still defeat a native match for the translated target, so survival with matching metadata (a decorator that chose not to remove) is kept exactly like plain; the documented residual corner is a swallow with already-mutated metadata, which is state-identical to a forwarded native miss and completes like one.lastIndexOfon the live list, prepend-proof), and the in-flight re-registration mark is channel-scoped, so registering a saved wrapper on another channel no longer blocks the original channel's completion while same-channel restores still survive.listenerCountcomparison (captured before, compared after). The ordinary path (native match succeeded) performs zero listener-list work; the rescan runs only on a miss. Instrumented test: 64 successful decorated removals -> 0 scans; one metadata miss -> exactly 1 scan.New head:
852bcb41. Fork CI: https://github.com/jayinvers/rea/actions/runs/39022871896 — success (83/83 hook tests).Review follow-up round 3 (2026-10-17)
The third round showed that inferring "did the application forward the removal" from end state (a listener-count gate, a post-call metadata recheck) is unsound by construction. Commit
5f569de0replaces inference with observation:ipcMain.removeListeneris now patched at hook load like the other four methods — a pure pass-through for every direct call (unchanged arguments; one length check when no removal flight is active). Its only side effect: when a translated removal is in flight and the listener argument equals that flight's translated target, the flight is markedforwarded.forwarded && !satisfiedByNative && !reregistered &&the wrapper is still registered by identity (prepend-proof re-find).satisfiedByNativeis predicted before the native call inside the patched method by scanning from the end — native removal always removes its last match — for an entry equal to the target or whose data.listener(descriptor walk, getters never executed) names it; a predictable match proves the forwarded call removes one registration, so the request stands down (one removal per request for duplicates).New head:
5f569de0. Fork CI: https://github.com/jayinvers/rea/actions/runs/39024920449 — success (86/86 hook tests).Review follow-up round 4 (2026-10-18)
Addressed in commit
34fa3354:EventEmitter.prototype.off === EventEmitter.prototype.removeListenerandthis.off(...)does not dispatch through the instance's own property;ipcMain.offnow carries the identical pass-through and marker (directoffsemantics byte-identical). Explicit prototype dispatch (EventEmitter.prototype.removeListener.call(...)) and pre-hook captures bypass instance-property observation by construction; patching the shared prototype would affect every emitter in the process, which this observation hook must not do — those paths defer to plain native behavior, documented in code and docs/electron-observation.md.New head:
34fa3354. Fork CI: https://github.com/jayinvers/rea/actions/runs/39026784079 — success (89 hook tests).Author readiness
Human owner: @jayinvers
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.