[GH-ISSUE #7717] Deep static (knip) on main reports unused exported type HexRecordRegionMetadata since #7136 #4623

New issue

Open

opened 2026-10-31 00:51:30 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 00:51:30 +00:00

Owner

Originally created by @jimpablo on GitHub (Oct 28, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/7717

Observed

npm run knip on current main (b594fbc3e) reports:

Unused exported types (1)
HexRecordRegionMetadata  type  src/domain/artifactFormatMetadata.ts:167:13

Reproduced locally on a clean checkout of b594fbc3e (observed, not inferred). The export was introduced by #7136 (c36971953) and has no consumers on main.

Impact

The regular CI workflow stays green because knip runs only in the Deep static checks lane of the ci:full workflow. Any labeled PR whose merge ref includes current main fails that lane (example: the Deep static job of run 40638129856 on #2025, whose only knip finding is this one — the same text reproduces on main itself).

Suggested check

Remove the unused export or add its consumer, whichever #7136 intended. I have not verified why the type was left exported (possibly a planned follow-up consumer).

Originally created by @jimpablo on GitHub (Oct 28, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/7717 ## Observed `npm run knip` on current `main` (`b594fbc3e`) reports: ``` Unused exported types (1) HexRecordRegionMetadata type src/domain/artifactFormatMetadata.ts:167:13 ``` Reproduced locally on a clean checkout of `b594fbc3e` (observed, not inferred). The export was introduced by #7136 (`c36971953`) and has no consumers on `main`. ## Impact The regular CI workflow stays green because knip runs only in the Deep static checks lane of the `ci:full` workflow. Any labeled PR whose merge ref includes current `main` fails that lane (example: the Deep static job of run 40638129856 on #2025, whose only knip finding is this one — the same text reproduces on `main` itself). ## Suggested check Remove the unused export or add its consumer, whichever #7136 intended. I have not verified why the type was left exported (possibly a planned follow-up consumer).

bsakaguchi commented

2026-10-31 00:51:31 +00:00

Author

Owner

@555aaditya commented on GitHub (Oct 28, 2026):

Thanks @jimpablo, that one's mine. HexRecordRegionMetadata was never meant to have a consumer: region entries are validated through the format_metadata union that includes hexRecordRegionMetadataSchema, and no follow-up uses the inferred type. The removal in #7718 is the right fix. I'll run npm run knip before future artifact PRs, since the regular CI lane doesn't run it.

@555aaditya commented on GitHub (Oct 28, 2026): Thanks @jimpablo, that one's mine. `HexRecordRegionMetadata` was never meant to have a consumer: region entries are validated through the `format_metadata` union that includes `hexRecordRegionMetadataSchema`, and no follow-up uses the inferred type. The removal in #7718 is the right fix. I'll run `npm run knip` before future artifact PRs, since the regular CI lane doesn't run it.

bsakaguchi referenced this issue

2026-10-31 01:13:43 +00:00

[PR #4648] [CLOSED] fix(mcp): retain same-address procedure aliases in completion #6341

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4623

No description provided.

Rows
Columns