[PR #1621] [MERGED] test: remove module and timestamp assumptions from boundary fixtures #4707

New issue

Closed

opened 2026-10-31 00:54:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:54:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1621
Author: @N0zoM1z0
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/local-boundary-fixtures-20261010

📝 Commits (2)

a8887e9 test: remove module and timestamp assumptions from boundary fixtures
cc11ac7 Merge remote-tracking branch 'origin/main' into fix/local-boundary-fixtures-20261010

📊 Changes

2 files changed (+18 additions, -12 deletions)

View changed files

📝 tests/boundary/process/darwinProcessRunTokenReader.test.ts (+10 -10)
📝 tests/boundary/providers/native/nativeSignatureTargetBinding.test.ts (+8 -2)

📄 Description

Executable test fixtures under a temporary directory inside this ESM repository fail before their intended work with ReferenceError: require is not defined. Use the pinned Node runtime’s built-in module loader for fake compilers, generated identity helpers and their child jobs so the same fixtures work inside and outside an ESM package. Preserve the helper’s physical directory identity.

Make the same-content signature rewrite fixture explicitly change the captured modification time. An identical write can share a filesystem clock tick with the initial capture; the target-change assertion must exercise an observable metadata change.

Production behavior and CLI/MCP schemas are unchanged. Existing consumer tests continue to check cancellation, shared compilation, retained cleanup ownership, temporary-file removal and target identity. This does not duplicate the CDP/EVM/Qwen fixes in #1618.

Validation: 39 tests passed (7 platform/permission skips) with temporary directories inside the ESM checkout, and the same 39 passed with TMPDIR=/tmp; npm run check:fast. Linux x64, Node 24.18.0. Compiler and signature fixtures are controlled boundaries; real macOS Swift/codesign, Hopper and Ghidra were not verified locally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1621 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/local-boundary-fixtures-20261010` --- ### 📝 Commits (2) - [`a8887e9`](https://github.com/morluto/rea/commit/a8887e9aba717b07fc32f9a4eb951ea497decfd6) test: remove module and timestamp assumptions from boundary fixtures - [`cc11ac7`](https://github.com/morluto/rea/commit/cc11ac7c6db64f0ea8ca1795e88202bd0abceadb) Merge remote-tracking branch 'origin/main' into fix/local-boundary-fixtures-20261010 ### 📊 Changes **2 files changed** (+18 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/process/darwinProcessRunTokenReader.test.ts` (+10 -10) 📝 `tests/boundary/providers/native/nativeSignatureTargetBinding.test.ts` (+8 -2) </details> ### 📄 Description Executable test fixtures under a temporary directory inside this ESM repository fail before their intended work with `ReferenceError: require is not defined`. Use the pinned Node runtime’s built-in module loader for fake compilers, generated identity helpers and their child jobs so the same fixtures work inside and outside an ESM package. Preserve the helper’s physical directory identity. Make the same-content signature rewrite fixture explicitly change the captured modification time. An identical write can share a filesystem clock tick with the initial capture; the target-change assertion must exercise an observable metadata change. Production behavior and CLI/MCP schemas are unchanged. Existing consumer tests continue to check cancellation, shared compilation, retained cleanup ownership, temporary-file removal and target identity. This does not duplicate the CDP/EVM/Qwen fixes in #1618. Validation: 39 tests passed (7 platform/permission skips) with temporary directories inside the ESM checkout, and the same 39 passed with `TMPDIR=/tmp`; `npm run check:fast`. Linux x64, Node 24.18.0. Compiler and signature fixtures are controlled boundaries; real macOS Swift/codesign, Hopper and Ghidra were not verified locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:54:13 +00:00