[PR #4988] ci(windows): run the caller path separator regression in the Windows lane #6712

Open
opened 2026-11-01 21:42:28 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4988
Author: @Iyanuoluwa007
Created: 10/18/2026
Status: 🔄 Open

Base: main ← Head: ci/windows-separator-lane


📝 Commits (3)

  • 1a201e4 ci(windows): run the caller path separator regression in the Windows lane
  • 19c946f ci(windows): own the separator regression in the package change scope
  • 225afa3 test(ci): keep the separator regression in the Windows-only lane guard

📊 Changes

3 files changed (+3 additions, -0 deletions)

View changed files

📝 .github/workflows/ci.yml (+1 -0)
📝 scripts/ci/scopes.mjs (+1 -0)
📝 tests/process-global/curatedWindowsLane.test.ts (+1 -0)

📄 Description

Summary

Follow-up to #4733 (refs #4707). tests/boundary/filesystem/windowsTargetSeparators.test.ts runs only on Windows (it.runIf(process.platform === "win32")), and the windows-curated CI job runs an explicit file list that does not name it, so CI never executes it: Linux shards skip it and the Windows lane does not list it. This adds it to the lane, to the package change scope, and to the lane guard.

Problem and expected behavior

The #4733 regression catches Windows caller paths reaching native snapshot admission with forward slashes or repeated separators. Today it runs only when someone runs it by hand on Windows. It should run in windows-curated, which already runs binaryTarget.test.ts and the other Windows-only path tests #5807 added.

Change and scope

  • .github/workflows/ci.yml: add the file to "Run curated Windows capability tests", after the three files from #5807.
  • scripts/ci/scopes.mjs: add it to the package scope. ciChangeScope.test.ts requires every windows-curated path to belong to it, and package selects the Windows lane, so later edits to the test start that lane.
  • tests/process-global/curatedWindowsLane.test.ts: add the path to the existing arrayContaining guard for Windows-only cases (per review), instead of a separate test with the same reason.

The test needs no native build, Ghidra or Java: it writes a small PE fixture and calls parseBinaryTarget with four separator spellings.

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Contract and boundary impact

  • Semantic owner and earliest changed stage: CI test selection only (windows-curated file list, package change scope, lane guard).
  • Contribution scope fit and linked maintainer decision: not applicable (CI coverage for an existing test).
  • CLI and MCP/tool-catalog contract: none.
  • Provider, bridge, target-format, or platform compatibility: none; adds one Windows filesystem test to the existing Windows lane.
  • Evidence, artifact, provenance, or reconstruction contract: none.
  • Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable.
  • Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): none.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: tests/process-global/curatedWindowsLane.test.ts now also requires tests/boundary/filesystem/windowsTargetSeparators.test.ts in the Windows-only guard.
  • Base reproduction or other evidence: executed on Windows 11 x64, Node 24.22.1, head 225afa34b. curatedWindowsLane.test.ts (11 tests) + windowsTargetSeparators.test.ts (1 test): 12 passed, and the Windows-only separator test ran rather than being skipped. With the new ci.yml line removed from the working tree, the guard fails: 1 failed, 10 passed.
  • User-visible CLI/MCP output (if applicable): not applicable.
  • Remaining proof gaps: the windows-curated job has not run on this PR. Classify changes puts edits to ci.yml and scripts/ci/scopes.mjs on the fast tier, which skips that lane (thanks @CassieFox23 for finding this). A maintainer can apply ci:full to run it once; until then the Windows 11 run above stands in.

Not a boundary fix: no product code changes. For boundary fixes, identify the applicable boundary regressions
and lifecycle regressions
covered by the evidence above, and explain relevant gaps.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

  • npx vitest run tests/process-global/curatedWindowsLane.test.ts tests/boundary/filesystem/windowsTargetSeparators.test.ts (Windows 11, Node 24.22.1): 12 passed.
  • Same with the ci.yml entry removed from the working tree: 1 failed, 10 passed (the guard).
  • Adding tests/boundary/filesystem/ciChangeScope.test.ts to that run: 321 passed, 2 skipped.
  • Pre-push npm run check:fast (typecheck, lint): passed.

Compatibility, safety, and release

  • Breaking changes or migration steps: none.
  • Real Hopper/Ghidra, browser, or OS coverage: Windows 11 x64 locally; CI Windows lane pending (see proof gaps).
  • Package or release metadata impact: none.
  • Security, privacy, process, or containment review: none; the test writes a temporary fixture only.

Author readiness

Human owner: @Iyanuoluwa007

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4988 **Author:** [@Iyanuoluwa007](https://github.com/Iyanuoluwa007) **Created:** 10/18/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `ci/windows-separator-lane` --- ### 📝 Commits (3) - [`1a201e4`](https://github.com/morluto/rea/commit/1a201e49460d98534e96ab53087dd6cb550f1e55) ci(windows): run the caller path separator regression in the Windows lane - [`19c946f`](https://github.com/morluto/rea/commit/19c946fb54e0ceda441469c3ed6594218912c8ec) ci(windows): own the separator regression in the package change scope - [`225afa3`](https://github.com/morluto/rea/commit/225afa34b267123668b1e4e34d962abdec129b91) test(ci): keep the separator regression in the Windows-only lane guard ### 📊 Changes **3 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+1 -0) 📝 `scripts/ci/scopes.mjs` (+1 -0) 📝 `tests/process-global/curatedWindowsLane.test.ts` (+1 -0) </details> ### 📄 Description <!-- PR title: type(optional-scope): imperative outcome The title becomes the squash-merge commit subject and generated changelog entry. --> ## Summary <!-- What user, agent, or maintainer problem does this solve? Link the issue with "Fixes #123" when applicable. Keep the prior behavior, expected contract, and new behavior understandable without private context. --> Follow-up to #4733 (refs #4707). `tests/boundary/filesystem/windowsTargetSeparators.test.ts` runs only on Windows (`it.runIf(process.platform === "win32")`), and the `windows-curated` CI job runs an explicit file list that does not name it, so CI never executes it: Linux shards skip it and the Windows lane does not list it. This adds it to the lane, to the `package` change scope, and to the lane guard. ## Problem and expected behavior <!-- For fixes, give the smallest trigger and violated invariant. For features, describe the use case and observable outcome. --> The #4733 regression catches Windows caller paths reaching native snapshot admission with forward slashes or repeated separators. Today it runs only when someone runs it by hand on Windows. It should run in `windows-curated`, which already runs `binaryTarget.test.ts` and the other Windows-only path tests #5807 added. ## Change and scope <!-- Explain the chosen approach, why it fits REA's architecture, and what is intentionally not included. If adding complexity for a speculative or vanishingly unlikely race or security edge case, record the concrete failure mode, likelihood, complexity cost, and the user's buy-in obtained before implementation. Do not silently expand scope for theoretical robustness. --> - `.github/workflows/ci.yml`: add the file to "Run curated Windows capability tests", after the three files from #5807. - `scripts/ci/scopes.mjs`: add it to the `package` scope. `ciChangeScope.test.ts` requires every `windows-curated` path to belong to it, and `package` selects the Windows lane, so later edits to the test start that lane. - `tests/process-global/curatedWindowsLane.test.ts`: add the path to the existing `arrayContaining` guard for Windows-only cases (per review), instead of a separate test with the same reason. The test needs no native build, Ghidra or Java: it writes a small PE fixture and calls `parseBinaryTarget` with four separator spellings. Follow the [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope). Unresolved scope, authority, side effects, or required verification block integration. Link the required maintainer scope decision for new providers or capabilities involving target execution, injection, mutation, or protection recovery; ordinary fixes within existing boundaries may state "not applicable". Draft PRs may leave the scope decision pending and the readiness and merge checklists unchecked. Maintainers can help resolve open questions. ## Contract and boundary impact <!-- Short answers are welcome. Complete applicable lines; mark unresolved facts as "unknown". Use "none" or "not applicable" only when established. --> - Semantic owner and earliest changed stage: CI test selection only (`windows-curated` file list, `package` change scope, lane guard). <!-- Name the producer of parsed facts or resources and its affected consumers. Summarize superseded paths removed and any distinct policy, lifecycle, lazy-loading, or compatibility responsibility retained. --> - Contribution scope fit and linked maintainer decision: not applicable (CI coverage for an existing test). - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: none; adds one Windows filesystem test to the existing Windows lane. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `.agents/skills/reverse-engineer-anything/` and never commit build outputs): none. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage <!-- State whether evidence is executed, source-derived, or proposed. For fixes, show the original failure and explain how the regression would fail on the affected base revision when practical. Include the most useful proof inline; link long logs or artifacts, or put them in optional details. Documentation-only changes can use source, link, or rendered-document checks. --> - Tests added or updated: `tests/process-global/curatedWindowsLane.test.ts` now also requires `tests/boundary/filesystem/windowsTargetSeparators.test.ts` in the Windows-only guard. - Base reproduction or other evidence: executed on Windows 11 x64, Node 24.22.1, head 225afa34b. `curatedWindowsLane.test.ts` (11 tests) + `windowsTargetSeparators.test.ts` (1 test): 12 passed, and the Windows-only separator test ran rather than being skipped. With the new `ci.yml` line removed from the working tree, the guard fails: 1 failed, 10 passed. - User-visible CLI/MCP output (if applicable): not applicable. - Remaining proof gaps: the `windows-curated` job has not run on this PR. `Classify changes` puts edits to `ci.yml` and `scripts/ci/scopes.mjs` on the fast tier, which skips that lane (thanks @CassieFox23 for finding this). A maintainer can apply `ci:full` to run it once; until then the Windows 11 run above stands in. Not a boundary fix: no product code changes. For boundary fixes, identify the applicable [boundary regressions](https://github.com/morluto/rea/blob/main/docs/testing.md#boundary-regressions) and [lifecycle regressions](https://github.com/morluto/rea/blob/main/docs/testing.md#lifecycle-regressions) covered by the evidence above, and explain relevant gaps. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed <!-- List only commands that actually ran, with observed results. Include the relevant real-provider or platform workflow, or explain why it was unavailable. Keep these results current after changes; a command without its result is incomplete. --> - `npx vitest run tests/process-global/curatedWindowsLane.test.ts tests/boundary/filesystem/windowsTargetSeparators.test.ts` (Windows 11, Node 24.22.1): 12 passed. - Same with the `ci.yml` entry removed from the working tree: 1 failed, 10 passed (the guard). - Adding `tests/boundary/filesystem/ciChangeScope.test.ts` to that run: 321 passed, 2 skipped. - Pre-push `npm run check:fast` (typecheck, lint): passed. ## Compatibility, safety, and release <!-- Call out breaking changes, migrations, package effects, platform/provider limits, security/privacy/containment implications, and meaningful proof gaps. --> - Breaking changes or migration steps: none. <!-- For ! / BREAKING CHANGE: show a previously valid call/configuration, its new behavior and migration, and why compatibility/deprecation cannot preserve it. Every release increments minor, including breaking changes; keep breaking markers and migration notes so callers can assess compatibility. See docs/releasing.md. --> - Real Hopper/Ghidra, browser, or OS coverage: Windows 11 x64 locally; CI Windows lane pending (see proof gaps). - Package or release metadata impact: none. - Security, privacy, process, or containment review: none; the test writes a temporary fixture only. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @Iyanuoluwa007 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge <!-- Draft PRs may leave pending items unchecked. Resolve material scope and authority questions before integration. --> - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6712
No description provided.