morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #1799] [MERGED] fix(javascript): retain unbound CommonJS semantic imports #4824

New issue

Closed

opened 2026-10-31 00:55:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:55:25 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1799
Author: @N0zoM1z0
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/javascript-unbound-require-20261011

📝 Commits (1)

92e2ddf fix(javascript): retain unbound CommonJS semantic imports

📊 Changes

10 files changed (+388 additions, -33 deletions)

View changed files

📝 src/domain/javascript/javascriptSemanticAnalysis.empty_keys.test.ts (+13 -1)
📝 src/domain/javascript/javascriptSemanticAnalysis.member_depth.test.ts (+8 -1)
➕ src/domain/javascript/javascriptSemanticAnalysis.require_links.test.ts (+154 -0)
📝 src/domain/javascript/javascriptSemanticAnalysis.structure.test.ts (+0 -22)
📝 src/domain/javascript/javascriptSemanticAnalysis.ts (+3 -2)
📝 src/domain/javascript/javascriptSemanticProjection.ts (+32 -4)
📝 src/domain/javascript/javascriptSemanticRequireOrigin.ts (+10 -2)
📝 src/domain/javascript/javascriptSemanticState.ts (+2 -0)
📝 src/domain/javascript/javascriptSemanticValues.ts (+2 -1)
➕ tests/acceptance/applications/unboundRequires.test.ts (+164 -0)

📄 Description

Summary

Unbound literal CommonJS calls now contribute semantic module dependencies and the source module's import count. Existing static asset references remain available.

Fixes #1793.

Problem and expected behavior

With main.cjs containing require("./dependency.cjs");, main 3ad5782d returns one static require asset edge but zero semantic require module edges and import_relationships: 0. An equivalent side-effect ESM import has a semantic module edge. The fixed CLI and stdio MCP return one semantic require edge and import_relationships: 1, with the dependency path resolved and the original source digest/range retained.

Change and scope

Collect unbound calls at the existing semantic projection owner. Its existing parser still decides whether a call is an unshadowed literal require. Keep the exact call node private to analysis and mark calls already represented by a binding or CommonJS export in a WeakSet. This avoids extra links for bound calls while retaining distinct nested calls, empty destructures, assignments and other unbound expressions.

Binding names remain null where no binding is known. Dynamic specifiers and shadowed calls remain excluded; dynamic member paths keep unknown binding provenance. Existing alias, empty-key and re-export precision is preserved. Move the existing alias/assignment case into the focused require module and update two goldens to retain dependencies without inventing dynamic bindings.

Contract and boundary impact

Semantic owner and earliest changed stage: JavaScript semantic require origin and module-link collection.
CLI and MCP/tool-catalog contract: unchanged schemas; semantic edges and import counts now include these source facts.
Provider, bridge, target-format, or platform compatibility: shared JavaScript analysis; no provider adapter changes.
Evidence, artifact, provenance, or reconstruction contract: preserve both static asset references and semantic module relationships, source identity/ranges and uncertainty.
Process execution, authorization, cleanup, or containment impact: none.
Generated metadata, package, or installation impact: none.

Evidence and regression coverage

Executed reproduction: a 101-byte, three-file target through freshly compiled public CLI and real SDK stdio MCP, on both latest merged main and the fixed branch. Native Node resolves the dependency without executing the fixture. Complete Evidence envelopes authenticate; normalized CLI/MCP results match, MCP text/structured content matches, and a subsequent ping succeeds.
Regression coverage: 19 new semantic cases and two compiled public journeys; existing binding/provenance coverage retained, including deep members and empty keys. The initial source/public regression run fails 15 cases on the affected producer and passes six controls.
Remaining proof gaps: Linux verification only; no real Ghidra, IDA, Hopper or browser workflow is involved.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Node 24.18.0 / npm 11.16.0, two CPUs, supervised 2 GiB process-family RSS limit:

npm run compile -- --singleThreaded — passed on exact head 92e2ddfd2359209e36f1f528db48ee87dd96a160, based on merged main 3ad5782d.
Flameox-supervised Vitest source runs, --maxWorkers=1 — 50 semantic/composition files with 890 passing cases, and 19 application/cancellation files with 297 passing cases.
Exact integrated-head Vitest run — eight files, 79 passing cases, including both compiled CLI/MCP journeys. This overlaps the broader source runs.
Separate complete public CLI/MCP reproduction — passed on the exact integrated runtime.
npm run typecheck -- --singleThreaded with GOMEMLIMIT=768MiB, npm run lint (including module boundaries), changed-file oxfmt --check, npm run verify:architecture-guards, and git diff --check — all passed.

Flameox capture workload exits and payload digests were checked; the profiles cover the Vitest launcher, so they establish neither child-worker CPU nor allocation improvements. The threaded aggregate hooks were bypassed with HUSKY=0; the checks above ran explicitly within the resource budget. Full CI remains required before merge.

Compatibility, safety, and release

Breaking changes or migration steps: none; additional semantic dependencies correct an omission.
Real Hopper/Ghidra, browser, or OS coverage: Linux CLI/MCP only, as described above.
Package or release metadata impact: none.
Security, privacy, process, or containment review: AST call identity stays private to analysis and never enters the IR or Evidence; no new execution or cleanup authority.

Review checklist

This PR addresses a concrete problem or an agreed enhancement.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed; none require regeneration here.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1799 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/javascript-unbound-require-20261011` --- ### 📝 Commits (1) - [`92e2ddf`](https://github.com/morluto/rea/commit/92e2ddfd2359209e36f1f528db48ee87dd96a160) fix(javascript): retain unbound CommonJS semantic imports ### 📊 Changes **10 files changed** (+388 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptSemanticAnalysis.empty_keys.test.ts` (+13 -1) 📝 `src/domain/javascript/javascriptSemanticAnalysis.member_depth.test.ts` (+8 -1) ➕ `src/domain/javascript/javascriptSemanticAnalysis.require_links.test.ts` (+154 -0) 📝 `src/domain/javascript/javascriptSemanticAnalysis.structure.test.ts` (+0 -22) 📝 `src/domain/javascript/javascriptSemanticAnalysis.ts` (+3 -2) 📝 `src/domain/javascript/javascriptSemanticProjection.ts` (+32 -4) 📝 `src/domain/javascript/javascriptSemanticRequireOrigin.ts` (+10 -2) 📝 `src/domain/javascript/javascriptSemanticState.ts` (+2 -0) 📝 `src/domain/javascript/javascriptSemanticValues.ts` (+2 -1) ➕ `tests/acceptance/applications/unboundRequires.test.ts` (+164 -0) </details> ### 📄 Description ## Summary Unbound literal CommonJS calls now contribute semantic module dependencies and the source module's import count. Existing static asset references remain available. Fixes #1793. ## Problem and expected behavior With `main.cjs` containing `require("./dependency.cjs");`, main `3ad5782d` returns one static require asset edge but zero semantic require module edges and `import_relationships: 0`. An equivalent side-effect ESM import has a semantic module edge. The fixed CLI and stdio MCP return one semantic require edge and `import_relationships: 1`, with the dependency path resolved and the original source digest/range retained. ## Change and scope Collect unbound calls at the existing semantic projection owner. Its existing parser still decides whether a call is an unshadowed literal require. Keep the exact call node private to analysis and mark calls already represented by a binding or CommonJS export in a WeakSet. This avoids extra links for bound calls while retaining distinct nested calls, empty destructures, assignments and other unbound expressions. Binding names remain null where no binding is known. Dynamic specifiers and shadowed calls remain excluded; dynamic member paths keep unknown binding provenance. Existing alias, empty-key and re-export precision is preserved. Move the existing alias/assignment case into the focused require module and update two goldens to retain dependencies without inventing dynamic bindings. ## Contract and boundary impact - Semantic owner and earliest changed stage: JavaScript semantic require origin and module-link collection. - CLI and MCP/tool-catalog contract: unchanged schemas; semantic edges and import counts now include these source facts. - Provider, bridge, target-format, or platform compatibility: shared JavaScript analysis; no provider adapter changes. - Evidence, artifact, provenance, or reconstruction contract: preserve both static asset references and semantic module relationships, source identity/ranges and uncertainty. - Process execution, authorization, cleanup, or containment impact: none. - Generated metadata, package, or installation impact: none. ## Evidence and regression coverage - Executed reproduction: a 101-byte, three-file target through freshly compiled public CLI and real SDK stdio MCP, on both latest merged main and the fixed branch. Native Node resolves the dependency without executing the fixture. Complete Evidence envelopes authenticate; normalized CLI/MCP results match, MCP text/structured content matches, and a subsequent ping succeeds. - Regression coverage: 19 new semantic cases and two compiled public journeys; existing binding/provenance coverage retained, including deep members and empty keys. The initial source/public regression run fails 15 cases on the affected producer and passes six controls. - Remaining proof gaps: Linux verification only; no real Ghidra, IDA, Hopper or browser workflow is involved. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Node 24.18.0 / npm 11.16.0, two CPUs, supervised 2 GiB process-family RSS limit: - `npm run compile -- --singleThreaded` — passed on exact head `92e2ddfd2359209e36f1f528db48ee87dd96a160`, based on merged main `3ad5782d`. - Flameox-supervised Vitest source runs, `--maxWorkers=1` — 50 semantic/composition files with 890 passing cases, and 19 application/cancellation files with 297 passing cases. - Exact integrated-head Vitest run — eight files, 79 passing cases, including both compiled CLI/MCP journeys. This overlaps the broader source runs. - Separate complete public CLI/MCP reproduction — passed on the exact integrated runtime. - `npm run typecheck -- --singleThreaded` with `GOMEMLIMIT=768MiB`, `npm run lint` (including module boundaries), changed-file `oxfmt --check`, `npm run verify:architecture-guards`, and `git diff --check` — all passed. Flameox capture workload exits and payload digests were checked; the profiles cover the Vitest launcher, so they establish neither child-worker CPU nor allocation improvements. The threaded aggregate hooks were bypassed with `HUSKY=0`; the checks above ran explicitly within the resource budget. Full CI remains required before merge. ## Compatibility, safety, and release - Breaking changes or migration steps: none; additional semantic dependencies correct an omission. - Real Hopper/Ghidra, browser, or OS coverage: Linux CLI/MCP only, as described above. - Package or release metadata impact: none. - Security, privacy, process, or containment review: AST call identity stays private to analysis and never enters the IR or Evidence; no new execution or cleanup authority. ## Review checklist - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed; none require regeneration here. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:55:25 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:11:56 +00:00

[PR #4173] [CLOSED] fix(javascript): prune unreachable constant return branches #6109

bsakaguchi referenced this issue

2026-10-31 01:14:21 +00:00

[PR #4822] [CLOSED] docs(readme): fix French heading spacing #6424

bsakaguchi referenced this issue

2026-10-31 01:14:21 +00:00

[PR #4823] [MERGED] fix(cli): preserve spaced output flag values #6425

bsakaguchi referenced this issue

2026-10-31 01:14:23 +00:00

[PR #4824] [MERGED] fix(ci): handle cache eviction and composed cleanup assertions #6426

bsakaguchi referenced this issue

2026-10-31 01:14:25 +00:00

[PR #4829] fix(errors): separate recovery actions from failure messages #6433

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4824

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns