morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #1917] [MERGED] fix(test): audit static Wasm and Harmony tool wording #4906

New issue

Closed

opened 2026-10-31 00:56:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:56:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1917
Author: @N0zoM1z0
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/tool-effects-static-wording

📝 Commits (1)

d66102c fix(test): audit static Wasm and Harmony tool wording

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 src/contracts/toolEffects.test.ts (+3 -0)

📄 Description

Summary

The effects-wording audit rejects inspect_wasm_artifact (“No … WASM execution”) and project_harmony_application_graph (“execution-free … inventory”). Add their documented nonexecution reasons to the existing manual audit. This fixes the sole test failure in the #1912 CI run.

Problem and expected behavior

Execution vocabulary in a negative statement does not declare foreign-code execution. The audit should accept these reviewed static tool descriptions and continue rejecting unaudited execution wording or stale exceptions.

Change and scope

Three lines in the existing test-only exception map. Source review confirms WABT uses validation/disassembly/WAT tools and Harmony projects authenticated inventory Evidence. The canonical effects and audit assertions are retained. CI-audit maintenance is tracked by the linked failed run.

Contract and boundary impact

Semantic owner: tool-description wording audit in toolEffects.test.ts.
CLI/MCP, provider, Evidence, process authority and generated/package/install contracts: none.

Evidence and regression coverage

Latest main 9d8e42b: one failure, four passing tests, with exactly these two tool names rejected. After the fix, all five effects tests pass, including complete tool inventory, annotation derivation and stale-exception checks.

Claims distinguish source review from runtime verification.
Failure evidence and declared effects are preserved.
Runtime/provider proof scope is explicit.

Validation performed

npm run test:local -- src/contracts/toolEffects.test.ts — 1 failed/4 passed before; 5 passed after.
Normal pre-commit formatting/lint — pass.
Normal pre-push typecheck/lint — pass. Independent and automated review of d66102c — no remaining blocker. Exact-head CI: ten successful checks, 18 skipped; all four test shards and the required CI check pass.

Compatibility, safety, and release

Test-audit scope; no migration, package or release metadata change. No target or provider execution performed for this audit correction.

Review checklist

Concrete CI failure, focused conventional title and linked reproduction.
Existing assertions verify the regression and stale audit entries.
Owning test updated; public/generated contracts require no edit.
Diff checked for secrets, unrelated changes and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1917 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/tool-effects-static-wording` --- ### 📝 Commits (1) - [`d66102c`](https://github.com/morluto/rea/commit/d66102c837d3b9b5f39e89cf5cd84ca5293b1554) fix(test): audit static Wasm and Harmony tool wording ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/contracts/toolEffects.test.ts` (+3 -0) </details> ### 📄 Description ## Summary The effects-wording audit rejects `inspect_wasm_artifact` (“No … WASM execution”) and `project_harmony_application_graph` (“execution-free … inventory”). Add their documented nonexecution reasons to the existing manual audit. This fixes the sole test failure in [the #1912 CI run](https://github.com/morluto/rea/actions/runs/38159238818/job/114528776716). ## Problem and expected behavior Execution vocabulary in a negative statement does not declare foreign-code execution. The audit should accept these reviewed static tool descriptions and continue rejecting unaudited execution wording or stale exceptions. ## Change and scope Three lines in the existing test-only exception map. Source review confirms WABT uses validation/disassembly/WAT tools and Harmony projects authenticated inventory Evidence. The canonical effects and audit assertions are retained. CI-audit maintenance is tracked by the linked failed run. ## Contract and boundary impact - Semantic owner: tool-description wording audit in `toolEffects.test.ts`. - CLI/MCP, provider, Evidence, process authority and generated/package/install contracts: none. ## Evidence and regression coverage Latest main `9d8e42b`: one failure, four passing tests, with exactly these two tool names rejected. After the fix, all five effects tests pass, including complete tool inventory, annotation derivation and stale-exception checks. - [x] Claims distinguish source review from runtime verification. - [x] Failure evidence and declared effects are preserved. - [x] Runtime/provider proof scope is explicit. ## Validation performed - `npm run test:local -- src/contracts/toolEffects.test.ts` — 1 failed/4 passed before; 5 passed after. - Normal pre-commit formatting/lint — pass. - Normal pre-push typecheck/lint — pass. Independent and automated review of `d66102c` — no remaining blocker. Exact-head CI: ten successful checks, 18 skipped; all four test shards and the required CI check pass. ## Compatibility, safety, and release Test-audit scope; no migration, package or release metadata change. No target or provider execution performed for this audit correction. ## Review checklist - [x] Concrete CI failure, focused conventional title and linked reproduction. - [x] Existing assertions verify the regression and stale audit entries. - [x] Owning test updated; public/generated contracts require no edit. - [x] Diff checked for secrets, unrelated changes and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:56:39 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:42:12 +00:00

[PR #4908] [CLOSED] fix(plist): keep CFPropertyList non-finite real spellings as observed values #6672

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4906

No description provided.

Rows
Columns