mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4908] [CLOSED] fix(plist): keep CFPropertyList non-finite real spellings as observed values #6672
Closed
opened 2026-11-01 21:42:12 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6672
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4908
Author: @mertkayacs
Created: 10/17/2026
Status: ❌ Closed
Base:
main← Head:fix/plist-non-finite-real-spellings📝 Commits (4)
4223e90test(plist): cover CFPropertyList non-finite real spellings1946b69fix(plist): keep CFPropertyList non-finite real spellings as observed values09f070atest(plist): cover conversion-spelled reals and the spelled keyed-archive casef780cdefix(plist): keep conversion-spelled non-finite reals unknown for binary sources📊 Changes
14 files changed (+327 additions, -35 deletions)
View changed files
📝
docs/native-investigation.md(+12 -1)📝
src/artifacts/apple/KeyedArchiveReader.ts(+7 -3)📝
src/domain/apple/keyedArchive.ts(+1 -0)📝
src/domain/apple/plistNumbers.ts(+29 -0)📝
src/domain/apple/plistValue.test.ts(+28 -1)📝
src/domain/apple/plistValue.ts(+40 -5)📝
src/domain/propertyListKeys.ts(+3 -2)📝
src/domain/propertyListXml.test.ts(+48 -0)📝
src/domain/propertyListXml.ts(+7 -1)📝
src/native/NativeMacOSProvider.ts(+17 -14)📝
src/native/parsers/plist.test.ts(+34 -0)📝
src/native/parsers/plist.ts(+20 -4)📝
tests/acceptance/applications/keyedArchiveScalarKinds.test.ts(+77 -1)📝
tests/boundary/filesystem/keyedArchiveSelection.test.ts(+4 -3)📄 Description
Summary
inspect-keyed-archive,inspect_keyed_archiveand the XML fallback ofinspect_plistreport every<real>that CFPropertyList writes as+infinity,-infinityornanas an unknown real,{ "$plist_type": "real", "value": null }, with a limitation saying the decoder cannot distinguish NaN from infinity. The sign and the identity of the value are lost although the source text states both. This change reads CFPropertyList's spellings at the XML decoder and reports them as{ "$plist_type": "real", "value": "+infinity" | "-infinity" | "nan" }with statusobserved. Non-finite numbers that carry no spelling, such as a binary plist double or XML text the decoder could not read as a number, keep today'svalue: nullrepresentation with a reworded limitation. Fixes #4906.Problem and expected behavior
Trigger: an XML keyed archive whose
$objectsholds<real>+infinity</real>,<real>-infinity</real>and<real>nan</real>. On2fb5e204aall three objects are reported as{ "kind": "scalar", "status": "observed", "value": { "$plist_type": "real", "value": null } }and the limitation reads3 non-finite real value(s) are reported as { "$plist_type": "real", "value": null } because JSON evidence cannot preserve NaN vs infinity.Violated invariant: the decoder replaces an exact source value with an unknown while the source text is unambiguous.
Number.parseFloatonly recognises the JavaScript spellingInfinity, case-sensitively, so each of Apple's spellings parses to NaN before the projection sees it. CFPropertyList's XML writer emits exactlynan,+infinityand-infinityfor non-finite doubles (__CFNumberCreateFormattingDescriptionAsFloat64in CFNumber.c, used by_CFAppendXML0in CFPropertyList.c), and its XML parser compares the whole<real>text case-insensitively againstnan,+infinity,-infinity,infinity,-inf,infand+inf(parseRealTagin CFPropertyList.c, swift-corelibs-foundation main). AGENTS.md asks for exact source values and explicit unknowns to be preserved across boundaries; here a known value was reported as unknown.Change and scope
parsePlistNonFiniteRealLiteral(src/domain/apple/plistNumbers.ts) reads a whole<real>text as one of CFPropertyList's spellings, case-insensitively and without trimming, matchingparseRealTag. Any other text keeps the existingparseFloatpath untouched.PlistNonFiniteRealscalar for a spelled value, the same way it returnsDate,Uint8Arrayandbigintfor values JSON cannot carry. Incomplete markup inside the element still marks the number metadata incomplete.projectPlistValueprojects that scalar as{ "$plist_type": "real", "value": "<spelling>" }through the existing wrapper hook, so keyed-archive classification keeps treating it as a scalar, and counts it separately (nonFiniteRealCount). A raw non-finite number still becomesvalue: nulland is counted as before (unknownRealCount).omitPrototypeKeyspasses the new scalar through likeDateandUint8Array.plistValue.tsnext to the negative-zero one and are used by bothKeyedArchiveReaderand the nativeparsePlistXmlpath; the old wording claimed the decoder cannot distinguish NaN from infinity, which is no longer true.Not included: binary plist doubles. A binary
+infor-infstill reportsvalue: null; the sign is knowable there and a follow-up could spell it, but that is a different producer (plist'sparseBinary) and I kept this PR to the XML text boundary. That holds for the macOSinspect_plistpath too: when plutil converts a binary plist to XML, the spelling in that XML is the converter's, soparsePlistXmltakes the source format (plistSourceFormat, classified before decoding) and keeps a conversion-spelled real an explicit unknown; only XML source text reports the spelling as observed. Also not included: the strict literal grammar for malformed<real>text discussed in #4852; this change only recognises text CFPropertyList accepts, and leaves everything else exactly as it was.Contribution scope: ordinary fix within existing boundaries, not applicable.
Contract and boundary impact
decodeXmlPropertyList(src/domain/propertyListXml.ts), result projection.$plist_type: "real"wrapper already allowed"-0";"+infinity","-infinity"and"nan"are new string values of the same shape.value: nullkeeps its meaning for unspelled non-finite numbers. Two limitation texts change wording. No schema change.Infinity, which CFPropertyList reads as+infinity, so one existing acceptance expectation changed for the XML format.Expected effects:
Evidence and regression coverage
1e999,-1e999,nan,-nanandinfinitestay plain numbers; unsupported markup inside a spelled real marks the metadata incomplete.value: null, a lookalike dictionary is left alone, and the two counts are separate.parsePlistXmloutput and both limitation texts, and the same XML read withsourceFormat: "binary", which keepsvalue: nullwith the unknown-real limitation.NaNas<real>nan</real>) now expects the spelled value and the new limitation.+infinity,-INFINITYandnanobjects, and the existing scalar-kinds case now expects"+infinity"for the XML format.7b332bcc0) checked out,npm run test:localon the three unit files reports 15 failed / 32 passed, andnpm run test:focused -- tests/acceptance/applications/keyedArchiveScalarKinds.test.tsreports 2 failed / 4 passed (the new case and the XML scalar-kinds case). With the fix (e875e11e6) the same commands report 47 passed and 6 passed.inspect-keyed-archive non_finite.plist --jsonon the fix, objects 1 to 3 of the fixture above: Limitation:3 non-finite real value(s) are reported as { "$plist_type": "real", "value": "<spelling>" } with the CFPropertyList spelling nan, +infinity or -infinity because a JSON number cannot carry them.For evidence-bearing changes:
Validation performed
npm run test:local -- src/domain/propertyListXml.test.ts src/domain/apple/plistValue.test.ts src/native/parsers/plist.test.tsat7b332bcc0(tests only) — 15 failed, 32 passed.npm run test:focused -- tests/acceptance/applications/keyedArchiveScalarKinds.test.tsat7b332bcc0— 2 failed, 4 passed.npm run test:localon the 20 test files under src/domain/apple, src/artifacts/apple, src/native/parsers plus src/domain/propertyListXml.test.ts, src/domain/propertyListKeys.test.ts and src/application/AppBundleExecutable.test.ts ate875e11e6— 372 passed.npm run test:focused -- tests/acceptance/applications/keyedArchiveScalarKinds.test.tsate875e11e6— 6 passed.npm run check:fastate875e11e6— typecheck and lint passed.npm run docs:check— 5 passed.npm run test:localonsrc/native/parsers/plist.test.ts,src/domain/apple/plistValue.test.ts,src/domain/propertyListXml.test.ts— 48 passed;npm run test:focusedontests/boundary/filesystem/keyedArchiveSelection.test.tsandtests/boundary/providers/native/plistSourceFormat.test.ts— 35 passed;npm run check:fast— passed;npm run docs:check— passed.tests/boundary/cli/nativePlistCli.test.tsis macOS-only and skipped here (17 skipped); its binary arm keepsvalue: nullby construction of the source-format branch.d0253c99d; the three unit files pass there (47 passed).Compatibility, safety, and release
"value": nullfor every non-finite real will now see"+infinity","-infinity"or"nan"for spelled XML values; the wrapper shape is unchanged.Author readiness
Human owner: @mertkayacs
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.