mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Open
opened 2026-10-31 00:57:32 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#4970
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/2025
Author: @jimpablo
Created: 10/12/2026
Status: 🔄 Open
Base:
main← Head:feat/dsym-companion-admission📝 Commits (10+)
4d3b7a1feat(ghidra): admit caller-selected matching dSYM companionsf0eb9c4fix(targets): partition dSYM identity and match the selected slice104601efix(targets): keep legacy query ids and bound companion admissionc219cb9fix(targets): bound uuid walking and carry companion provenanceab3bf42fix(contracts): budget command spans and partition companions by path11e1002fix(ghidra): commit companion identity in the analysis profile731f243fix(targets): carry companion identity through split mach-o variants03f9058fix(targets): charge traversal reads and bound staged member copiesd3fe4a0fix(ghidra): document and enforce dSYM admission resource budgetsdbf8d2cfix(ghidra): preserve dSYM resource refusals and staging coverage📊 Changes
28 files changed (+2621 additions, -22 deletions)
View changed files
📝
docs/.vitepress/config.ts(+1 -0)➕
docs/dsym.md(+73 -0)📝
src/application/BinaryTargetResolver.ts(+80 -10)➕
src/application/DebugCompanionAdmission.ts(+577 -0)📝
src/application/DirectAnalysis.ts(+15 -0)📝
src/application/binary/BinarySessionOpen.ts(+2 -0)📝
src/application/binary/BinaryTargetSummary.ts(+17 -3)📝
src/cli/coreBinaryCommands.ts(+2 -0)📝
src/cli/options.ts(+13 -0)📝
src/contracts/sessionLifecycleInputs.ts(+19 -0)📝
src/domain/analysisErrorPresentation.ts(+9 -2)📝
src/domain/analysisErrorProjection.ts(+2 -1)📝
src/domain/analysisSnapshot.test.ts(+89 -0)📝
src/domain/analysisSnapshot.ts(+65 -1)➕
src/domain/apple/machoLoadCommand.ts(+6 -0)📝
src/domain/binaryTargetTypes.ts(+19 -0)📝
src/domain/configurationErrors.ts(+2 -1)📝
src/domain/liveBinaryTargetSummary.ts(+19 -1)➕
src/domain/machoDebugCompanion.test.ts(+342 -0)➕
src/domain/machoDebugCompanion.ts(+228 -0)...and 8 more files
📄 Description
Summary
Fixes #1193. REA now admits a caller-selected
.dSYMbundle for Mach-O executable targets (dsym_paththrough MCP,--dsym-pathon the CLI) and stages it beside the private Ghidra import, so DWARF recovers parameter names, data types, and source-anchored type identity that the stripped executable cannot provide. Admission requires a proven LC_UUID match; a non-matching companion is rejected as caller input instead of silently loading wrong types.Problem and expected behavior
.dSYM(built withclang -g+dsymutil). REA's ephemeral import copies the executable into a private runtime root, so the bundle beside the original file is never visible to the session, and every function reportssignature_source: "default"with low type confidence.dsym_path, admission (1) validates the bundle shape, (2) requires a DWARF member whoseLC_UUIDmatches the target image's, and (3) stages only the matched member inside REA's runtime root under the snapshot's name — the naming Ghidra'sDSymSectionProviderrequires — leaving the caller's bundle untouched. The staged member digest, source path, and matched UUID are retained as target-admission evidence. Omittingdsym_pathis byte-identical to today.Change and scope
src/domain/machoDebugCompanion.ts(new): pure Mach-OLC_UUIDreading for thin and universal containers with bounds checks, and the matching rule (an all-zero UUID is a placeholder that never matches; a target with no usable UUID is rejected explicitly).src/application/DebugCompanionAdmission.ts(new): bundle-shape validation, bounded header reads through the resolver's open target handle, member digesting, and UUID matching.BinaryTargetResolver: optionaldsymPath; pairing rejections (dsymwith headerless formats, non-Mach-O targets) and admission failures carry a newdebug_companion_rejectedconstraint; the admitted identity ridesBinaryTarget.debugCompanion(Mach-O variants only).open_binarygains optional absolutedsym_pathwith contract-level pairing validation; CLI--dsym-pathjoinsnativeOpenOptionFields, so every one-shot native command accepts it;DirectAnalysis,BinarySessionOpen, and the MCP open handler thread it through.GhidraClientOptions.debugCompanion→GhidraClientstages the member beside the snapshot (GhidraDebugCompanion.ts, digest-verified copy, cleanup on failure) and mergesdsymfacts into the existing target-admission evidence.debug_companion_rejectedmaps toinvalid_request/invalid_inputwith remediation naming the real option spellings, following theload_selection_rejectedpattern from #2004.docs/dsym.md(+ sidebar entry).Contract and boundary impact
src/domain/machoDebugCompanion.ts+src/application/DebugCompanionAdmission.ts), before any provider starts.open_binaryinput schema gains one optional field; the catalog was regenerated. No output schema changes.dsym { source_path, member_sha256, uuid, staged_member }.docs:checkgreen.Evidence and regression coverage
Tests added:
src/domain/machoDebugCompanion.test.ts(10 tests: thin/universal UUID reading, truncation and bounds rejections, zero-UUID and multi-member matching);tests/boundary/filesystem/targetDiagnostics.test.tsgains three — the headerless pairing rejection, and two darwin-gated real-fixture tests that compile two binaries withxcrun clang -g+dsymutiland assert (a) a matching bundle admits with UUID + member digest and (b) the other binary's bundle rejects as caller input with the UUID reason.Base reproduction: with the source changes stashed, all three new boundary tests fail on
edf46248f.Real provider verification on this host (macOS 27 arm64, Ghidra 12.1.4 via the Homebrew formula with native
mac_arm_64decompiler, JDK accepted byrea doctor), compiled fixturepair.c→clang -O0 -g -c→ link →dsymutil:signature_source: "default", return-type confidencelow.rea function <pair> _pair_sum --provider ghidra --dsym-path <pair.dSYM> --json: signatureint __cdecl pair_sum(Pair p),signature_source: "imported", parameterpof data typePair(8 bytes,x0:8, confidencehigh, type-lock evidence), pseudocodelocal_8 = p.a; uStack_4 = p.b; return local_8 + uStack_4;, value-flow parameter type/DWARF/pair.c/Pair.invalid_request/invalid_input,debug_companion_rejected, "contains no DWARF member whose LC_UUID matches";dsym+--target-format raw-binary→ pairing rejection; an unclassifiable blob withdsymkeeps its format refusal (ordering preserved).Remaining proof gaps: Linux hosts were not exercised (Mach-O analysis there follows the same path); universal-target companions were not exercised end to end (domain tests cover FAT UUID reading); stdio MCP was exercised through the shared registration, not a separate session run.
Pre-existing local failures, reproduced on unmodified
edf46248fand unrelated to this change:compactInputSchemaMcp"structurally oversized" pin (upstream5dfb9d050/#2013area),enhancedTools.01call-graph limitations pin, andnibNativeHierarchyon this macOS 27 host.Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
npm run test:focusedovermachoDebugCompanion.test.ts,targetDiagnostics.test.ts,sessionLifecycleInputs.test.ts,rawBinary.test.ts— all greennpx vitest run tests/boundary/cli— 260 passednpx vitest run src/contracts tests/boundary/mcp(afternpm run mcp-catalog:generate) — only the two pre-existing upstream failures abovenpx vitest run src/domain tests/boundary/filesystem tests/composition— only pre-existing failures abovenpm run check:fast,npm run check(typecheck, lint, format, knip, metadata, architecture guards),npm run docs:check,npm run verify:test-discovery(895 files) — greenrea function/rea analyzeruns with and without the companion as tabled aboveCompatibility, safety, and release
Review checklist
type(scope): outcome.Author readiness
Human owner: @jimpablo
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.