mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #2318] [MERGED] feat(captures): inspect recorded packets with bounded TShark delivery #5163
Closed
opened 2026-10-31 01:04:27 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5163
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/2318
Author: @N0zoM1z0
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @N0zoM1z0
Base:
main← Head:feat/tshark-analysis-2130-20261012📝 Commits (3)
7138358feat(captures): inspect recorded packet fields with TSharkf9208a9test(captures): verify retained descriptor cleanup8a049dfchore: sync current main for packet capture integration📊 Changes
50 files changed (+2850 additions, -0 deletions)
View changed files
📝
.agents/skills/reverse-engineer-anything/SKILL.md(+7 -0)➕
.github/workflows/real-packet-capture.yml(+50 -0)📝
README.md(+1 -0)📝
README_ar.md(+1 -0)📝
README_de.md(+1 -0)📝
README_es.md(+1 -0)📝
README_fa.md(+1 -0)📝
README_fr.md(+1 -0)📝
README_id.md(+1 -0)📝
README_it.md(+1 -0)📝
README_ja.md(+1 -0)📝
README_ko.md(+1 -0)📝
README_pl.md(+1 -0)📝
README_pt-BR.md(+1 -0)📝
README_ru.md(+1 -0)📝
README_th.md(+1 -0)📝
README_tr.md(+1 -0)📝
README_uk.md(+1 -0)📝
README_vi.md(+1 -0)📝
README_zh-TW.md(+1 -0)...and 30 more files
📄 Description
Summary
Inspect caller-selected fields in an existing packet capture through shared CLI/MCP workflows. This replaces #2130, credited to Olorinm, with current-main integration, bounded delivery and cleanup regressions. There is no linked issue.
Problem and expected behavior
Analysts need offline network/USB/Bluetooth field inspection without opening an active binary or acquiring traffic. Selecting two fields from a real 12,023-frame capture previously returned about 1.10 MB of text. The default now returns 50 matching frames with original frame numbers and explicit coverage; callers can page or request all remaining matches.
Change and scope
Linux-only TShark 4.x provider; caller supplies absolute
REA_TSHARK_COMMANDand trusted util-linuxprlimit. Fields, display filter, decode-as, input-packet limit and pass mode remain caller-selected. Paging happens after dissection and filtering, preserving two-pass/reassembly semantics. MCPmatch_limit: nulland CLI--all_matchesexplicitly request full output; conflicting CLI options are rejected before effects.Use existing process supervision, artifact descriptor ownership, session admission and Evidence delivery. Admit one inspection at a time and return retryable capacity errors instead of accumulating work. Failed descriptor/process/private-file cleanup remains owned for retry, including shutdown. Source bytes are copied privately and never passed directly to TShark.
Contract and boundary impact
PacketCaptureService; TShark owns producer parsing, resource supervision and artifact identity.inspect-packet-capture/inspect_packet_capture, selected fields required. Defaultmatch_limit: 50,match_offset: 0;output_windowreports matching/returned counts andhas_morewithin the input read scope.Expected effects:
Evidence and regression coverage
Reproduced admission-after-close, excess admission and retained descriptor-close failures against the imported implementation before fixing them. Descriptor tests cover capture, executable, limiter and kernel report; successful retry returns descriptor counts to baseline.
Real compiled CLI/MCP verifier: 15 cases on Debian 12 / TShark 4.0.17, including generated Ethernet/DNS/Bluetooth HCI recordings, field repetition/omission, filters, decode-as, both pass modes, input prefix before filter, output paging/full selection, schemas, errors, persistence, identity and cleanup.
Additional real data: pinned Wireshark 4.0.17 HTTP PCAP and DNS/ICMP PCAPNG; owned HTTP server/curl recording; a real recording of 1,000 owned HTTP requests (1,526,684 bytes / 12,023 frames). Known request URIs and source SHA-256 checked independently. Full packet arrays exactly match the imported implementation; bounded results exactly match their prefixes.
Representative result:
output_window: { matching_packets: 12023, returned_packets: 50, has_more: true }, with originalframe.numbervalues and selected fields.Proof gaps: TShark versions beyond verified 4.0.17/4.2.2, other platforms, USB, BLE ATT and physical hardware are not established by these tests. Fixture Bluetooth HCI is not a hardware claim. Installed global plugins/libraries/configuration are trusted and not fully fingerprinted.
Observed, derived and inferred claims remain distinguishable.
Artifact identity, provenance and failed attempts remain preserved.
Unsupported/incomplete outcomes remain visible.
Validation performed
npm run test:focused --ten capture/CLI/MCP/kernel/capability/effect/schema files — 79 passed on synchronized main.REA_TSHARK_COMMAND=/usr/bin/tshark node scripts/verify-packet-capture.mjs— 15 real CLI/MCP cases passed locally after synchronization; Ubuntu 24.04 CI / TShark 4.2.2 also passed all 15 cases and all 47 provider-boundary tests.npm run check,npm run docs:check,npm run verify:test-discovery— all passed again on synchronized main.Performance: three repetitions per case, warm MCP process, new TShark process each call, two CPU cores, 8 GiB family RSS guard. No filesystem-cache flushing. On the 12,023-frame recording, selected two-field response text went from 1,099,961 to 9,541 bytes; latency from 1.66–2.00 s to 1.22–1.41 s. Explicit full output remains available (1,100,118 bytes; 1.63–1.99 s). Filtered 1,000 HTTP requests return 50 by default (144,124 to 12,137 text bytes; 1.05–1.21 s). The nine-call optimized run peaked at 868.68 MiB family RSS; all guarded work stayed below 8 GiB.
For the task of inspecting the first 50 frames,
o200k_baseestimates including one common current capture-tool definition, one request and measured response text are 449,644 before paging versus 7,633 after. The common definition contributes 4,266 tokens to both comparisons. These are tokenizer estimates, not billed usage; other tool catalogs, prompt conversion, agent reasoning and subsequent calls are unmeasured. No cache claim is made; later pages repeat dissection and remain subject to producer limits.Compatibility, safety, and release
New feature; no previously released capture-tool call changes. Input <=32 MiB, combined producer stdout/stderr <=4 MiB, 30-second deadlines, enforced 1 GiB address space / 64 MiB file / 30 CPU-second ceilings per producer; stricter inherited limits are preserved. Paging bounds delivery but does not bypass producer-output limits. This is not an OS sandbox or an aggregate filesystem/memory quota. Unsupported authority remains refused.
Before merge
Final CI: all 38 checks passed for
8a049dfc82171c798601eb9b88606eed003a380c, including required CI, real TShark, six full test shards, coverage, static/docs/workflow checks and all native package lanes. Automatic Codex review did not execute because repository review credits were exhausted; it supplied no code findings. Own source inspection, regression reproduction and real-provider verification were completed.Merged as
f611d8ce722cd36345e9ff83b9669ef2e7fe57a9.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.