mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-31 01:04:32 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5172
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/2339
Author: @N0zoM1z0
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @N0zoM1z0
Base:
main← Head:feat/sigrok-analysis-2126-20261012📝 Commits (2)
3064691feat(signals): decode recordings with bounded sigrok output507ecd2refactor(process): share recorded-analysis resource ownership📊 Changes
50 files changed (+2715 additions, -252 deletions)
View changed files
📝
.agents/skills/reverse-engineer-anything/SKILL.md(+7 -0)➕
.github/workflows/real-signal-recording.yml(+50 -0)📝
README.md(+1 -0)📝
README_ar.md(+1 -0)📝
README_de.md(+1 -0)📝
README_es.md(+1 -0)📝
README_fa.md(+20 -19)📝
README_fr.md(+1 -0)📝
README_id.md(+1 -0)📝
README_it.md(+1 -0)📝
README_ja.md(+1 -0)📝
README_ko.md(+1 -0)📝
README_pl.md(+1 -0)📝
README_pt-BR.md(+1 -0)📝
README_ru.md(+20 -19)📝
README_th.md(+1 -0)📝
README_tr.md(+1 -0)📝
README_uk.md(+1 -0)📝
README_vi.md(+1 -0)📝
README_zh-TW.md(+1 -0)...and 30 more files
📄 Description
Summary
Decode selected protocols from an existing logic recording through shared CLI/MCP Evidence. This replaces #2126, credited to Olorinm, with current-main integration, bounded output, selector budgets and cleanup regressions. There is no linked issue.
Problem and expected behavior
An analyst with a recorded UART/I2C/SPI signal needs explicit decoder/channel/options and useful output without hardware acquisition. A real nine-bit UART recording produced 6,540 display lines and 171,827 bytes of response text. The default now returns 50 literal lines with explicit coverage, while later pages and full output remain available.
Change and scope
Linux-only sigrok-cli 0.7.2 with libsigrokdecode and trusted util-linux
prlimit; caller supplies absoluteREA_SIGROK_COMMAND. Preserve decoder stack/channel/options, input-format autodetection or explicit format, annotation-class selection, producer warnings and source/tool identity.Page output after complete decoding.
line_offsetdefaults to 0,line_limitto 50; MCPline_limit: null/ CLI--all_linesreturns all remaining output. Preserve exact selected text, sample ranges, CRLF/LF, blank lines and UTF-16 code units. Window counts refer to literal LF-separated display lines, not annotations or samples. Do not parse frontend display text into a lossless protocol payload. Partial windows own a copied string so retained Evidence does not retain the entire producer string.Reuse existing process supervision, artifact descriptor ownership and shared MCP admission/Evidence delivery. TShark and sigrok now share one
ArtifactAnalysisResourcesowner for admission, descriptors, producer/workspace cleanup, retained partial observations and interpretation of owned-command failure facts. Superseded provider-local maps, queues and error-mapping copies are removed. One decode at a time; excess requests fail with retryable capacity errors before acquisition. Shutdown closes admission and drains accepted work. Failed descriptor/process/workspace cleanup remains owned for retry and completed observations remain available after cancellation/cleanup errors.Contract and boundary impact
SignalRecordingService; adapter owns sigrok arguments, execution, artifact identity and diagnostics.decode-signal-recording/decode_signal_recording, no binary target required. Required recording path and decoder selection; output includes{ total_lines, returned_lines, has_more }and exact selections.Expected effects:
Evidence and regression coverage
Six regressions failed against the imported provider before fixes: admission after shutdown, excess queued admission, and lost ownership of recording/executable/limiter/kernel-report descriptors after close failure. New tests prove refusal of further acquisition and successful retained cleanup retry.
Seven focused provider/CLI/MCP/kernel/text-window files: 42 passed. Three integrated capability/effect/SDK-schema files: 32 passed. Literal text tests cover blank lines, CRLF, missing final newline, huge offsets and source code-unit preservation.
Real compiled CLI/MCP verifier: 9 cases, including known UART bytes, autodetection/filtering, default/later/full windows, advertised schemas, Evidence IDs/persistence, errors, source identity and cleanup. CLI rejects conflicting full/page options and oversized encoded selectors before invoking the service.
Public sigrok-dumps recordings pinned to
0ad13477: STM32 UART hello-world, ATmega328P nine-bit counter, MAX7219 SPI LED traffic and Samsung monitor I2C/EDID. Git blob identities and SHA-256 verified. Independent UART checks recoverHello World!\r\nthree times and the complete 0–511 counter cycle. Direct sigrok output and REA output match exactly; full output and source identity remain identical after optimization.Fifteen baseline and thirty optimized/full real-data MCP calls, three repetitions per case, all passed. Physical acquisition and additional decoder/format/platform combinations remain unverified; these tests analyze published recordings and synthesized UART VCDs.
Observed, derived and inferred claims remain distinguishable.
Artifact identity, provenance and failed attempts remain preserved.
Unsupported/incomplete outcomes remain visible.
Validation performed
npm run check,npm run docs:check,npm run verify:test-discovery— passed on refreshed main.npm run test:focused --the files above — 42 provider cases and 32 integrated schema/capability/effect cases passed.REA_SIGROK_COMMAND=/usr/bin/sigrok-cli node scripts/verify-signal-recording.mjs— 9 real CLI/MCP cases passed again with final runtime (Debian 12, sigrok-cli 0.7.2, libsigrok 0.5.2, libsigrokdecode 0.5.3).npm run jscpd— passed at 2.99%, without changing the 3% gate. The initial own-PR failure at 3.03% was fixed by removing duplicated ownership/failure interpretation.git diff --check— passed; no recordings, binaries, dependency/build outputs or private lab artifacts committed.Performance on the nine-bit UART: default text 171,827 → 5,171 bytes; annotation text 161,331 → 1,028 bytes / 50 lines. Explicit full output exactly retains 6,540 lines (171,971 response bytes including new metadata). Default-call latency 0.42–0.63 s in the latest run; baseline 0.29–0.38 s. Earlier local paged runs measured 0.25–0.42 s; no decoding-speed improvement is claimed. An alternating same-host A/B ran eight calls per version with identical reports; excluding the first warm-up pair, medians were 288.49 ms before and 289.18 ms after sharing the owner. Those measurements do not establish a meaningful speedup or an equivalent slowdown to the earlier between-run difference. EDID text 37,855 → 5,175 bytes. Warm MCP processes, fresh native decoder processes, no filesystem-cache flushing, two CPU cores and an 8 GiB family-RSS guard. The latest 30-call optimized/full run peaked at 543.41 MiB family RSS; all guarded local work remained below 8 GiB.
For inspecting the first 50 UART output lines,
o200k_baseestimates include one actually advertised tool definition, one request and response text: 83,315 → 5,738 tokens (definition overhead 3,054 → 3,769). Estimates are not billed usage; other catalog tools, prompt conversion, reasoning and subsequent calls are unmeasured. Paging does not avoid native decoding; later calls recheck the source and rerun the producer. No cache claim is made.Compatibility, safety, and release
New feature; no previously released signal-tool call changes. Input <=32 MiB, combined command stdout/stderr <=4 MiB, 30-second deadlines. Enforce both soft/hard ceilings of at most 1 GiB address space, 64 MiB per file, 30 CPU seconds and no core dumps, preserving stricter inherited limits. Selectors are limited to 8,192 UTF-16 units each and 32 KiB total encoded arguments before expansion/launch.
Caller-supplied tools, limiter, libraries and decoder modules remain trusted and are not fully fingerprinted. This is not an OS sandbox or an aggregate memory/filesystem quota. Output paging does not bypass producer-output limits; annotation-class selection can reduce native output. Display annotations remain decoder interpretations, not independently verified protocol facts.
Before merge
Final CI: all 39 checks passed for
507ecd28818426675fff7e69d01b15198419ea0a, including required CI, real sigrok/TShark, static/duplication/docs checks, all test shards, coverage and native packages. The own duplication failure was corrected by shared resource/failure ownership. Automatic Codex review could not execute because repository review credits were exhausted; no code findings were supplied. Own source inspection, reproduced regressions, real-provider verification and performance A/B were completed.Merged as
91b8f587cd495c509946e69076525eb19dc1ca65.Post-merge verification on
91b8f587cd495c509946e69076525eb19dc1ca65: runtime build passed; SQLite public/runtime suite 105 passed / 2 expected skips; real TShark verifier 15 cases passed; real sigrok verifier 9 cases passed. All 50 feature files exactly match the tested PR head; concurrently merged main changes are included in this verification. No guard stop; final verification peaked at 1,753.20 MiB family RSS.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.