[PR #2800] feat(native): retain LLDB source coordinates and verify Pascal calls #5404

New issue

Open

opened 2026-10-31 01:06:23 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2800
Author: @morluto
Created: 10/13/2026
Status: 🔄 Open

Base: main ← Head: codex/review-fixes-pr-2400

📝 Commits (10+)

8b0e330 feat(native): retain LLDB source coordinates and verify Pascal call entries
948a4bf docs: namespace native specifications by domain and feature
681b82c fix(native): bound Pascal verification and compare caller coordinates
e3a1e56 fix(native): bound compiler shutdown and source-coordinate fixtures
60c34b6 docs: clarify historical native source verification
b576b34 fix(native): preserve source attribution and compiler ownership
4a9883b docs(native): qualify retained source attribution
ca7e980 fix(ci): clean up native Pascal verifier processes
b26e4c0 Merge remote-tracking branch 'origin/main' into sweep/2800
13d62bb test(native): type the Pascal verifier helper import after merging main

📊 Changes

20 files changed (+637 additions, -15 deletions)

View changed files

📝 bridge/native/rea_lldb_tracer.py (+15 -0)
📝 bridge/native/test_rea_lldb_tracer.py (+88 -13)
📝 docs/native-investigation.md (+19 -0)
➕ docs/specs/native/call-source-locations/plan.md (+39 -0)
➕ docs/specs/native/call-source-locations/spec.md (+36 -0)
➕ docs/specs/native/call-source-locations/tasks.md (+14 -0)
➕ docs/specs/native/call-source-locations/verification.md (+42 -0)
📝 package.json (+1 -0)
➕ scripts/lib/canonical-temporary-directory.d.mts (+5 -0)
➕ scripts/lib/canonical-temporary-directory.mjs (+17 -0)
📝 scripts/verify-native-calls.mjs (+18 -0)
➕ scripts/verify-native-pascal-calls.mjs (+170 -0)
📝 src/domain/native/nativeCallObservation.ts (+12 -0)
📝 src/native/LldbRetainedObservations.ts (+1 -0)
📝 src/native/NativeCallObservation.ts (+1 -0)
➕ tests/boundary/filesystem/nativePascalVerifier.test.ts (+96 -0)
📝 tests/boundary/mcp/nativeCallObservationMcp.test.ts (+16 -1)
📝 tests/boundary/providers/native/lldbRetainedObservations.test.ts (+20 -0)
📝 tests/boundary/providers/native/nativeCallObservation.test.ts (+11 -1)
➕ tests/conformance/native/calls.pas (+16 -0)

📄 Description

Native call observations retain compiler-provided source file, line and column coordinates. The Pascal CLI/MCP verifier now checks the expected caller frame and compares its source coordinates as well as call-entry facts, and compiler invocations have finite deadlines so stalled probes or compilation reach cleanup.

Original implementation by @matbrgz in https://github.com/morluto/rea/pull/2400. This follow-up retains the original contribution commits and adds the review fixes in 32893d7fb31815c16d881d5847b5aadcdce25021. The original fork rejected the maintainer push with HTTP 403, so this branch provides the requested replacement.

Validation: source inspection and git diff --check completed. Tests, automated checks, and real LLDB/Free Pascal execution were not run at the user’s explicit request. Existing verification records are historical and do not verify these final changes.

Author readiness

Human owner: @morluto

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2800 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/13/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/review-fixes-pr-2400` --- ### 📝 Commits (10+) - [`8b0e330`](https://github.com/morluto/rea/commit/8b0e330c251fe5e959b8464be41a805285a2059e) feat(native): retain LLDB source coordinates and verify Pascal call entries - [`948a4bf`](https://github.com/morluto/rea/commit/948a4bf25f84d4aedaf42ab3e60873f1bedadb5f) docs: namespace native specifications by domain and feature - [`681b82c`](https://github.com/morluto/rea/commit/681b82c230df49b3ebcd0272c515de4f234306a9) fix(native): bound Pascal verification and compare caller coordinates - [`e3a1e56`](https://github.com/morluto/rea/commit/e3a1e5633f2ff02a8c2782798bea484d5f6e3048) fix(native): bound compiler shutdown and source-coordinate fixtures - [`60c34b6`](https://github.com/morluto/rea/commit/60c34b69073dddc98973f14c8c4f0157c0d84203) docs: clarify historical native source verification - [`b576b34`](https://github.com/morluto/rea/commit/b576b347b1f830c86dc9230c1494734fe305eebe) fix(native): preserve source attribution and compiler ownership - [`4a9883b`](https://github.com/morluto/rea/commit/4a9883b42c3442f68ffe29a91edd838f22b5349c) docs(native): qualify retained source attribution - [`ca7e980`](https://github.com/morluto/rea/commit/ca7e980d49e8f1db03c7cdd26506620e82bac768) fix(ci): clean up native Pascal verifier processes - [`b26e4c0`](https://github.com/morluto/rea/commit/b26e4c053654b270d774dbc1d0a42f78d7c08f42) Merge remote-tracking branch 'origin/main' into sweep/2800 - [`13d62bb`](https://github.com/morluto/rea/commit/13d62bb932375b2b41f4cf224aec565748de4c94) test(native): type the Pascal verifier helper import after merging main ### 📊 Changes **20 files changed** (+637 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `bridge/native/rea_lldb_tracer.py` (+15 -0) 📝 `bridge/native/test_rea_lldb_tracer.py` (+88 -13) 📝 `docs/native-investigation.md` (+19 -0) ➕ `docs/specs/native/call-source-locations/plan.md` (+39 -0) ➕ `docs/specs/native/call-source-locations/spec.md` (+36 -0) ➕ `docs/specs/native/call-source-locations/tasks.md` (+14 -0) ➕ `docs/specs/native/call-source-locations/verification.md` (+42 -0) 📝 `package.json` (+1 -0) ➕ `scripts/lib/canonical-temporary-directory.d.mts` (+5 -0) ➕ `scripts/lib/canonical-temporary-directory.mjs` (+17 -0) 📝 `scripts/verify-native-calls.mjs` (+18 -0) ➕ `scripts/verify-native-pascal-calls.mjs` (+170 -0) 📝 `src/domain/native/nativeCallObservation.ts` (+12 -0) 📝 `src/native/LldbRetainedObservations.ts` (+1 -0) 📝 `src/native/NativeCallObservation.ts` (+1 -0) ➕ `tests/boundary/filesystem/nativePascalVerifier.test.ts` (+96 -0) 📝 `tests/boundary/mcp/nativeCallObservationMcp.test.ts` (+16 -1) 📝 `tests/boundary/providers/native/lldbRetainedObservations.test.ts` (+20 -0) 📝 `tests/boundary/providers/native/nativeCallObservation.test.ts` (+11 -1) ➕ `tests/conformance/native/calls.pas` (+16 -0) </details> ### 📄 Description Native call observations retain compiler-provided source file, line and column coordinates. The Pascal CLI/MCP verifier now checks the expected caller frame and compares its source coordinates as well as call-entry facts, and compiler invocations have finite deadlines so stalled probes or compilation reach cleanup. Original implementation by @matbrgz in https://github.com/morluto/rea/pull/2400. This follow-up retains the original contribution commits and adds the review fixes in 32893d7fb31815c16d881d5847b5aadcdce25021. The original fork rejected the maintainer push with HTTP 403, so this branch provides the requested replacement. Validation: source inspection and git diff --check completed. Tests, automated checks, and real LLDB/Free Pascal execution were not run at the user’s explicit request. Existing verification records are historical and do not verify these final changes. ## Author readiness Human owner: @morluto - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 01:06:23 +00:00

bsakaguchi referenced this issue

2026-11-01 21:44:13 +00:00

[PR #5501] [MERGED] fix(native): admit universal Mach-O files without a host slice #6942