[PR #1323] [CLOSED] fix(javascript): select TypeScript declaration and CTS parser modes #2800

New issue

Closed

opened 2026-10-17 21:10:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1323
Author: @rudycelekli
Created: 10/9/2026
Status: ❌ Closed

Base: main ← Head: fix/javascript-declaration-file-parsing

📝 Commits (1)

2b9e4af fix(javascript): parse declaration artifacts in ambient mode

📊 Changes

2 files changed (+63 additions, -6 deletions)

View changed files

➕ src/application/javascript/JavaScriptApplicationDeclarations.test.ts (+54 -0)
📝 src/domain/javascript/javascriptSourceParser.ts (+9 -6)

📄 Description

Valid .d.ts/.d.mts/.d.cts ambient const declarations falsely report missing initializers, and ordinary .cts angle-bracket assertions are treated as JSX. Enable TypeScript dts mode for declaration paths and disable JSX for .cts alongside .ts. Public analysis remains complete for these valid artifacts; ordinary TypeScript missing initializer diagnostics remain.

Validation: four public application regressions fail on the exact upstream parser while the ordinary invalid-TypeScript control passes. The fixed affected service, filesystem, and CLI suites pass 76 tests across six files. npm run check succeeds across six tasks with existing warnings and no errors; whitespace checks pass. Tests use owned temporary artifacts and isolated HOME; no real runtime/provider or full repository test-suite claim. Prepared with AI assistance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1323 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/9/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/javascript-declaration-file-parsing` --- ### 📝 Commits (1) - [`2b9e4af`](https://github.com/morluto/rea/commit/2b9e4af42f57f42631da903cb55b29974af9d9f5) fix(javascript): parse declaration artifacts in ambient mode ### 📊 Changes **2 files changed** (+63 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `src/application/javascript/JavaScriptApplicationDeclarations.test.ts` (+54 -0) 📝 `src/domain/javascript/javascriptSourceParser.ts` (+9 -6) </details> ### 📄 Description Valid .d.ts/.d.mts/.d.cts ambient const declarations falsely report missing initializers, and ordinary .cts angle-bracket assertions are treated as JSX. Enable TypeScript dts mode for declaration paths and disable JSX for .cts alongside .ts. Public analysis remains complete for these valid artifacts; ordinary TypeScript missing initializer diagnostics remain. Validation: four public application regressions fail on the exact upstream parser while the ordinary invalid-TypeScript control passes. The fixed affected service, filesystem, and CLI suites pass 76 tests across six files. `npm run check` succeeds across six tasks with existing warnings and no errors; whitespace checks pass. Tests use owned temporary artifacts and isolated HOME; no real runtime/provider or full repository test-suite claim. Prepared with AI assistance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:26 +00:00