[PR #2823] [CLOSED] fix(browser): extract web bundle routes declared with template literals #5418

New issue

Closed

opened 2026-10-31 01:06:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2823
Author: @Totopo27
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: fix/web-bundle-template-literal-routes

📝 Commits (10+)

56f4ca4 fix(browser): extract web bundle routes declared with template literals
ef13872 fix: reconcile captured main and owned findings for PR #2823
dc3039d test(javascript): cover static route templates
f3706ad test(javascript): compare route findings structurally
3537c13 fix(comparison): recheck historical calls-only changes (#2223)
c843b45 fix(ci): isolate Linux Hopper process fixture inventory
9523b64 fix(android): make DEX descriptor pattern portable
6aa87cd fix: repair the static-check failures on the default branch (#2895)
abef722 merge: refresh PR #2823 with main
3258a41 Merge branch 'main' into fix/web-bundle-template-literal-routes

📊 Changes

2 files changed (+37 additions, -0 deletions)

View changed files

📝 src/domain/javascript/javascriptRpcEndpoints.test.ts (+12 -0)
📝 src/domain/webBundleAnalyzer.test.ts (+25 -0)

📄 Description

Closes #2805

Summary

In \src/domain/webBundleAnalyzerInspection.ts, \inspectRouteProperty\ checked \ .isStringLiteral(node.value), missing routes when bundlers or minifiers (e.g. rolldown, esbuild, Angular 20) emit route path definitions using expression-free template literals ({ path: \oo\ }).

Changes

In \src/domain/webBundleAnalyzerInspection.ts: use \stringValue(node.value)\ in \inspectRouteProperty\ to extract exact strings from string literals and expression-free template literals.
In \src/domain/webBundleAnalyzerAst.ts: update \objectString\ to evaluate values with
eadExactJavaScriptLiteral.
In \src/domain/webBundleAnalyzer.test.ts: add a regression test verifying route extraction for expression-free template literals.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2823 **Author:** [@Totopo27](https://github.com/Totopo27) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/web-bundle-template-literal-routes` --- ### 📝 Commits (10+) - [`56f4ca4`](https://github.com/morluto/rea/commit/56f4ca459ff0a5db80a981faacca6a4c50748c99) fix(browser): extract web bundle routes declared with template literals - [`ef13872`](https://github.com/morluto/rea/commit/ef13872bd73113812cfae32af0aaaaba782b0e76) fix: reconcile captured main and owned findings for PR #2823 - [`dc3039d`](https://github.com/morluto/rea/commit/dc3039d8193f7cc0a8ce5c410e5a6c8cfabaa711) test(javascript): cover static route templates - [`f3706ad`](https://github.com/morluto/rea/commit/f3706ad227b483701566603dc2432cabdf50f8dc) test(javascript): compare route findings structurally - [`3537c13`](https://github.com/morluto/rea/commit/3537c135eda230fa5db4f8023bad64d9ede2a5a1) fix(comparison): recheck historical calls-only changes (#2223) - [`c843b45`](https://github.com/morluto/rea/commit/c843b455bb08d64947b1cbca27fe54188c773f27) fix(ci): isolate Linux Hopper process fixture inventory - [`9523b64`](https://github.com/morluto/rea/commit/9523b64be1d2809109952193bd8d3e0fc78a5ac6) fix(android): make DEX descriptor pattern portable - [`6aa87cd`](https://github.com/morluto/rea/commit/6aa87cd71469a47b05442fbab73ce7393b476b71) fix: repair the static-check failures on the default branch (#2895) - [`abef722`](https://github.com/morluto/rea/commit/abef72237bc56cd5f97fd3957a91abcf54b77eff) merge: refresh PR #2823 with main - [`3258a41`](https://github.com/morluto/rea/commit/3258a4189d7a78f60651ec733a03655c96664fc9) Merge branch 'main' into fix/web-bundle-template-literal-routes ### 📊 Changes **2 files changed** (+37 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptRpcEndpoints.test.ts` (+12 -0) 📝 `src/domain/webBundleAnalyzer.test.ts` (+25 -0) </details> ### 📄 Description Closes #2805 ### Summary In \src/domain/webBundleAnalyzerInspection.ts\, \inspectRouteProperty\ checked \ .isStringLiteral(node.value)\, missing routes when bundlers or minifiers (e.g. rolldown, esbuild, Angular 20) emit route path definitions using expression-free template literals (\{ path: \oo\ }\). ### Changes - In \src/domain/webBundleAnalyzerInspection.ts\: use \stringValue(node.value)\ in \inspectRouteProperty\ to extract exact strings from string literals and expression-free template literals. - In \src/domain/webBundleAnalyzerAst.ts\: update \objectString\ to evaluate values with \ eadExactJavaScriptLiteral\. - In \src/domain/webBundleAnalyzer.test.ts\: add a regression test verifying route extraction for expression-free template literals. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:28 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5418

No description provided.

Rows
Columns