[PR #2993] [CLOSED] fix(checks): restore the lint and format baseline on the default branch #5548

New issue

Closed

opened 2026-10-31 01:07:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2993
Author: @XiaoBinGan
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: fix/static-checks-lint-budget

📝 Commits (1)

09f0aa5 fix(checks): restore the lint and format baseline on the default branch

📊 Changes

4 files changed (+7 additions, -4 deletions)

View changed files

📝 src/dotnet/ManagedCilDecoding.test.ts (+1 -0)
📝 tests/boundary/filesystem/artifactComparison.test.ts (+1 -0)
📝 tests/boundary/mcp/enhancedTools.04-uses-complete-inventories-inline.test.ts (+1 -3)
📝 tests/evaluation/package/packagePlatformDiagnostics.test.ts (+4 -1)

📄 Description

Summary

Restore the default branch's Static checks: the two max-lines-per-function lint errors and the two unformatted files that the default branch currently reports.

Problem and expected behavior

The default branch is red independently of any pull request, so every open PR inherits a failing Static checks task. Measured on origin/main @ 20b802f1:

npm run lint          → Lint: 2962 files, 2 errors, 1122 warnings.
                        tests/boundary/filesystem/artifactComparison.test.ts:345:46
                        src/dotnet/ManagedCilDecoding.test.ts:248:48
npm run format:check  → Format issues found in above 2 files:
                        tests/boundary/mcp/enhancedTools.04-uses-complete-inventories-inline.test.ts
                        tests/evaluation/package/packagePlatformDiagnostics.test.ts

Expected: the default branch reports no lint errors and no format drift, so a PR's Static checks reflects only that PR's own content.

Change and scope

The two reported functions are describe(...) callbacks holding one exhaustive scenario (artifact comparison completeness) and one exhaustive case table (managed operand extent diagnostics). Rather than splitting the scenarios — which would change what each test reads as one flow — each now carries the repository's existing targeted form, // oxlint-disable-next-line max-lines-per-function -- <reason>, as already used in tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts and src/server/registerEnhancedTools.ts.
The two unformatted files are reformatted by the pinned formatter with no source change.
No production source, contract, or behavior is touched.

Contract and boundary impact

None. The four files are tests, plus one test-adjacent reason comment. No CLI/MCP contract, schema, generated artifact, or provider adapter is affected.

Evidence and regression coverage

Measured on this head, with the same commands used to state the problem:

npm run format:check  → All matched files use the correct format.
npm run lint          → Lint: 2962 files, 0 errors, 1122 warnings.
npm run check:fast    → Tasks: 2 successful, 2 total
npm run test:focused -- tests/boundary/filesystem/artifactComparison.test.ts \
  src/dotnet/ManagedCilDecoding.test.ts \
  tests/boundary/mcp/enhancedTools.04-uses-complete-inventories-inline.test.ts \
  tests/evaluation/package/packagePlatformDiagnostics.test.ts
                      → Test Files 4 passed (4) · Tests 105 passed (105)

The focused tests are the four affected files; the same commands fail on the parent revision, which is the with/without evidence for this change.

Unavailable coverage

The full check:pr gate and the CI shards were not run locally; the four affected test files were run directly. No real-provider behavior is involved.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2993 **Author:** [@XiaoBinGan](https://github.com/XiaoBinGan) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/static-checks-lint-budget` --- ### 📝 Commits (1) - [`09f0aa5`](https://github.com/morluto/rea/commit/09f0aa534a82d52f0208f724e6bfcd241189d0d7) fix(checks): restore the lint and format baseline on the default branch ### 📊 Changes **4 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/dotnet/ManagedCilDecoding.test.ts` (+1 -0) 📝 `tests/boundary/filesystem/artifactComparison.test.ts` (+1 -0) 📝 `tests/boundary/mcp/enhancedTools.04-uses-complete-inventories-inline.test.ts` (+1 -3) 📝 `tests/evaluation/package/packagePlatformDiagnostics.test.ts` (+4 -1) </details> ### 📄 Description ## Summary Restore the default branch's `Static checks`: the two `max-lines-per-function` lint errors and the two unformatted files that the default branch currently reports. ## Problem and expected behavior The default branch is red independently of any pull request, so every open PR inherits a failing `Static checks` task. Measured on `origin/main` @ `20b802f1`: ``` npm run lint → Lint: 2962 files, 2 errors, 1122 warnings. tests/boundary/filesystem/artifactComparison.test.ts:345:46 src/dotnet/ManagedCilDecoding.test.ts:248:48 npm run format:check → Format issues found in above 2 files: tests/boundary/mcp/enhancedTools.04-uses-complete-inventories-inline.test.ts tests/evaluation/package/packagePlatformDiagnostics.test.ts ``` Expected: the default branch reports no lint errors and no format drift, so a PR's `Static checks` reflects only that PR's own content. ## Change and scope - The two reported functions are `describe(...)` callbacks holding one exhaustive scenario (`artifact comparison completeness`) and one exhaustive case table (`managed operand extent diagnostics`). Rather than splitting the scenarios — which would change what each test reads as one flow — each now carries the repository's existing targeted form, `// oxlint-disable-next-line max-lines-per-function -- <reason>`, as already used in `tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts` and `src/server/registerEnhancedTools.ts`. - The two unformatted files are reformatted by the pinned formatter with no source change. - No production source, contract, or behavior is touched. ## Contract and boundary impact None. The four files are tests, plus one test-adjacent reason comment. No CLI/MCP contract, schema, generated artifact, or provider adapter is affected. ## Evidence and regression coverage Measured on this head, with the same commands used to state the problem: ``` npm run format:check → All matched files use the correct format. npm run lint → Lint: 2962 files, 0 errors, 1122 warnings. npm run check:fast → Tasks: 2 successful, 2 total npm run test:focused -- tests/boundary/filesystem/artifactComparison.test.ts \ src/dotnet/ManagedCilDecoding.test.ts \ tests/boundary/mcp/enhancedTools.04-uses-complete-inventories-inline.test.ts \ tests/evaluation/package/packagePlatformDiagnostics.test.ts → Test Files 4 passed (4) · Tests 105 passed (105) ``` The focused tests are the four affected files; the same commands fail on the parent revision, which is the with/without evidence for this change. ## Unavailable coverage The full `check:pr` gate and the CI shards were not run locally; the four affected test files were run directly. No real-provider behavior is involved. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:30 +00:00