morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #5548] [MERGED] fix(native): remove completed signing capture limitation #6956

New issue

Closed

opened 2026-11-01 21:44:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:44:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5548
Author: @ShuaixinHuang
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto

Base: main ← Head: codex/fix-signature-completed-capture-note

📝 Commits (10+)

8dc3586 fix(native): remove completed signing capture limitation
6209941 Merge commit 'd672cc2399' into codex/fix-signature-completed-capture-note
43bf447 fix(cli): keep the WASM command timeout optional
8cf2c90 fix(cli): preserve WASM timeout help metadata
f7fda5a Merge branch 'codex/fix-wasm-timeout-optional-ci' into codex/fix-signature-completed-capture-note
330cd2c test(pe): reuse compiled CLI startup for resource acceptance
e68cf06 Merge branch 'codex/fix-pe-resource-cli-startup-ci' into codex/fix-signature-completed-capture-note
a9c5f67 Merge remote-tracking branch 'origin/main' into codex/fix-signature-completed-capture-note
42a0f21 fix(cli): use upstream exact-optional timeout semantics
f074db3 Merge remote-tracking branch 'origin/main' into codex/fix-signature-completed-capture-note

📊 Changes

3 files changed (+11 additions, -5 deletions)

View changed files

📝 src/native/parsers/codesign.ts (+1 -5)
📝 tests/boundary/cli/nativeSignatureCli.test.ts (+6 -0)
📝 tests/boundary/providers/native/nativeSignatureTargetBinding.test.ts (+4 -0)

📄 Description

Summary

Fixes #5538. Remove the stale note claiming entitlements and designated requirements need separate commands after they have already been captured. Preserve signing facts, provenance, unsigned observations and genuine snapshot/trust limitations.

Scope

Synchronized with upstream c538a843. Adopt upstream's complete PE acceptance test, including independent PE32/PE32+ wrapper processes and malformed-input coverage. The temporary WASM adaptation is also gone. Both files match upstream and are absent from the net diff.

Only the original three signature files remain: 11 additions and 5 deletions.

Validation

Head f074db3c, Windows x64, pinned Node 24.18.0; installed dependencies match the upstream lockfile:

npm run check: all six tasks, module boundaries and architecture guards passed.
Signature CLI test file loaded successfully; both macOS-only tests were skipped on Windows. This does not establish real codesign behavior.
The identical upstream PE acceptance test passed on the synchronized #5555 branch (8.6 seconds).
Earlier signature regression/golden checks passed; preceding head 42a0f216 passed required CI. Fresh CI, including real Apple CLI/MCP E2E, must qualify this synchronized head.
No local real macOS run.

Author readiness

Human owner: @ShuaixinHuang

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5548 **Author:** [@ShuaixinHuang](https://github.com/ShuaixinHuang) **Created:** 10/20/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/fix-signature-completed-capture-note` --- ### 📝 Commits (10+) - [`8dc3586`](https://github.com/morluto/rea/commit/8dc35862d9a19aa20f2023ff82cc3849935c9ee9) fix(native): remove completed signing capture limitation - [`6209941`](https://github.com/morluto/rea/commit/6209941234f2cf6902cefac1863d371c462b2f04) Merge commit 'd672cc23998b6cbb21c485f118595ebfb82fed33' into codex/fix-signature-completed-capture-note - [`43bf447`](https://github.com/morluto/rea/commit/43bf447f44a585d4b8624b4b4cdbebf9ee601c3c) fix(cli): keep the WASM command timeout optional - [`8cf2c90`](https://github.com/morluto/rea/commit/8cf2c90a6dfcaaca268a8ca4a7d02ee781689057) fix(cli): preserve WASM timeout help metadata - [`f7fda5a`](https://github.com/morluto/rea/commit/f7fda5a15e832763a9f61ed132478873471c2c6e) Merge branch 'codex/fix-wasm-timeout-optional-ci' into codex/fix-signature-completed-capture-note - [`330cd2c`](https://github.com/morluto/rea/commit/330cd2c40582e4443b40abce7c4aed7a27dc761a) test(pe): reuse compiled CLI startup for resource acceptance - [`e68cf06`](https://github.com/morluto/rea/commit/e68cf06b35a9e350e7100bb0c23d9952df0dd20e) Merge branch 'codex/fix-pe-resource-cli-startup-ci' into codex/fix-signature-completed-capture-note - [`a9c5f67`](https://github.com/morluto/rea/commit/a9c5f670305f876381b61379e7b3bdd1e7e98a0c) Merge remote-tracking branch 'origin/main' into codex/fix-signature-completed-capture-note - [`42a0f21`](https://github.com/morluto/rea/commit/42a0f21682a0d53e96003bdd98f59b27c570c584) fix(cli): use upstream exact-optional timeout semantics - [`f074db3`](https://github.com/morluto/rea/commit/f074db3cdedee8031c7dda6f955b205f50616ea8) Merge remote-tracking branch 'origin/main' into codex/fix-signature-completed-capture-note ### 📊 Changes **3 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/native/parsers/codesign.ts` (+1 -5) 📝 `tests/boundary/cli/nativeSignatureCli.test.ts` (+6 -0) 📝 `tests/boundary/providers/native/nativeSignatureTargetBinding.test.ts` (+4 -0) </details> ### 📄 Description ## Summary Fixes #5538. Remove the stale note claiming entitlements and designated requirements need separate commands after they have already been captured. Preserve signing facts, provenance, unsigned observations and genuine snapshot/trust limitations. ## Scope Synchronized with upstream `c538a843`. Adopt upstream's complete PE acceptance test, including independent PE32/PE32+ wrapper processes and malformed-input coverage. The temporary WASM adaptation is also gone. Both files match upstream and are absent from the net diff. Only the original three signature files remain: 11 additions and 5 deletions. ## Validation Head `f074db3c`, Windows x64, pinned Node 24.18.0; installed dependencies match the upstream lockfile: - `npm run check`: all six tasks, module boundaries and architecture guards passed. - Signature CLI test file loaded successfully; both macOS-only tests were skipped on Windows. This does not establish real codesign behavior. - The identical upstream PE acceptance test passed on the synchronized #5555 branch (8.6 seconds). - Earlier signature regression/golden checks passed; preceding head `42a0f216` passed required CI. Fresh CI, including real Apple CLI/MCP E2E, must qualify this synchronized head. - No local real macOS run. ## Author readiness Human owner: @ShuaixinHuang - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:44:19 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:48:05 +00:00

[PR #6955] [MERGED] fix(apple): keep dyld candidates inside the analyzed root on Windows #7473

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6956

No description provided.

Rows
Columns