[PR #3049] [MERGED] test(applications): pass Evidence requests to the CLI through files #5583

New issue

Closed

opened 2026-10-31 01:07:45 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3049
Author: @GuilhermeFusari
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/15/2026
Merged by: @N0zoM1z0

Base: main ← Head: test/windows-cli-evidence-request-files

📝 Commits (10+)

dd1c879 fix(windows): end output streams before releasing owned handles
187f113 fix(identity)!: preserve invocation uncertainty and advertised catalogs
57bb7ec fix(adb): parse successful daemon notices from both output streams
5b3400d fix(pwntools): preserve actionable provider admission errors
56128a8 fix(frida): preserve attach targets and reconcile early detachment
f14c2d4 fix(browser): retain Playwright IPv6 capture representations
f2f8393 fix(javascript): preserve resource error reasons across worker frames
eef4a0b fix(javascript): derive loader references from lexical binding ownership
12b3cdb fix(javascript): preserve final RPC property and source-body ownership
ccd7486 test(mcp): retain uncertainty for empty capped IDA reference pages

📊 Changes

1123 files changed (+195054 additions, -58672 deletions)

View changed files

📝 .agents/skills/rea-changelog-update/SKILL.md (+3 -3)
📝 .agents/skills/reverse-engineer-anything/SKILL.md (+16 -2)
📝 .agents/skills/reverse-engineer-anything/references/javascript-applications.md (+30 -0)
📝 .agents/skills/reverse-engineer-anything/references/native-and-artifacts.md (+8 -0)
📝 .github/ISSUE_TEMPLATE/bug_report.yml (+23 -13)
📝 .github/ISSUE_TEMPLATE/design_discussion.yml (+1 -1)
📝 .github/ISSUE_TEMPLATE/documentation.yml (+12 -3)
📝 .github/ISSUE_TEMPLATE/feature_request.yml (+4 -2)
➕ .github/actions/prepare-release-package/action.yml (+26 -0)
➕ .github/actions/publish-mcp/action.yml (+41 -0)
➕ .github/actions/publish-mcp/registry-state.d.mts (+4 -0)
➕ .github/actions/publish-mcp/registry-state.mjs (+89 -0)
📝 .github/pull_request_template.md (+24 -3)
📝 .github/workflows/ci.yml (+19 -4)
➕ .github/workflows/mutation.yml (+62 -0)
➕ .github/workflows/pr-readiness.yml (+51 -0)
➕ .github/workflows/release-recovery.yml (+109 -0)
📝 .github/workflows/release.yml (+53 -65)
📝 .release-please-manifest.json (+1 -1)
📝 AGENTS.md (+31 -0)

...and 80 more files

📄 Description

Summary

Two remaining application acceptance workflows put complete Evidence into argv, exceeding Windows' command-line capacity before the CLI starts. They now use the existing file-backed input contract without truncation, within each test's existing owned directory. The rest-argument case was already file-backed on main and remains unchanged. Small inline-input, malformed-input and Evidence assertions stay intact. Refs #2942 (already closed).

Refreshed on main 40f73f62b; only applicationWorkflowCli.test.ts changes. No runtime or cache policy changes. The proposed compile-cache migration needs a separate equivalent-workflow measurement and is not part of this transport fix.

Validation

Linux x64, Node24.18.0/npm11.16.0, two cores: complete file 34 passed through actual compiled CLI/MCP. Wall 85.75s, child CPU user/system 88.26/20.79s, sampled peak family RSS 1.94 GiB; artifact caches warm, fresh test and CLI processes. The sampler can miss short/reparented processes and double-count shared pages. Agent tokens unmeasured; no speedup claim.
check:ci (eight tasks plus 1439 architecture guards) and normal pre-push passed.
Native Windows x64 / Node24.18.0 baseline and fix: unchanged main 40f73f62b fails both affected cases with spawn ENAMETOOLONG; candidate 8809be934 passes four cases, including inline JSON parity and the existing rest trace. Deliberate selection leaves 30 other cases unexecuted; this is not a complete Windows-file claim. JSON reports and receipt were downloaded and checked. Diagnostic commit a13200b01 differs from the candidate only in ci.yml, and verifies a clean restored candidate tree. Baseline/candidate commands took 6.30s failed / 21.20s completed; these are not comparable performance workloads. Hosted CPU/memory were not measured.
The first diagnostic run also reproduced both spawn failures, but an observability assertion incorrectly expected console text from the JSON reporter. It was corrected to inspect original structured failure messages; no PR source changed. Both raw runs are retained.
All selected current-head CI jobs passed except Windows native conformance: its unchanged verify-windows-native.mjs:322 PowerShell ACL probe timed out at its existing 15s bound with no output. All five shards, Portable tests, Apple E2E and other selected real lanes passed. One isolated job rerun passed native conformance, package verification and Node22/24 boundaries; the complete run and required gate now pass. This supports a transient runner explanation without establishing a root cause; the original failure is retained and no timeout/source was changed. Codex reviewed 8809be934 without findings. Greptile completed and raised two unrelated production findings; both files have identical blobs on main and this head. Scope was explained in both threads, which were resolved without unrelated changes.

Original contributor: @GuilhermeFusari. The user explicitly delegated follow-up implementation, technical review, ready-for-review update and merge. Assistant technical review is reported; a separate human reread is not claimed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3049 **Author:** [@GuilhermeFusari](https://github.com/GuilhermeFusari) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/15/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `test/windows-cli-evidence-request-files` --- ### 📝 Commits (10+) - [`dd1c879`](https://github.com/morluto/rea/commit/dd1c879580200714ebb2eaaa0e07eae2a2497e1c) fix(windows): end output streams before releasing owned handles - [`187f113`](https://github.com/morluto/rea/commit/187f113f798b5b8a080d22285b51c05596c3e0f2) fix(identity)!: preserve invocation uncertainty and advertised catalogs - [`57bb7ec`](https://github.com/morluto/rea/commit/57bb7ec5ca44388b9e4ced1588eda0a72bd879ac) fix(adb): parse successful daemon notices from both output streams - [`5b3400d`](https://github.com/morluto/rea/commit/5b3400d5d945d98b1f31b18579bf6cece1c55773) fix(pwntools): preserve actionable provider admission errors - [`56128a8`](https://github.com/morluto/rea/commit/56128a8424d8922fe3d4a45faed9e29989e5924d) fix(frida): preserve attach targets and reconcile early detachment - [`f14c2d4`](https://github.com/morluto/rea/commit/f14c2d4df398dbcd3353ea15ab5a4e31be7a5920) fix(browser): retain Playwright IPv6 capture representations - [`f2f8393`](https://github.com/morluto/rea/commit/f2f83934d22e4d375a74dea06677eb77d6958259) fix(javascript): preserve resource error reasons across worker frames - [`eef4a0b`](https://github.com/morluto/rea/commit/eef4a0bfb4f005dcfb0d16cf6a6d5bc85d743e23) fix(javascript): derive loader references from lexical binding ownership - [`12b3cdb`](https://github.com/morluto/rea/commit/12b3cdb8041d82e90dc7360db9e74782ac8583ae) fix(javascript): preserve final RPC property and source-body ownership - [`ccd7486`](https://github.com/morluto/rea/commit/ccd748635cf776dc95a1b3bea89298aafe4a2a07) test(mcp): retain uncertainty for empty capped IDA reference pages ### 📊 Changes **1123 files changed** (+195054 additions, -58672 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/rea-changelog-update/SKILL.md` (+3 -3) 📝 `.agents/skills/reverse-engineer-anything/SKILL.md` (+16 -2) 📝 `.agents/skills/reverse-engineer-anything/references/javascript-applications.md` (+30 -0) 📝 `.agents/skills/reverse-engineer-anything/references/native-and-artifacts.md` (+8 -0) 📝 `.github/ISSUE_TEMPLATE/bug_report.yml` (+23 -13) 📝 `.github/ISSUE_TEMPLATE/design_discussion.yml` (+1 -1) 📝 `.github/ISSUE_TEMPLATE/documentation.yml` (+12 -3) 📝 `.github/ISSUE_TEMPLATE/feature_request.yml` (+4 -2) ➕ `.github/actions/prepare-release-package/action.yml` (+26 -0) ➕ `.github/actions/publish-mcp/action.yml` (+41 -0) ➕ `.github/actions/publish-mcp/registry-state.d.mts` (+4 -0) ➕ `.github/actions/publish-mcp/registry-state.mjs` (+89 -0) 📝 `.github/pull_request_template.md` (+24 -3) 📝 `.github/workflows/ci.yml` (+19 -4) ➕ `.github/workflows/mutation.yml` (+62 -0) ➕ `.github/workflows/pr-readiness.yml` (+51 -0) ➕ `.github/workflows/release-recovery.yml` (+109 -0) 📝 `.github/workflows/release.yml` (+53 -65) 📝 `.release-please-manifest.json` (+1 -1) 📝 `AGENTS.md` (+31 -0) _...and 80 more files_ </details> ### 📄 Description ## Summary Two remaining application acceptance workflows put complete Evidence into argv, exceeding Windows' command-line capacity before the CLI starts. They now use the existing file-backed input contract without truncation, within each test's existing owned directory. The rest-argument case was already file-backed on main and remains unchanged. Small inline-input, malformed-input and Evidence assertions stay intact. Refs #2942 (already closed). Refreshed on main `40f73f62b`; only `applicationWorkflowCli.test.ts` changes. No runtime or cache policy changes. The proposed compile-cache migration needs a separate equivalent-workflow measurement and is not part of this transport fix. ## Validation - Linux x64, Node24.18.0/npm11.16.0, two cores: complete file **34 passed** through actual compiled CLI/MCP. Wall **85.75s**, child CPU user/system **88.26/20.79s**, sampled peak family RSS **1.94 GiB**; artifact caches warm, fresh test and CLI processes. The sampler can miss short/reparented processes and double-count shared pages. Agent tokens unmeasured; no speedup claim. - `check:ci` (eight tasks plus 1439 architecture guards) and normal pre-push passed. - [Native Windows x64 / Node24.18.0 baseline and fix](https://github.com/morluto/rea/actions/runs/38761374529): unchanged main `40f73f62b` fails both affected cases with **`spawn ENAMETOOLONG`**; candidate `8809be934` passes **four cases**, including inline JSON parity and the existing rest trace. Deliberate selection leaves 30 other cases unexecuted; this is not a complete Windows-file claim. JSON reports and receipt were downloaded and checked. Diagnostic commit `a13200b01` differs from the candidate only in `ci.yml`, and verifies a clean restored candidate tree. Baseline/candidate commands took **6.30s failed / 21.20s completed**; these are not comparable performance workloads. Hosted CPU/memory were not measured. - The first diagnostic run also reproduced both spawn failures, but an observability assertion incorrectly expected console text from the JSON reporter. It was corrected to inspect original structured failure messages; no PR source changed. Both raw runs are retained. - All selected current-head CI jobs passed except Windows native conformance: its unchanged `verify-windows-native.mjs:322` PowerShell ACL probe timed out at its existing 15s bound with no output. All five shards, Portable tests, Apple E2E and other selected real lanes passed. One isolated job rerun passed native conformance, package verification and Node22/24 boundaries; the [complete run](https://github.com/morluto/rea/actions/runs/38760707965) and required gate now pass. This supports a transient runner explanation without establishing a root cause; the original failure is retained and no timeout/source was changed. Codex reviewed `8809be934` without findings. Greptile completed and raised two unrelated production findings; both files have identical blobs on main and this head. Scope was explained in both threads, which were resolved without unrelated changes. Original contributor: @GuilhermeFusari. The user explicitly delegated follow-up implementation, technical review, ready-for-review update and merge. Assistant technical review is reported; a separate human reread is not claimed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:45 +00:00