[PR #3075] [MERGED] docs(native): distinguish analysis memory from source bytes #5594

New issue

Closed

opened 2026-10-31 01:07:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3075
Author: @siegfly
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/17/2026
Merged by: @N0zoM1z0

Base: main ← Head: codex/native-byte-provenance-guide

📝 Commits (10+)

9ac3036 docs(native): distinguish analysis memory from source bytes
22a762a Merge branch 'main' into codex/native-byte-provenance-guide
d61acfa Merge remote-tracking branch 'origin/main' into codex/native-byte-provenance-guide
e2386bb Merge branch 'main' into codex/native-byte-provenance-guide
1822526 Merge remote-tracking branch 'origin/main' into codex/native-byte-provenance-guide
46a7571 test(session): await status projections and own switch target fixtures
24f5977 chore: sync byte guidance with upstream status ownership
8193907 Merge branch 'main' into codex/native-byte-provenance-guide
7d0ec79 Merge branch 'main' into codex/native-byte-provenance-guide
79f7bc3 Merge branch 'main' into codex/native-byte-provenance-guide

📊 Changes

3 files changed (+51 additions, -5 deletions)

View changed files

📝 .agents/skills/reverse-engineer-anything/references/native-and-artifacts.md (+22 -4)
📝 docs/mcp-contracts.md (+19 -0)
📝 src/application/binary/BinarySessionLiveness.test.ts (+10 -1)

📄 Description

Summary

Distinguish native provider analysis-memory bytes from original source-file bytes in the native and MCP guides. Explain virtual-address mapping, partial/uninitialized ranges and byte provenance.

Also retain the test-only portable liveness target from the independent 849c27ff7 correction: a test-owned alternate ELF replaces the hard-coded /bin/ls. Main has now adopted a stronger async/schema status-projection repair, so that duplicate test change is removed in favor of upstream.

The final diff against main is two documentation files and one session test. No production authority/schema changes, binaries, game/reconstruction material or generated artifacts.

Validation performed

Head 24f597732059debf505483281e2224c91252fb78 includes main 4d980d017622d3175d86aaf3b0dcfbdf4ca3d091 (2026-10-17), preserving the maintainer's existing merges. Node 24.18.0/npm 11.16.0.

Exact-head Linux/WSL CI-equivalent npm run test:fast: 577 files; 9,054 passed / 8 skipped / zero failures. The previously failing async status projections pass.
Exact-head Windows native/application/MCP/session selection: 12 files; 161 passed / 1 platform skip.
Shared Linux Ghidra/lifecycle boundaries on this source archive: 13 files; 118 passed, zero skips/failures. Controlled process/filesystem/provider fixtures cover Java probes, installation/header/profile ownership, launch/endpoint/import finalization and MCP cleanup; this is one shared run, not three independent PR runs.
Fresh production MCP with real Ghidra 12.1.4/JDK 21.0.12.1+1: 24 assertions passed on this exact head. Includes mapped/partial/uninitialized byte provenance, exact four-page retained pseudocode without another bridge call, actual function cancellation, owned PID/creation-time family and runtime/project/endpoint cleanup before uncached reimport, clean close and unchanged self-owned PE bytes. Matching published Windows 6.5.0 native addon; not claimed source-built.
Full npm run check, docs:check (5 README cases), diff/format and pre-push check:fast passed.

CI and remaining scope

Main adopted the async/schema status-test repair in 870dcb1fd; the merged upstream version supersedes that part of the independent 849c27ff7 patch. This PR retains only its portable liveness target correction. The earlier failing hosted source run remains historical; local source success is not hosted CI success.

Three new-main Windows Ghidra fixture failures found in supplemental #3076 testing are repaired separately in #4334. Windows ADB/Cutter work remains separate. No complete Windows suite, real-engine cleanup-failure/late-timeout race, macOS, IDA/Kuna or distributed-package claim. Hosted Actions approval and Codex review quota are separate pending maintainer/admin prerequisites; existing human readiness declarations remain unchanged.

Baseline follow-up (2026-10-17)

Current head 79f7bc36e29577d390d93f9fd5e973f2cb138165 incorporates main 5b243993872c2bcc70cb00060ffb79b347321370, including the normally merged #4691/#4703 fixture repairs. Exact merge-tree verification and stable patch IDs confirm that this PR's patch is unchanged by the update. Current-head CI: All five built-dependent shards, Source/static checks and required gates passed.

Fresh exact-head npm run docs:check passes, including all 5 README consistency cases. Completed check: 30.98 s wall, 49.43 s reaped CPU, 3.22 GiB sampled process-family RSS. The earlier real Ghidra and portable liveness evidence above remains attributed to its stated revision and platform; it was not independently rerun on this merge commit.

Local heavy jobs ran serially on two CPU cores with a 3 GiB Node heap. RSS is sampled process-family memory, may double-count shared pages and excludes assistant/shared services; CPU covers reaped descendants. OS/dependency caches were not controlled. Model token use, controlled cold/warm costs and remote resource costs remain unmeasured; no token or speedup claim is inferred. Prior observations above remain tied to their stated revisions. Initial human-owner readiness remains valid and was not supplied on the author's behalf. Available automated reviews have no unresolved findings; Codex explicitly reports repository review-credit exhaustion, so no fresh Codex review is claimed.

Author readiness

Human owner: @siegfly

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

The human owner completed the initial declarations on 2026-10-16; later pushes preserve that declaration under the contribution policy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3075 **Author:** [@siegfly](https://github.com/siegfly) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/17/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `codex/native-byte-provenance-guide` --- ### 📝 Commits (10+) - [`9ac3036`](https://github.com/morluto/rea/commit/9ac303625c54fe6f69690a56a757da4bac9d22f6) docs(native): distinguish analysis memory from source bytes - [`22a762a`](https://github.com/morluto/rea/commit/22a762a382a84d3f0bf6e871f45374c100d9db63) Merge branch 'main' into codex/native-byte-provenance-guide - [`d61acfa`](https://github.com/morluto/rea/commit/d61acfa0e508bfe0a195735afcbb0542b1fe37cf) Merge remote-tracking branch 'origin/main' into codex/native-byte-provenance-guide - [`e2386bb`](https://github.com/morluto/rea/commit/e2386bb3eea4f8800fd932bd1b55fa670961ef8b) Merge branch 'main' into codex/native-byte-provenance-guide - [`1822526`](https://github.com/morluto/rea/commit/1822526affaa1c95c363923fc49c70eba7066176) Merge remote-tracking branch 'origin/main' into codex/native-byte-provenance-guide - [`46a7571`](https://github.com/morluto/rea/commit/46a7571f817137557fbc619b39e48189163b0116) test(session): await status projections and own switch target fixtures - [`24f5977`](https://github.com/morluto/rea/commit/24f597732059debf505483281e2224c91252fb78) chore: sync byte guidance with upstream status ownership - [`8193907`](https://github.com/morluto/rea/commit/8193907cd3bbaf8d009c7a59055f88bdaf543ce1) Merge branch 'main' into codex/native-byte-provenance-guide - [`7d0ec79`](https://github.com/morluto/rea/commit/7d0ec794056fd400f7003ef86a394aff5613786d) Merge branch 'main' into codex/native-byte-provenance-guide - [`79f7bc3`](https://github.com/morluto/rea/commit/79f7bc36e29577d390d93f9fd5e973f2cb138165) Merge branch 'main' into codex/native-byte-provenance-guide ### 📊 Changes **3 files changed** (+51 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/reverse-engineer-anything/references/native-and-artifacts.md` (+22 -4) 📝 `docs/mcp-contracts.md` (+19 -0) 📝 `src/application/binary/BinarySessionLiveness.test.ts` (+10 -1) </details> ### 📄 Description ## Summary Distinguish native provider analysis-memory bytes from original source-file bytes in the native and MCP guides. Explain virtual-address mapping, partial/uninitialized ranges and byte provenance. Also retain the test-only portable liveness target from the independent 849c27ff7 correction: a test-owned alternate ELF replaces the hard-coded /bin/ls. Main has now adopted a stronger async/schema status-projection repair, so that duplicate test change is removed in favor of upstream. The final diff against main is two documentation files and one session test. No production authority/schema changes, binaries, game/reconstruction material or generated artifacts. ## Validation performed Head `24f597732059debf505483281e2224c91252fb78` includes main `4d980d017622d3175d86aaf3b0dcfbdf4ca3d091` (2026-10-17), preserving the maintainer's existing merges. Node 24.18.0/npm 11.16.0. - Exact-head Linux/WSL CI-equivalent `npm run test:fast`: **577 files; 9,054 passed / 8 skipped / zero failures**. The previously failing async status projections pass. - Exact-head Windows native/application/MCP/session selection: **12 files; 161 passed / 1 platform skip**. - Shared Linux Ghidra/lifecycle boundaries on this source archive: **13 files; 118 passed, zero skips/failures**. Controlled process/filesystem/provider fixtures cover Java probes, installation/header/profile ownership, launch/endpoint/import finalization and MCP cleanup; this is one shared run, not three independent PR runs. - Fresh production MCP with **real Ghidra 12.1.4/JDK 21.0.12.1+1**: **24 assertions passed** on this exact head. Includes mapped/partial/uninitialized byte provenance, exact four-page retained pseudocode without another bridge call, actual function cancellation, owned PID/creation-time family and runtime/project/endpoint cleanup before uncached reimport, clean close and unchanged self-owned PE bytes. Matching published Windows 6.5.0 native addon; not claimed source-built. - Full `npm run check`, `docs:check` (5 README cases), diff/format and pre-push `check:fast` passed. ## CI and remaining scope Main adopted the async/schema status-test repair in `870dcb1fd`; the merged upstream version supersedes that part of the independent `849c27ff7` patch. This PR retains only its portable liveness target correction. The earlier failing hosted source run remains historical; local source success is not hosted CI success. Three new-main Windows Ghidra fixture failures found in supplemental #3076 testing are repaired separately in #4334. Windows ADB/Cutter work remains separate. No complete Windows suite, real-engine cleanup-failure/late-timeout race, macOS, IDA/Kuna or distributed-package claim. Hosted Actions approval and Codex review quota are separate pending maintainer/admin prerequisites; existing human readiness declarations remain unchanged. ## Baseline follow-up (2026-10-17) Current head `79f7bc36e29577d390d93f9fd5e973f2cb138165` incorporates main `5b243993872c2bcc70cb00060ffb79b347321370`, including the normally merged #4691/#4703 fixture repairs. Exact merge-tree verification and stable patch IDs confirm that this PR's patch is unchanged by the update. [Current-head CI](https://github.com/morluto/rea/actions/runs/39011232849): All five built-dependent shards, Source/static checks and required gates passed. Fresh exact-head `npm run docs:check` passes, including all 5 README consistency cases. Completed check: 30.98 s wall, 49.43 s reaped CPU, 3.22 GiB sampled process-family RSS. The earlier real Ghidra and portable liveness evidence above remains attributed to its stated revision and platform; it was not independently rerun on this merge commit. Local heavy jobs ran serially on two CPU cores with a 3 GiB Node heap. RSS is sampled process-family memory, may double-count shared pages and excludes assistant/shared services; CPU covers reaped descendants. OS/dependency caches were not controlled. Model token use, controlled cold/warm costs and remote resource costs remain unmeasured; no token or speedup claim is inferred. Prior observations above remain tied to their stated revisions. Initial human-owner readiness remains valid and was not supplied on the author's behalf. Available automated reviews have no unresolved findings; Codex explicitly reports repository review-credit exhaustion, so no fresh Codex review is claimed. ## Author readiness Human owner: @siegfly - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. The human owner completed the initial declarations on 2026-10-16; later pushes preserve that declaration under the contribution policy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:50 +00:00