morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3276] [MERGED] fix(website): correct Korean FAQ translations #5691

New issue

Closed

opened 2026-10-31 01:08:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3276
Author: @hachi-008
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/14/2026
Merged by: @morluto

Base: main ← Head: fix/ko-website-faq

📝 Commits (1)

481c0d6 fix(website): correct Korean FAQ translations

📊 Changes

1 file changed (+32 additions, -32 deletions)

View changed files

📝 website/locales/ko/messages.po (+32 -32)

📄 Description

Summary

Several strings on the Korean FAQ page (/ko/faq/) still come straight from the machine-assisted draft, and some change the meaning. The skip link reads "개인정보보호정책" ("Privacy policy"), and most questions have broken word order. This rewrites the 32 affected page:faq/index.html entries in website/locales/ko/messages.po. No issue: the translation guide invites language review of the first drafts.

A few examples, with rough back-translations:

English source	Current Korean (back-translated)	New Korean
Skip to content	개인정보보호정책 ("Privacy policy")	본문으로 건너뛰기
Does REA upload my app?	않습니다 REA 내 앱을 업로드 하시겠습니까? ("Does not. Would you upload REA my app?")	REA가 내 앱을 업로드하나요?
Which coding agents can use REA?	어떤 코딩 에이전트가 사용할 수 있습니까 REA? ("Which coding agent can use, REA?")	어떤 코딩 에이전트에서 REA를 사용할 수 있나요?
Copy scoped setup command	범위 설정 복사 명령 ("range setting copy command")	특정 클라이언트 설정 명령 복사

Problem and expected behavior

Korean readers see questions they have to decode, and screen-reader users hear "Privacy policy" for the skip link. Expected: natural Korean that keeps the meaning and every placeholder.

Change and scope

32 of the 78 FAQ entries: page title and headings (7), questions (9), answer lines (4), terminal labels (6) and copy-button labels (6).
Wording follows docs/readme/README_ko.md, which Korean contributors already reviewed (#1047, #3046). FAQ questions that also appear there use the same phrasing.
Placeholders, product names and commands are unchanged. The other 46 FAQ entries already read fine and are left alone.

Not included: other pages. The skip link has the same mistranslation on all 18 Korean pages; the other 17 are fixed in a separate PR.

Ordinary translation fix within existing boundaries; scope decision not applicable.

Contract and boundary impact

Semantic owner and earliest changed stage: website translation catalog (website/locales/ko/messages.po) only.
Contribution scope fit and linked maintainer decision: translation correction; not applicable.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable.
Generated metadata, package, or installation impact: none; no generated files committed.
Documentation or usability only; no target interaction.

Evidence and regression coverage

Tests added or updated: none (translation only).
Base reproduction or other evidence: built the site at 877d404 and compared /ko/faq/ before and after in a browser. The page title, skip link, contents label, heading and questions now read as intended.
User-visible CLI/MCP output: not applicable.
Remaining proof gaps: the existing tests can't judge Korean wording; it was reviewed by a native speaker.

Validation performed

Linux x64, Python 3.13, base 877d404:

python3 scripts/website.py translations check --language ko: 1594/1594 translated, 0 missing or fuzzy
python3 scripts/website.py check: passed (12 tests)
git diff --check: clean
The diff is 32 changed msgstr lines. The catalog was saved with polib 1.2.0, which round-trips the rest of the file byte-for-byte.

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable.
Package or release metadata impact: none.
Security, privacy, process, or containment review: not applicable.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3276 **Author:** [@hachi-008](https://github.com/hachi-008) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/ko-website-faq` --- ### 📝 Commits (1) - [`481c0d6`](https://github.com/morluto/rea/commit/481c0d6f90d3aec0e7cfc4950153666c29cc0c7b) fix(website): correct Korean FAQ translations ### 📊 Changes **1 file changed** (+32 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `website/locales/ko/messages.po` (+32 -32) </details> ### 📄 Description ## Summary Several strings on the Korean FAQ page (`/ko/faq/`) still come straight from the machine-assisted draft, and some change the meaning. The skip link reads "개인정보보호정책" ("Privacy policy"), and most questions have broken word order. This rewrites the 32 affected `page:faq/index.html` entries in `website/locales/ko/messages.po`. No issue: the translation guide invites language review of the first drafts. A few examples, with rough back-translations: | English source | Current Korean (back-translated) | New Korean | | --- | --- | --- | | Skip to content | 개인정보보호정책 ("Privacy policy") | 본문으로 건너뛰기 | | Does REA upload my app? | 않습니다 REA 내 앱을 업로드 하시겠습니까? ("Does not. Would you upload REA my app?") | REA가 내 앱을 업로드하나요? | | Which coding agents can use REA? | 어떤 코딩 에이전트가 사용할 수 있습니까 REA? ("Which coding agent can use, REA?") | 어떤 코딩 에이전트에서 REA를 사용할 수 있나요? | | Copy scoped setup command | 범위 설정 복사 명령 ("range setting copy command") | 특정 클라이언트 설정 명령 복사 | ## Problem and expected behavior Korean readers see questions they have to decode, and screen-reader users hear "Privacy policy" for the skip link. Expected: natural Korean that keeps the meaning and every placeholder. ## Change and scope - 32 of the 78 FAQ entries: page title and headings (7), questions (9), answer lines (4), terminal labels (6) and copy-button labels (6). - Wording follows `docs/readme/README_ko.md`, which Korean contributors already reviewed (#1047, #3046). FAQ questions that also appear there use the same phrasing. - Placeholders, product names and commands are unchanged. The other 46 FAQ entries already read fine and are left alone. Not included: other pages. The skip link has the same mistranslation on all 18 Korean pages; the other 17 are fixed in a separate PR. Ordinary translation fix within existing boundaries; scope decision not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: website translation catalog (`website/locales/ko/messages.po`) only. - Contribution scope fit and linked maintainer decision: translation correction; not applicable. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable. - Generated metadata, package, or installation impact: none; no generated files committed. - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage - Tests added or updated: none (translation only). - Base reproduction or other evidence: built the site at 877d404 and compared `/ko/faq/` before and after in a browser. The page title, skip link, contents label, heading and questions now read as intended. - User-visible CLI/MCP output: not applicable. - Remaining proof gaps: the existing tests can't judge Korean wording; it was reviewed by a native speaker. ## Validation performed Linux x64, Python 3.13, base 877d404: - `python3 scripts/website.py translations check --language ko`: 1594/1594 translated, 0 missing or fuzzy - `python3 scripts/website.py check`: passed (12 tests) - `git diff --check`: clean - The diff is 32 changed `msgstr` lines. The catalog was saved with polib 1.2.0, which round-trips the rest of the file byte-for-byte. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable. - Package or release metadata impact: none. - Security, privacy, process, or containment review: not applicable. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:42 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5691

No description provided.

Rows
Columns