morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #4239] [MERGED] fix(javascript): accept empty semantic property seeds #6143

New issue

Closed

opened 2026-10-31 01:12:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4239
Author: @Abdooo2235
Created: 10/15/2026
Status: ✅ Merged
Merged: 10/16/2026
Merged by: @morluto

Base: main ← Head: fix/semantic-empty-property-seed

📝 Commits (1)

6e1b7b6 fix(javascript): accept empty semantic property seeds

📊 Changes

2 files changed (+77 additions, -2 deletions)

View changed files

📝 src/domain/javascript/javascriptSemanticQuerySchemas.ts (+1 -1)
📝 tests/boundary/javascriptSemanticTraceEvidence.test.ts (+76 -1)

📄 Description

Summary

Fixes #4228. Semantic property-name queries now accept the legal empty-string name already retained by JavaScript analysis. The shared seed schema no longer imposes a minimum length on property names; other seed constraints remain unchanged. Exact matching and the echoed result schema use the same identity.

Validation

The new CLI/MCP regression failed before the fix (1 failed, 2 passed). After the fix, the boundary parity, semantic graph producer and query suites passed 87/87 tests. npm run check, docs:check (including 5 README tests), and git diff --check passed on Windows with Node 24.18.0/npm 11.16.0. Independent source review found no actionable issue. The parity case checks empty and named properties against exact-node selection, absent-name results, partial coverage and the advertised MCP output schema.

Scope and limitations

Static retained-Evidence queries only; no target execution or dependency changes. Tests use the existing CLI and SDK MCP boundary harness, not a real browser or external provider. No new capabilities or maintainer scope decision are required.

Author readiness

Human owner: @Abdooo2235

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4239 **Author:** [@Abdooo2235](https://github.com/Abdooo2235) **Created:** 10/15/2026 **Status:** ✅ Merged **Merged:** 10/16/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/semantic-empty-property-seed` --- ### 📝 Commits (1) - [`6e1b7b6`](https://github.com/morluto/rea/commit/6e1b7b627f1950a459e4b35682feab495a12a520) fix(javascript): accept empty semantic property seeds ### 📊 Changes **2 files changed** (+77 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptSemanticQuerySchemas.ts` (+1 -1) 📝 `tests/boundary/javascriptSemanticTraceEvidence.test.ts` (+76 -1) </details> ### 📄 Description ## Summary Fixes #4228. Semantic property-name queries now accept the legal empty-string name already retained by JavaScript analysis. The shared seed schema no longer imposes a minimum length on property names; other seed constraints remain unchanged. Exact matching and the echoed result schema use the same identity. ## Validation The new CLI/MCP regression failed before the fix (1 failed, 2 passed). After the fix, the boundary parity, semantic graph producer and query suites passed 87/87 tests. npm run check, docs:check (including 5 README tests), and git diff --check passed on Windows with Node 24.18.0/npm 11.16.0. Independent source review found no actionable issue. The parity case checks empty and named properties against exact-node selection, absent-name results, partial coverage and the advertised MCP output schema. ## Scope and limitations Static retained-Evidence queries only; no target execution or dependency changes. Tests use the existing CLI and SDK MCP boundary harness, not a real browser or external provider. No new capabilities or maintainer scope decision are required. ## Author readiness Human owner: @Abdooo2235 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:12:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:45:48 +00:00

[PR #6143] [MERGED] fix(cancellation): preserve caller abort reasons through late finalization #7158

bsakaguchi referenced this issue

2026-11-01 21:48:07 +00:00

[PR #6960] [CLOSED] fix(cancellation): preserve the caller abort reason at remaining checkpoints #7475

bsakaguchi changed title from ~~[PR #4239] [MERGED] fix(javascript): accept empty semantic property seeds~~ to [PR #4239] fix(javascript): accept empty semantic property seeds

2026-11-03 13:31:59 +00:00

bsakaguchi changed title from ~~[PR #4239] fix(javascript): accept empty semantic property seeds~~ to [PR #4239] [MERGED] fix(javascript): accept empty semantic property seeds

2026-11-03 14:33:42 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6143

No description provided.

Rows
Columns