morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #6143] [MERGED] fix(cancellation): preserve caller abort reasons through late finalization #7158

New issue

Closed

opened 2026-11-01 21:45:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:45:48 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6143
Author: @agorevski
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto

Base: main ← Head: fix/cancel-late-cleanup

📝 Commits (4)

6c4e287 fix(cancellation): preserve caller abort reasons through late finalization
68162fe fix(cancellation): keep caller reasons through export rollback and commit
f9e77ab fix(cancellation): bind export cancellations to cleanup and caller reasons
9241033 fix(merge): reconcile cancellation cleanup with command deadlines

📊 Changes

21 files changed (+611 additions, -61 deletions)

View changed files

📝 src/adb/AdbProvider.ts (+6 -4)
📝 src/application/WebScriptExportService.ts (+32 -2)
📝 src/application/binary/BinarySession.ts (+10 -0)
📝 src/application/javascript/JavaScriptRecoveryService.test.ts (+26 -0)
📝 src/application/javascript/JavaScriptRecoveryService.ts (+8 -4)
📝 src/application/native/NativeValueTrace.test.ts (+19 -0)
📝 src/application/native/NativeValueTrace.ts (+6 -0)
📝 src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts (+48 -1)
📝 src/artifacts/apple/AppleAssetCatalogAnalysis.ts (+1 -0)
📝 src/browser/CdpObservationSession.ts (+8 -0)
📝 src/browser/assets/PublishWebScripts.ts (+22 -5)
📝 src/cli/reverseEngineeringCommands.ts (+22 -5)
📝 src/cli/webScriptCommands.ts (+42 -38)
📝 src/hopper/HopperRegexSearch.test.ts (+42 -1)
📝 src/hopper/HopperRegexSearch.ts (+4 -0)
📝 tests/boundary/browser/cdpObservationWindowScope.test.ts (+21 -0)
📝 tests/boundary/cli/reverseEngineeringCommands.test.ts (+14 -0)
📝 tests/boundary/cli/webScriptSelectionCli.test.ts (+46 -1)
📝 tests/boundary/filesystem/webScriptExport.test.ts (+189 -0)
📝 tests/boundary/providers/adb/adbBugreportPublication.test.ts (+21 -0)

...and 1 more files

📄 Description

Summary

Fixes #6042
Fixes #6043
Fixes #6048
Fixes #6049
Fixes #6057
Fixes #6060
Fixes #6078
Fixes #6080
Fixes #6108
Fixes #6111
Fixes #6115

When a caller aborts during final provider, cleanup, or protocol handling, several shared workflows and CLI handlers returned success, a cleanup-derived error, or an I/O error instead of cancellation. The expected contract is AnalysisCancelledError carrying the exact signal.reason, with completed partial Evidence or cleanup state retained. This PR makes each affected path sample the caller signal after its owner has settled.

Problem and expected behavior

Smallest triggers and violated invariants, one per issue:

#6042: abort inside the first output write surfaced the internal ArtifactReaderFailure as the cancellation cause instead of the caller reason.
#6043: a capture close that failed once and then succeeded on retry dropped a cancellation recorded during the close.
#6048: native value tracing returned ok and recorded Evidence when the signal aborted just before the final provider reply was consumed.
#6049: Hopper regex search returned ok when the signal aborted during the matching worker's termination await.
#6057: assetutil cancellation settled before the helper process exited, because stopSignal was not supplied.
#6060: an armed observe_web_session waited out its full window after a fatal CDP protocol failure.
#6078: a staging-removal failure after cancellation produced AnalysisOutputError instead of cancellation.
#6080: JavaScript recovery returned success after the caller aborted during final handle closure.
#6108: export-web-scripts ignored SIGINT, so a real interrupt left partial output without a structured result.
#6111: inspect-with-objdump and execute-rizin-command returned successful Evidence when SIGINT arrived during cleanup retry.
#6115: binary-switch cancellation was lost when retiring the previous client failed after abort.

Change and scope

Each fix is placed in the owning stage rather than at the CLI:

Web script export (WebScriptExportService.ts): mapExportFailure uses the exact signal.reason when the caught failure wraps it; readCapture consults regularFileCancellation for a successful retried close.
Native value tracing and Hopper regex search: a post-await signal check before ok.
Apple asset catalog: stopSignal: "SIGTERM" is passed to execFileOutput, matching its documented settle-after-exit contract.
CDP observation (CdpObservationSession.ts): waitForWindow also subscribes to connection.onProtocolFailure and rejects with the protocol error, releasing timers and listeners.
ADB bugreport (AdbProvider.ts): staging-removal failure prefers AnalysisCancelledError when the caller aborted.
JavaScript recovery: uses the shared completeProviderEvidence helper, the same completion check other providers use.
CLI (webScriptCommands.ts, reverseEngineeringCommands.ts): export-web-scripts runs under withCommandCancellation and passes the signal into the workflow; objdump and Rizin wrap their cleanup with the same late-cancellation rule as finishAnalysisCommand.ts.
Binary session (BinarySession.ts): a failed previous-client retirement after abort returns cancellation as the primary with the cleanup failure attached and the owner still pending.

Intentionally not included: no change to the shared ExecFileOutput settlement contract, no other execFileOutput call sites, no ADB success-path change (the shared service already converts a successful removal to cancellation), and no change to the existing CLI completion check in finishAnalysisCommand.ts.

Contribution scope: ordinary fixes within existing boundaries. No new provider or capability, and no change to target execution, injection, mutation, or protection handling. Not applicable.

Contract and boundary impact

Semantic owner and earliest changed stage: each owning workflow or provider (listed above); the CLI change is limited to forwarding the signal and projecting the already-typed cancellation.
Contribution scope fit and linked maintainer decision: not applicable (bug fixes within existing boundaries).
CLI and MCP/tool-catalog contract: export-web-scripts now exits 130 with code: cancelled on SIGINT; objdump and Rizin return code: cancelled when interrupted during cleanup. No schema or catalog change.
Provider, bridge, target-format, or platform compatibility: no change for successful runs. Asset catalog cancellation now waits for the assetutil child to exit; native assetutil signal behavior was not exercised.
Evidence, artifact, provenance, or reconstruction contract: late-cancelled results carry the completed Evidence as partialObservation; no successful Evidence is changed.
Target selection, authority, upstream behavior, and cleanup details: binary-session cleanup ownership is unchanged; the owner remains pending when retirement fails.
Generated metadata (docs/public/product-catalog.json), package, or installation impact: none.

Expected effects:

Read existing files or captured data. (Web script export reads the caller-selected capture, as before.)
Launch or attach to a process. (Existing asset catalog, Hopper, and objdump/Rizin paths are touched; no new launches are added.)
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated: one regression per issue in existing test files: tests/boundary/filesystem/webScriptExport.test.ts (#6042, #6043), src/application/native/NativeValueTrace.test.ts (#6048), src/hopper/HopperRegexSearch.test.ts (#6049), src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts (#6057), tests/boundary/browser/cdpObservationWindowScope.test.ts (#6060), tests/boundary/providers/adb/adbBugreportPublication.test.ts (#6078), src/application/javascript/JavaScriptRecoveryService.test.ts (#6080), tests/boundary/cli/webScriptSelectionCli.test.ts (#6108), tests/boundary/cli/reverseEngineeringCommands.test.ts (#6111), tests/composition/analysis-sessions/binarySessionCleanupRetry.test.ts (#6115).
Base reproduction or other evidence: with the ten fixed source files temporarily restored to origin/main (01788bac8) and the new tests kept, all 11 new tests failed, each on the asserted defect: wrong or missing cause, cancelled absent, 10,012 ms versus a 5,000 ms bound (#6060), and exited marker absent when cancellation settled (#6057). The fixed files were then restored and re-verified. This was a per-file revert of shared files, not per-hunk isolation; #6042 and #6043 share WebScriptExportService.ts.
User-visible CLI/MCP output (if applicable): not captured as transcripts. The export-web-scripts and objdump/Rizin results are covered by boundary tests that invoke the registered CLI handlers with a spied workflow or a simulated owned result; no real SIGINT was delivered to a built binary in this PR.
Remaining proof gaps: real Ghidra, IDA, Hopper, Frida, and browser (Chromium/Electron) providers were not run; the CDP peer is a simulated fake; assetutil was replaced by a Node subprocess; no real SIGINT was delivered to the built export-web-scripts CLI; the full test suite was not run.

For evidence-bearing changes:

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Merge-conflict resolution at 924103383 against main (4e2816662): preserves both late-cancellation handling and caller-selected command deadlines in the Rizin CLI handler.

npm run test:focused selecting the ten original regression files plus tests/process-global/assetCatalogCancellationReason.test.ts and tests/boundary/cli/cliInputSchemaRequired.test.ts — exit 0, 12 files, 143 tests passed; runtime build completed successfully.
npm run check — exit 0 (typecheck, lint, formatting, Knip, metadata, module boundaries, architecture guards).
Pre-push npm run check:fast — exit 0.
Full suite and real-provider workflows were not run for this merge resolution.

Review follow-up at f9e77abfd (earlier bullets describe 68162fe07 and 6c4e287e6):

npm run test:focused -- tests/boundary/filesystem/webScriptExport.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/cli/webScriptSelectionCli.test.ts — exit 0, 3 files, 51 tests passed. Adds a regression for a caller-owned AnalysisCancelledError reason.
node scripts/run-typescript.mjs --noEmit — exit 0.
npx oxlint on the changed files — 0 errors.
Not run: the full suite.

Earlier follow-up at 68162fe07:

npm run test:focused -- tests/boundary/filesystem/webScriptExport.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/cli/webScriptSelectionCli.test.ts — exit 0, 3 files, 50 tests passed. Adds regressions for rollback failure after an interrupted write and for abort during final commit.
node scripts/run-typescript.mjs --noEmit — exit 0.
npx oxlint on the changed files — 0 errors; style warnings only.
npx oxfmt on the changed files — formatted.
Not run: the full suite.

Run in rea-worktrees/cancel-late-cleanup at commit 6c4e287e6 on base 01788bac8:

npm run build:cached — 3 of 3 tasks successful (exit code not captured). Two CLI and worker-dependent tests failed before this build and passed after it.
npx vitest run tests/boundary/filesystem/webScriptExport.test.ts src/application/native/NativeValueTrace.test.ts src/hopper/HopperRegexSearch.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/browser/cdpObservationWindowScope.test.ts tests/boundary/providers/adb/adbBugreportPublication.test.ts src/application/javascript/JavaScriptRecoveryService.test.ts tests/boundary/cli/webScriptSelectionCli.test.ts tests/boundary/cli/reverseEngineeringCommands.test.ts tests/composition/analysis-sessions/binarySessionCleanupRetry.test.ts — exit 0, 10 files and 130 tests passed.
Same vitest command with the fixed sources restored to origin/main — 10 of 10 files failed (exit code not captured); all 11 new tests failed on the asserted defect (see Evidence section).
npm run typecheck — exit 0.
npx oxlint on the 20 changed files — exit 0; warnings only, in six touched source files (AdbProvider 30, BinarySession 11, CdpObservationSession 3, NativeValueTrace 2, reverseEngineeringCommands 2, JavaScriptRecoveryService 1). Each file's count is identical to its HEAD~1 version.
npx oxfmt --check on the 20 changed files — exit 0, all matched files formatted.
git commit pre-commit hook — passed.

Not run: the full suite (npm run check:pr), real-provider workflows, and platform-specific tests.

Compatibility, safety, and release

Breaking changes or migration steps: none. Behavior change: late-cancelled commands now report cancelled (exit 130) instead of success or a cleanup error.
Real Hopper/Ghidra, browser, or OS coverage: none; see Remaining proof gaps.
Package or release metadata impact: none.
Security, privacy, process, or containment review: no new process, network, or file access; asset catalog children now receive SIGTERM on cancellation and are awaited before settlement.

Author readiness

Human owner: @agorevski

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6143 **Author:** [@agorevski](https://github.com/agorevski) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/cancel-late-cleanup` --- ### 📝 Commits (4) - [`6c4e287`](https://github.com/morluto/rea/commit/6c4e287e663b479938c2fafb7382ff09d722a88e) fix(cancellation): preserve caller abort reasons through late finalization - [`68162fe`](https://github.com/morluto/rea/commit/68162fe07f3511fa54cf202149987a9f03478919) fix(cancellation): keep caller reasons through export rollback and commit - [`f9e77ab`](https://github.com/morluto/rea/commit/f9e77abfdde065ccd7781a22ca439693df2394f5) fix(cancellation): bind export cancellations to cleanup and caller reasons - [`9241033`](https://github.com/morluto/rea/commit/924103383ebbf64351a2cf527bf4e6036015f751) fix(merge): reconcile cancellation cleanup with command deadlines ### 📊 Changes **21 files changed** (+611 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `src/adb/AdbProvider.ts` (+6 -4) 📝 `src/application/WebScriptExportService.ts` (+32 -2) 📝 `src/application/binary/BinarySession.ts` (+10 -0) 📝 `src/application/javascript/JavaScriptRecoveryService.test.ts` (+26 -0) 📝 `src/application/javascript/JavaScriptRecoveryService.ts` (+8 -4) 📝 `src/application/native/NativeValueTrace.test.ts` (+19 -0) 📝 `src/application/native/NativeValueTrace.ts` (+6 -0) 📝 `src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts` (+48 -1) 📝 `src/artifacts/apple/AppleAssetCatalogAnalysis.ts` (+1 -0) 📝 `src/browser/CdpObservationSession.ts` (+8 -0) 📝 `src/browser/assets/PublishWebScripts.ts` (+22 -5) 📝 `src/cli/reverseEngineeringCommands.ts` (+22 -5) 📝 `src/cli/webScriptCommands.ts` (+42 -38) 📝 `src/hopper/HopperRegexSearch.test.ts` (+42 -1) 📝 `src/hopper/HopperRegexSearch.ts` (+4 -0) 📝 `tests/boundary/browser/cdpObservationWindowScope.test.ts` (+21 -0) 📝 `tests/boundary/cli/reverseEngineeringCommands.test.ts` (+14 -0) 📝 `tests/boundary/cli/webScriptSelectionCli.test.ts` (+46 -1) 📝 `tests/boundary/filesystem/webScriptExport.test.ts` (+189 -0) 📝 `tests/boundary/providers/adb/adbBugreportPublication.test.ts` (+21 -0) _...and 1 more files_ </details> ### 📄 Description  ## Summary Fixes #6042 Fixes #6043 Fixes #6048 Fixes #6049 Fixes #6057 Fixes #6060 Fixes #6078 Fixes #6080 Fixes #6108 Fixes #6111 Fixes #6115 When a caller aborts during final provider, cleanup, or protocol handling, several shared workflows and CLI handlers returned success, a cleanup-derived error, or an I/O error instead of cancellation. The expected contract is `AnalysisCancelledError` carrying the exact `signal.reason`, with completed partial Evidence or cleanup state retained. This PR makes each affected path sample the caller signal after its owner has settled. ## Problem and expected behavior Smallest triggers and violated invariants, one per issue: - #6042: abort inside the first output write surfaced the internal `ArtifactReaderFailure` as the cancellation cause instead of the caller reason. - #6043: a capture close that failed once and then succeeded on retry dropped a cancellation recorded during the close. - #6048: native value tracing returned `ok` and recorded Evidence when the signal aborted just before the final provider reply was consumed. - #6049: Hopper regex search returned `ok` when the signal aborted during the matching worker's termination await. - #6057: `assetutil` cancellation settled before the helper process exited, because `stopSignal` was not supplied. - #6060: an armed `observe_web_session` waited out its full window after a fatal CDP protocol failure. - #6078: a staging-removal failure after cancellation produced `AnalysisOutputError` instead of cancellation. - #6080: JavaScript recovery returned success after the caller aborted during final handle closure. - #6108: `export-web-scripts` ignored SIGINT, so a real interrupt left partial output without a structured result. - #6111: `inspect-with-objdump` and `execute-rizin-command` returned successful Evidence when SIGINT arrived during cleanup retry. - #6115: binary-switch cancellation was lost when retiring the previous client failed after abort. ## Change and scope Each fix is placed in the owning stage rather than at the CLI: - Web script export (`WebScriptExportService.ts`): `mapExportFailure` uses the exact `signal.reason` when the caught failure wraps it; `readCapture` consults `regularFileCancellation` for a successful retried close. - Native value tracing and Hopper regex search: a post-await signal check before `ok`. - Apple asset catalog: `stopSignal: "SIGTERM"` is passed to `execFileOutput`, matching its documented settle-after-exit contract. - CDP observation (`CdpObservationSession.ts`): `waitForWindow` also subscribes to `connection.onProtocolFailure` and rejects with the protocol error, releasing timers and listeners. - ADB bugreport (`AdbProvider.ts`): staging-removal failure prefers `AnalysisCancelledError` when the caller aborted. - JavaScript recovery: uses the shared `completeProviderEvidence` helper, the same completion check other providers use. - CLI (`webScriptCommands.ts`, `reverseEngineeringCommands.ts`): `export-web-scripts` runs under `withCommandCancellation` and passes the signal into the workflow; objdump and Rizin wrap their cleanup with the same late-cancellation rule as `finishAnalysisCommand.ts`. - Binary session (`BinarySession.ts`): a failed previous-client retirement after abort returns cancellation as the primary with the cleanup failure attached and the owner still pending. Intentionally not included: no change to the shared `ExecFileOutput` settlement contract, no other `execFileOutput` call sites, no ADB success-path change (the shared service already converts a successful removal to cancellation), and no change to the existing CLI completion check in `finishAnalysisCommand.ts`. Contribution scope: ordinary fixes within existing boundaries. No new provider or capability, and no change to target execution, injection, mutation, or protection handling. Not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: each owning workflow or provider (listed above); the CLI change is limited to forwarding the signal and projecting the already-typed cancellation. - Contribution scope fit and linked maintainer decision: not applicable (bug fixes within existing boundaries). - CLI and MCP/tool-catalog contract: `export-web-scripts` now exits 130 with `code: cancelled` on SIGINT; objdump and Rizin return `code: cancelled` when interrupted during cleanup. No schema or catalog change. - Provider, bridge, target-format, or platform compatibility: no change for successful runs. Asset catalog cancellation now waits for the `assetutil` child to exit; native `assetutil` signal behavior was not exercised. - Evidence, artifact, provenance, or reconstruction contract: late-cancelled results carry the completed Evidence as `partialObservation`; no successful Evidence is changed. - Target selection, authority, upstream behavior, and cleanup details: binary-session cleanup ownership is unchanged; the owner remains pending when retirement fails. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact: none. Expected effects: - [x] Read existing files or captured data. (Web script export reads the caller-selected capture, as before.) - [x] Launch or attach to a process. (Existing asset catalog, Hopper, and objdump/Rizin paths are touched; no new launches are added.) - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: one regression per issue in existing test files: `tests/boundary/filesystem/webScriptExport.test.ts` (#6042, #6043), `src/application/native/NativeValueTrace.test.ts` (#6048), `src/hopper/HopperRegexSearch.test.ts` (#6049), `src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts` (#6057), `tests/boundary/browser/cdpObservationWindowScope.test.ts` (#6060), `tests/boundary/providers/adb/adbBugreportPublication.test.ts` (#6078), `src/application/javascript/JavaScriptRecoveryService.test.ts` (#6080), `tests/boundary/cli/webScriptSelectionCli.test.ts` (#6108), `tests/boundary/cli/reverseEngineeringCommands.test.ts` (#6111), `tests/composition/analysis-sessions/binarySessionCleanupRetry.test.ts` (#6115). - Base reproduction or other evidence: with the ten fixed source files temporarily restored to `origin/main` (01788bac8) and the new tests kept, all 11 new tests failed, each on the asserted defect: wrong or missing cause, `cancelled` absent, 10,012 ms versus a 5,000 ms bound (#6060), and `exited` marker absent when cancellation settled (#6057). The fixed files were then restored and re-verified. This was a per-file revert of shared files, not per-hunk isolation; #6042 and #6043 share `WebScriptExportService.ts`. - User-visible CLI/MCP output (if applicable): not captured as transcripts. The `export-web-scripts` and objdump/Rizin results are covered by boundary tests that invoke the registered CLI handlers with a spied workflow or a simulated owned result; no real SIGINT was delivered to a built binary in this PR. - Remaining proof gaps: real Ghidra, IDA, Hopper, Frida, and browser (Chromium/Electron) providers were not run; the CDP peer is a simulated fake; `assetutil` was replaced by a Node subprocess; no real SIGINT was delivered to the built `export-web-scripts` CLI; the full test suite was not run. For evidence-bearing changes: - [ ] Observed, derived, and inferred claims remain distinguishable. - [ ] Artifact identity, source provenance, and failed attempts remain preserved. - [ ] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Merge-conflict resolution at `924103383` against `main` (`4e2816662`): preserves both late-cancellation handling and caller-selected command deadlines in the Rizin CLI handler. - `npm run test:focused` selecting the ten original regression files plus `tests/process-global/assetCatalogCancellationReason.test.ts` and `tests/boundary/cli/cliInputSchemaRequired.test.ts` — exit 0, 12 files, 143 tests passed; runtime build completed successfully. - `npm run check` — exit 0 (typecheck, lint, formatting, Knip, metadata, module boundaries, architecture guards). - Pre-push `npm run check:fast` — exit 0. - Full suite and real-provider workflows were not run for this merge resolution. Review follow-up at `f9e77abfd` (earlier bullets describe `68162fe07` and `6c4e287e6`): - `npm run test:focused -- tests/boundary/filesystem/webScriptExport.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/cli/webScriptSelectionCli.test.ts` — exit 0, 3 files, 51 tests passed. Adds a regression for a caller-owned AnalysisCancelledError reason. - `node scripts/run-typescript.mjs --noEmit` — exit 0. - `npx oxlint` on the changed files — 0 errors. - Not run: the full suite. Earlier follow-up at `68162fe07`: - `npm run test:focused -- tests/boundary/filesystem/webScriptExport.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/cli/webScriptSelectionCli.test.ts` — exit 0, 3 files, 50 tests passed. Adds regressions for rollback failure after an interrupted write and for abort during final commit. - `node scripts/run-typescript.mjs --noEmit` — exit 0. - `npx oxlint` on the changed files — 0 errors; style warnings only. - `npx oxfmt` on the changed files — formatted. - Not run: the full suite. Run in `rea-worktrees/cancel-late-cleanup` at commit `6c4e287e6` on base `01788bac8`: - `npm run build:cached` — 3 of 3 tasks successful (exit code not captured). Two CLI and worker-dependent tests failed before this build and passed after it. - `npx vitest run tests/boundary/filesystem/webScriptExport.test.ts src/application/native/NativeValueTrace.test.ts src/hopper/HopperRegexSearch.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/browser/cdpObservationWindowScope.test.ts tests/boundary/providers/adb/adbBugreportPublication.test.ts src/application/javascript/JavaScriptRecoveryService.test.ts tests/boundary/cli/webScriptSelectionCli.test.ts tests/boundary/cli/reverseEngineeringCommands.test.ts tests/composition/analysis-sessions/binarySessionCleanupRetry.test.ts` — exit 0, 10 files and 130 tests passed. - Same vitest command with the fixed sources restored to `origin/main` — 10 of 10 files failed (exit code not captured); all 11 new tests failed on the asserted defect (see Evidence section). - `npm run typecheck` — exit 0. - `npx oxlint` on the 20 changed files — exit 0; warnings only, in six touched source files (AdbProvider 30, BinarySession 11, CdpObservationSession 3, NativeValueTrace 2, reverseEngineeringCommands 2, JavaScriptRecoveryService 1). Each file's count is identical to its `HEAD~1` version. - `npx oxfmt --check` on the 20 changed files — exit 0, all matched files formatted. - `git commit` pre-commit hook — passed. Not run: the full suite (`npm run check:pr`), real-provider workflows, and platform-specific tests. ## Compatibility, safety, and release - Breaking changes or migration steps: none. Behavior change: late-cancelled commands now report `cancelled` (exit 130) instead of success or a cleanup error. - Real Hopper/Ghidra, browser, or OS coverage: none; see Remaining proof gaps. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no new process, network, or file access; asset catalog children now receive SIGTERM on cancellation and are awaited before settlement. ## Author readiness  Human owner: @agorevski  - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge  - [x] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:45:48 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-03 13:39:38 +00:00

[PR #7158] [CLOSED] fix(doctor): classify unreadable skill identity as unknown #7683

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7158

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns