[PR #4408] [CLOSED] fix(enhanced): validate get_objc_protocols direct-call input #6219

New issue

Closed

opened 2026-10-31 01:12:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4408
Author: @Franklin-Qi
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: fix/4383-objc-protocols-strict-input

📝 Commits (1)

9ab5d3a fix(enhanced): validate get_objc_protocols direct-call input

📊 Changes

2 files changed (+48 additions, -2 deletions)

View changed files

➕ src/application/EnhancedTools.directInput.test.ts (+42 -0)
📝 src/application/EnhancedTools.ts (+6 -2)

📄 Description

Summary

Direct get_objc_protocols discarded undeclared properties by substituting {}, so callers got success and the provider ran. Parse with the canonical strict schema like adjacent operations.

Closes: #4383

Validation performed

Issue repro at the EnhancedTools direct-call boundary: extra properties now return AnalysisInputError without a provider call; empty input still succeeds.
npm run test:focused -- src/application/EnhancedTools.directInput.test.ts
npm run check:fast

Author readiness declarations are left for the human owner to complete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4408 **Author:** [@Franklin-Qi](https://github.com/Franklin-Qi) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/4383-objc-protocols-strict-input` --- ### 📝 Commits (1) - [`9ab5d3a`](https://github.com/morluto/rea/commit/9ab5d3a5b46a76a3cc59a35eb2b7b49f4e7e33e1) fix(enhanced): validate get_objc_protocols direct-call input ### 📊 Changes **2 files changed** (+48 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `src/application/EnhancedTools.directInput.test.ts` (+42 -0) 📝 `src/application/EnhancedTools.ts` (+6 -2) </details> ### 📄 Description ## Summary Direct `get_objc_protocols` discarded undeclared properties by substituting `{}`, so callers got success and the provider ran. Parse with the canonical strict schema like adjacent operations. Closes: #4383 ## Validation performed - Issue repro at the EnhancedTools direct-call boundary: extra properties now return AnalysisInputError without a provider call; empty input still succeeds. - `npm run test:focused -- src/application/EnhancedTools.directInput.test.ts` - `npm run check:fast` Author readiness declarations are left for the human owner to complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:12:47 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:46:09 +00:00

[PR #6219] [MERGED] feat(native): inspect a universal Mach-O slice in Go and Rust metadata readers #7206

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6219

No description provided.

Rows
Columns