mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6219] [MERGED] feat(native): inspect a universal Mach-O slice in Go and Rust metadata readers #7206
Closed
opened 2026-11-01 21:46:09 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7206
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6219
Author: @kaoru0822-kitauji
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:feat/universal-slice-go-rust📝 Commits (2)
00f1e97feat(native): inspect a universal Mach-O slice in Go and Rust metadata readers51c281ffix(native): reject damaged universal files and self-contradicting slice reports📊 Changes
19 files changed (+902 additions, -35 deletions)
View changed files
📝
.agents/skills/reverse-engineer-anything/references/native-and-artifacts.md(+4 -2)📝
docs/go-binaries.md(+15 -5)📝
docs/rust-binaries.md(+12 -3)📝
src/application/go/GoBinaryService.ts(+2 -1)📝
src/application/rust/RustBinaryService.ts(+4 -2)📝
src/cli/goCommands.ts(+18 -3)📝
src/cli/rustCommands.ts(+22 -2)📝
src/contracts/go/goToolContracts.ts(+1 -1)📝
src/contracts/rust/rustToolContracts.ts(+1 -1)📝
src/domain/analysisView/goBinaryView.ts(+6 -2)📝
src/domain/analysisView/rustBinaryView.ts(+6 -1)📝
src/domain/apple/machoTargetSelection.ts(+56 -7)📝
src/domain/go/goBinary.ts(+44 -0)📝
src/domain/rust/rustBinary.ts(+51 -0)📝
src/go/GoBinaryProvider.ts(+33 -3)➕
src/native/metadata/MachoSliceSelection.ts(+149 -0)📝
src/rust/RustBinaryProvider.ts(+43 -2)➕
tests/boundary/mcp/universalSliceMcp.test.ts(+373 -0)➕
tests/fixtures/universalMacho.ts(+62 -0)📄 Description
Summary
Fixes #4102 (option 1 in the issue).
Before: a universal input failed with
unsupported_target: Universal/fat Mach-O containers require selecting a thin slice, and the tools had no parameter to select one. After:architecture: "arm64"(CLI--architecture arm64) inspects that slice directly, and provenance stays tied to the universal file.Problem and expected behavior
Many macOS releases ship only universal binaries. The issue's example was the GitHub CLI's universal pkg; here I used Tor Browser's
lyrebirdand Cursor'scursor-tunnel. REA already parses FAT tables structurally (readFatContainerHeader,classifyFatContainerIdentity), but these two inspectors only refused. Expected: select a slice by CPU family, record its offset, size and CPU, keep the parent identity, and list the available architectures when the selection is missing or wrong.Change and scope
src/native/metadata/MachoSliceSelection.tsis the single selector. It parses the FAT table, confirms the slices are Mach-O (JVM class files sharing the magic still pass through to the image reader), and matches the requested CPU family. It then validates the slice's range and alignment, and checks that the slice's own Mach-O header CPU type/subtype agrees with the table. The result is the thin bytes, their file offset, and amacho-selected-image-v1identity. The identity reuses the existing provider-neutral schema, includingcontainer_table_sha256computed over header plus table as the Hopper path does. Failures are a typedResult:architectureissues (missing, absent, several matches, or given for a non-universal file) versusmalformedcontainers.header_offset,version_location,module_location; Rust.dep-v0file_offsetand rustc-path hash offsets.artifactstays the universal file (SHA-256, size). Schemas add optionalselected_slicewith a refinement that every reported range lies inside the slice. It is optional so previously retained Evidence still parses ininspect_analysis_view.architectureisx86 | x86_64 | arm | arm64, REA'sBinaryArchitecturenames. They now live once inmachoTargetSelection.ts(MACHO_CPU_TYPES), which the existingmachoTargetSelectionMatchesArchitecturealso uses.mach-o-universal. The services and the retained Go/Rust views each re-derivedformat === "macho" ? "mach-o" : format, and the views rejected the new value. That mapping now has one owner (metadataReportSubjectFormat), used by all four.detail: "summary") carryselected_slice.selectImage(binary_architecture: arm64 | amd64, its own public failure codes) could move onto this selector, but that changes its public vocabulary and error codes, so it is left for a follow-up.extract_artifact'slipodependency (option 2 in the issue) is also unchanged.Contract and boundary impact
selectNativeImage(before any image parsing); subject format inmachoTargetSelection.ts.architectureinput on both tools (MCP + CLI--architecture); additive optionalselected_sliceoutput; universal inputs now fail asinvalid_requestonarchitectureinstead ofunsupported_target.lipo.format: mach-o-universalwith the slice'sarchitecture.Expected effects:
Evidence and regression coverage
tests/boundary/mcp/universalSliceMcp.test.ts, through the MCP server):artifactis the universal file,selected_sliceholds the exact offset/length/CPU and table digest, and ranges are file offsets that slice back togo1.26.1. Subject ismach-o-universal/arm64, parameters recordarchitecture, input and output are validated against the advertised JSON Schemas with Ajv, anddetail: "summary"for x86_64 carriesselected_slice.x86_64 (subtype 0x3), arm64 (subtype 0x0);architectureon a thin image; two arm64 slices (ambiguous); and a FAT entry whose CPU disagrees with the slice header (malformedpath)..dep-v0and rustc offsets shifted by the slice offset; a missing selection fails onarchitecture.pathwith the FAT reason, with or withoutarchitecture. Reports whoseselected_slicecontradicts their own format or CPU (amd64orelf) are rejected by the Go/Rust schemas through one sharedselectedSliceAgreesWithReportcheck. The CLI--architectureflag is described in help (cliOptionAliases).tests/fixtures/universalMacho.tsbuilds FAT32 fixtures from existing thin fixtures.origin/mainbuild:Baseline on universal input:
inspect-go-binary …/Tor Browser.app/…/lyrebirdandinspect-rust-binary …/Cursor.app/…/bin/cursor-tunnelboth returnunsupported_target … require selecting a thin slice.This PR with
--architecturevs baseline on thelipo -thin-extracted slice. Every field is identical except offsets, which are shifted by exactlyselected_slice.offset:lyrebird(Go 1.22.12, 32 MB)conjure-client(Go)cursor-tunnel(Rust)@vscode/ripgreprg(Rust)Cost: universal-with-selection 0.70–1.14 s wall, 0.93–1.07 s CPU, 354–361 MiB peak RSS (Go, 3 runs). The same branch on the 15 MB thin slice: 0.62 s, 0.94 s CPU, 327 MiB. The extra ~30 MiB is the 32 MB universal file read once; no slice copy is made (
subarray). Report size is unchanged apart from the ~10-byteselected_slice(17,370 vs 17,360 bytes); the summary is 4.2 KB..dep-v0data was available locally (both real Rust binaries carry only rustc paths), so the dependency-section shift is covered by the fixture test. Linux/Windows hosts were not run locally (CI).For evidence-bearing changes:
Validation performed
npm run test:focused -- tests/boundary/mcp/universalSliceMcp.test.ts tests/boundary/mcp/goBinaryMcp.test.ts tests/boundary/mcp/rustBinaryMcp.test.ts tests/boundary/mcp/goBinaryViews.test.ts tests/boundary/go/goBinaryImage.test.ts tests/boundary/rust/rustBinaryImage.test.ts tests/acceptance/goBinaryCli.test.ts tests/acceptance/rustBinaryCli.test.ts tests/acceptance/rustDependencyViews.test.ts src/application/go/GoBinaryService.test.ts src/application/rust/RustBinaryService.test.ts tests/boundary/providers/native/artifactProvider.machOSlices.test.ts tests/boundary/filesystem/binaryTarget.test.ts tests/boundary/mcp/absoluteLocalPathSchema.test.ts tests/process-global/stableArtifactConsumers.test.ts tests/boundary/cli/artifactInputLimits.test.ts— 16 files, 326 tests passed.npm run test:focused -- tests/boundary/mcp/universalSliceMcp.test.ts tests/boundary/cli/cliOptionAliases.test.ts tests/boundary/mcp/goBinaryMcp.test.ts tests/boundary/mcp/rustBinaryMcp.test.ts tests/boundary/mcp/goBinaryViews.test.ts tests/acceptance/rustDependencyViews.test.ts tests/boundary/go/goBinaryImage.test.ts tests/boundary/rust/rustBinaryImage.test.ts— 8 files, 141 tests passed.npm run check:fast— passed.npm run format:check— passed.npm run docs:check— passed.npm run build:cachedon both trees).Compatibility, safety, and release
architecturenow returnsinvalid_request(patharchitecture, slices listed) instead ofunsupported_target. That call never succeeded before, and the new error is the actionable one.Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.