morluto/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00
Code Issues 1.3k Projects Packages Wiki Activity

[PR #4466] [MERGED] feat(android): make the JADX operation deadline configurable #6259

New issue
Closed
opened 2026-10-31 01:13:05 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-31 01:13:05 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4466
Author: @SandstromPL
Created: 10/16/2026
Status: ✅ Merged
Merged: 10/16/2026
Merged by: @morluto

Base: main ← Head: feat/jadx-operation-timeout

📝 Commits (2)

  • 4f2c54b feat(android): make the JADX operation deadline configurable
  • 6373f60 test(android): isolate JADX fixtures from inherited shell settings

📊 Changes

12 files changed (+356 additions, -14 deletions)

View changed files

📝 .agents/skills/reverse-engineer-anything/references/android-applications.md (+3 -1)
📝 docs/android-analysis.md (+19 -2)
📝 docs/client-configuration.md (+7 -1)
📝 src/android/JadxConfiguration.ts (+44 -0)
📝 src/android/JadxDoctor.ts (+8 -0)
📝 src/android/JadxProvider.ts (+15 -5)
📝 src/android/JadxRelease.ts (+6 -0)
📝 src/android/JadxSession.ts (+7 -3)
📝 tests/boundary/android/jadxConfiguration.test.ts (+42 -0)
📝 tests/boundary/android/jadxDoctor.test.ts (+49 -0)
📝 tests/boundary/process/jadxIntegration.test.ts (+147 -1)
📝 tests/fixtures/android/jadx.ts (+9 -1)

📄 Description

Summary

Fixes #3918.

JADX operations had two fixed 120-second limits:

  • the provider's whole-operation deadline (OPERATION_TIMEOUT_MS in JadxProvider.ts)
  • a separate per-call bound on every upstream MCP call (timeout: 120_000 in JadxSession.ts)

A large multidex APK whose cold load exceeds 120 s therefore always ended in provider_timeout, and raising only the MCP client's timeout could not extend either limit.

This PR adds an optional setting, REA_JADX_OPERATION_TIMEOUT_MS. It is a decimal millisecond count from 1 to 2147483647, and the default stays 120000. One parsed value bounds both the whole operation and each upstream call. Unset keeps today's behavior.

Problem and expected behavior

  • What the reporter saw: on rea-agents 6.4.0 (macOS arm64, Temurin 21), the operation hit provider_timeout at exactly timeout_ms: 120000 on a large multidex APK. A rea_jvm_status reply was retained, but the load never completed.
  • What wasn't reproduced: no redistributable APK exists, so this was not reproduced, and it is not a confirmed OOM.
  • Expected, per the issue: a caller can select a longer finite deadline, with provider and session deadlines coordinated and the effective value reported. The default, explicit cancellation, bounded output, partial observations and verified owned-process cleanup must be preserved.

Change and scope

  • Parsing (src/android/JadxConfiguration.ts): readOperationTimeout parses the setting once, reusing providerStartupTimeoutSchema. The error text matches REA_KUNA_TIMEOUT_MS.
    • Invalid values get the new failure kind operation_timeout, classified config_drift.
    • The remediation text and DEFAULT_JADX_OPERATION_TIMEOUT_MS live in JadxRelease.ts.
  • Provider (src/android/JadxProvider.ts): #execute resolves the deadline as a Result before acquiring any file handle, workspace or engine.
    • The value feeds AbortSignal.timeout and both AnalysisTimeoutError sites.
    • It is passed to JadxSession.execute. The deadline still starts at the queue front.
    • The fixed constant is removed.
  • Session (src/android/JadxSession.ts): every callTool uses the selected value instead of 120_000.
    • The bound stays explicit; omitting it would fall back to the SDK's 60 s default.
    • Because the provider's timer starts earlier with the same length, it always fires first, so a timeout is still classified as AnalysisTimeoutError.
  • Doctor and setup:
    • inspectJadxAvailability reports operation_timeout_ms, and the passing JADX doctor check exposes it in details.
    • JadxDoctor publishes an explicit value in registrationEnvironment, like REA_JADX_HEAP_MIB, so rea setup forwards it.
  • Docs: docs/android-analysis.md, docs/client-configuration.md, and the skill reference references/android-applications.md.

Contribution scope: a configuration option for an existing read-only static provider, so a maintainer scope decision is not applicable.

Intentionally not included:

  • Counting the deadline in setup's client tool timeout. The derived Codex tool_timeout_sec and Kimi toolTimeoutMs (mcpStartupPolicy.ts, doctorRuntime.ts resolveProviderRequestBudget) don't count this setting. This matches REA_KUNA_TIMEOUT_MS and REA_KUNA_PROJECT_TIMEOUT_MS, which are also forwarded without counting. Including it would mean restructuring a seam that currently runs only for ida/auto, so I've documented the gap in client-configuration.md and android-analysis.md instead. I'm happy to do it as a follow-up.
  • A timeout remediation that names the setting. AnalysisTimeoutError presentation still says "Try a smaller request". Changing that needs a shared error-presentation change, so it's deferred.
  • Changes to the bridge's 30 s startup handshake or the upstream 90 s decompilation limit. Raising the deadline extends neither. At the audited upstream revision the 90 s value wraps only per-class/method decompilation, not load_apk (source-derived).
  • A per-call MCP/CLI argument. There is no tool-schema change.

Contract and boundary impact

  • Semantic owner and earliest changed stage: src/android/JadxConfiguration.ts, at provider configuration before target admission.
  • Contribution scope fit and linked maintainer decision: within the existing JADX provider boundary, with no new authority; not applicable.
  • CLI and MCP/tool-catalog contract:
    • No tool or schema change.
    • provider_timeout details.timeout_ms now reports the selected value.
    • An invalid value returns capability_unavailable (open_options_invalid) before Java starts.
    • The JADX doctor configuration check gains details.operation_timeout_ms (additive).
  • Provider, bridge, target-format, or platform compatibility: the bridge and jadx-headless-mcp 0.7.1 are unchanged. Behavior on real JADX is not verified (see Evidence).
  • Evidence, artifact, provenance, or reconstruction contract: unchanged. Partial observations and cleanup on timeout are asserted by the new tests.
  • Target selection, authority, upstream behavior, and cleanup details:
    • Cancellation precedence is unchanged.
    • The deadline path releases the owned process group and workspace before provider shutdown (asserted).
    • An invalid value fails before any handle, workspace, probe or launch.
  • Generated metadata, package, or installation impact:
    • Only the authored skill reference text changes. generate-skill-metadata.mjs --check passes, and no skill version bump is needed.
    • No catalog change is expected, and skills/ is not committed.
    • The reviewed rea setup plan can now forward an explicitly set REA_JADX_OPERATION_TIMEOUT_MS into client registrations. The ambient environment is never persisted.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data. (existing JADX analysis behavior, unchanged)
  • Launch or attach to a process. (existing JADX engine launch; only its deadline is now selectable)
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration. (existing reviewed rea setup client registration may now include an explicitly set REA_JADX_OPERATION_TIMEOUT_MS, like REA_JADX_HEAP_MIB)
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated:

  • tests/boundary/process/jadxIntegration.test.ts, which uses the real owned-subprocess fake JADX MCP producer:
    • Queued deadline: two queued stalled inspect_android_package requests with REA_JADX_OPERATION_TIMEOUT_MS=1500. Each ends as AnalysisTimeoutError with timeoutMs: 1500 and its own engine launch (2 launches). Each keeps the rea_jvm_status partial observation and projects provider_timeout with details.timeout_ms: 1500. Ownership is released before provider.close().
    • Maximum value: a successful operation under 2147483647, so there is no 1 ms timer clamp.
    • Invalid values: "" and 2147483648 are refused with no Java probe and no launch.
    • Session boundary: each upstream call rejects with SdkErrorCode.RequestTimeout and data.timeout: 300 when timeoutMs: 300. This is a module-level test because the former fixed 120 s call limit is unreachable in a workflow test.
  • tests/boundary/android/jadxConfiguration.test.ts: effective operation_timeout_ms for unset (120000), 1, 900000 and 2147483647. The full invalid matrix ("", 0, -1, 1.5, 1e3, " 5", abc, 2147483648) returns open_options_invalid with failure_kind: operation_timeout.
  • tests/boundary/android/jadxDoctor.test.ts: the default and explicit details.operation_timeout_ms, the registration environment carrying the explicit value, and invalid-value remediation naming the setting.
  • tests/fixtures/android/jadx.ts: optional settings overrides. Since 6373f60d6 (review follow-up), the fixture no longer inherits REA_JADX_* settings from the developer's shell, so an exported deadline or heap value cannot change tests that never selected one.

Base reproduction: on base fe2a398dd with only src/android/ reverted, 8 of the new or changed tests fail. The two deadline tests fail by hitting vitest's 30 s timeout, because the setting was ignored and the fixed 120 s limits applied. The other 67 pass, including the largest-deadline success control, which is expected because the base ignores the setting.

Example output:

  • Timeout projection: {"code":"provider_timeout","details":{"operation":"inspect_android_package","timeout_ms":1500}}
  • Invalid value: REA_JADX_OPERATION_TIMEOUT_MS must be a decimal millisecond count from 1 to 2147483647; received abc.

Remaining proof gaps:

  • No full JDK or real jadx-headless-mcp run, so there is no evidence that a longer deadline lets the reporter's APK finish loading. The real cold-load cost was not measured.
  • Windows and macOS were not run; these integration tests skip on win32.
  • Client-side tool timeouts in Codex, Kimi and Claude were not exercised.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Run on Linux with Node 24.18.0 and npm 11.16.0:

  • npm run test:focused -- on the 3 JADX test files plus 13 related Android, doctor, capability and module-boundary test files (16 files listed below): 16 files, 268 tests passed.
    • Files: tests/boundary/process/jadxIntegration.test.ts, tests/boundary/android/jadxConfiguration.test.ts, tests/boundary/android/jadxDoctor.test.ts, src/application/CapabilityInventory.test.ts, src/doctorRuntime.test.ts, tests/acceptance/nonBinaryComposition.test.ts, tests/boundary/android/JadxAnalysis.test.ts, tests/boundary/android/jadxMcpTransport.test.ts, tests/boundary/android/jadxProtocol.test.ts, tests/boundary/mcp/androidLateCompletionMcp.test.ts, tests/boundary/mcp/androidPackageSummaryMcp.test.ts, tests/boundary/process/androidAnalysisMcp.test.ts, tests/boundary/process/androidSearchEvidenceBudget.test.ts, tests/boundary/process/jadxHashCleanup.test.ts, tests/boundary/providers/android/androidLateCompletion.test.ts, tests/evaluation/moduleBoundaries.test.ts.
  • The same 3 JADX files with only src/android/ reverted to base: 8 failed, 67 passed (as described above).
  • npx tsc -p tsconfig.json --noEmit: clean.
  • npm run check: passed. Lint reports 0 errors, and the touched files have the same per-rule warning counts as base.
  • npm run docs:check: passed (includes the skill metadata and doc-facts checks).
  • npm run verify:test-discovery: discovered all 1417 test files exactly once.
  • npx oxfmt --check on the changed files: passed.
  • The checks above ran on 4f2c54ba6. After the test-only follow-up 6373f60d6:
    • With REA_JADX_OPERATION_TIMEOUT_MS=1 REA_JADX_HEAP_MIB=abc REA_JADX_ACTIVE_PROCESSOR_COUNT=0 exported, npm run test:focused -- on the 7 fixture-based Android boundary files passed 63/63. Before the fix, jadxIntegration.test.ts alone had 38 failures under the same exports.
    • In a clean shell, 9 Android test files passed 95/95. npx tsc -p tsconfig.json --noEmit was clean, and npm run check:fast passed.
  • Not run:
    • npm run check:pr
    • npm run verify:package (downloads skills@1.7.2; CI runs it)
    • npm run verify:android (needs a full JDK and downloaded public fixtures)

Compatibility, safety, and release

  • Breaking changes or migration steps: none. Unset keeps the 120000 ms default and identical behavior. The only new failure is an invalid value of the new variable.
  • Real Hopper/Ghidra, browser, or OS coverage: Linux only, with the synthetic JADX producer. No real JDK or JADX.
  • Package or release metadata impact: skill reference text only.
  • Security, privacy, process, or containment review:
    • The value is non-secret and appears in errors and diagnostics, like REA_JADX_HEAP_MIB.
    • A longer deadline lets a stalled engine run longer, but it is still finite, explicitly selected, cancellable, and cleaned up with verified ownership.
    • Performance: one string parse per operation or inspection on the default path; not measured.

Author readiness

Human owner: @SandstromPL

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4466 **Author:** [@SandstromPL](https://github.com/SandstromPL) **Created:** 10/16/2026 **Status:** ✅ Merged **Merged:** 10/16/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `feat/jadx-operation-timeout` --- ### 📝 Commits (2) - [`4f2c54b`](https://github.com/morluto/rea/commit/4f2c54ba60cf4cff0ecdcaeb12279ec16031e7da) feat(android): make the JADX operation deadline configurable - [`6373f60`](https://github.com/morluto/rea/commit/6373f60d6e6c7bc96986110b6aaaa82a2df190ef) test(android): isolate JADX fixtures from inherited shell settings ### 📊 Changes **12 files changed** (+356 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/reverse-engineer-anything/references/android-applications.md` (+3 -1) 📝 `docs/android-analysis.md` (+19 -2) 📝 `docs/client-configuration.md` (+7 -1) 📝 `src/android/JadxConfiguration.ts` (+44 -0) 📝 `src/android/JadxDoctor.ts` (+8 -0) 📝 `src/android/JadxProvider.ts` (+15 -5) 📝 `src/android/JadxRelease.ts` (+6 -0) 📝 `src/android/JadxSession.ts` (+7 -3) 📝 `tests/boundary/android/jadxConfiguration.test.ts` (+42 -0) 📝 `tests/boundary/android/jadxDoctor.test.ts` (+49 -0) 📝 `tests/boundary/process/jadxIntegration.test.ts` (+147 -1) 📝 `tests/fixtures/android/jadx.ts` (+9 -1) </details> ### 📄 Description ## Summary Fixes #3918. JADX operations had two fixed 120-second limits: - the provider's whole-operation deadline (`OPERATION_TIMEOUT_MS` in `JadxProvider.ts`) - a separate per-call bound on every upstream MCP call (`timeout: 120_000` in `JadxSession.ts`) A large multidex APK whose cold load exceeds 120 s therefore always ended in `provider_timeout`, and raising only the MCP client's timeout could not extend either limit. This PR adds an optional setting, `REA_JADX_OPERATION_TIMEOUT_MS`. It is a decimal millisecond count from 1 to 2147483647, and the default stays 120000. One parsed value bounds both the whole operation and each upstream call. Unset keeps today's behavior. ## Problem and expected behavior - **What the reporter saw:** on rea-agents 6.4.0 (macOS arm64, Temurin 21), the operation hit `provider_timeout` at exactly `timeout_ms: 120000` on a large multidex APK. A `rea_jvm_status` reply was retained, but the load never completed. - **What wasn't reproduced:** no redistributable APK exists, so this was not reproduced, and it is not a confirmed OOM. - **Expected, per the issue:** a caller can select a longer finite deadline, with provider and session deadlines coordinated and the effective value reported. The default, explicit cancellation, bounded output, partial observations and verified owned-process cleanup must be preserved. ## Change and scope - **Parsing** (`src/android/JadxConfiguration.ts`): `readOperationTimeout` parses the setting once, reusing `providerStartupTimeoutSchema`. The error text matches `REA_KUNA_TIMEOUT_MS`. - Invalid values get the new failure kind `operation_timeout`, classified `config_drift`. - The remediation text and `DEFAULT_JADX_OPERATION_TIMEOUT_MS` live in `JadxRelease.ts`. - **Provider** (`src/android/JadxProvider.ts`): `#execute` resolves the deadline as a `Result` before acquiring any file handle, workspace or engine. - The value feeds `AbortSignal.timeout` and both `AnalysisTimeoutError` sites. - It is passed to `JadxSession.execute`. The deadline still starts at the queue front. - The fixed constant is removed. - **Session** (`src/android/JadxSession.ts`): every `callTool` uses the selected value instead of `120_000`. - The bound stays explicit; omitting it would fall back to the SDK's 60 s default. - Because the provider's timer starts earlier with the same length, it always fires first, so a timeout is still classified as `AnalysisTimeoutError`. - **Doctor and setup:** - `inspectJadxAvailability` reports `operation_timeout_ms`, and the passing JADX doctor check exposes it in `details`. - `JadxDoctor` publishes an explicit value in `registrationEnvironment`, like `REA_JADX_HEAP_MIB`, so `rea setup` forwards it. - **Docs:** `docs/android-analysis.md`, `docs/client-configuration.md`, and the skill reference `references/android-applications.md`. Contribution scope: a configuration option for an existing read-only static provider, so a maintainer scope decision is not applicable. **Intentionally not included:** - **Counting the deadline in setup's client tool timeout.** The derived Codex `tool_timeout_sec` and Kimi `toolTimeoutMs` (`mcpStartupPolicy.ts`, `doctorRuntime.ts` `resolveProviderRequestBudget`) don't count this setting. This matches `REA_KUNA_TIMEOUT_MS` and `REA_KUNA_PROJECT_TIMEOUT_MS`, which are also forwarded without counting. Including it would mean restructuring a seam that currently runs only for `ida`/`auto`, so I've documented the gap in `client-configuration.md` and `android-analysis.md` instead. I'm happy to do it as a follow-up. - **A timeout remediation that names the setting.** `AnalysisTimeoutError` presentation still says "Try a smaller request". Changing that needs a shared error-presentation change, so it's deferred. - **Changes to the bridge's 30 s startup handshake or the upstream 90 s decompilation limit.** Raising the deadline extends neither. At the audited upstream revision the 90 s value wraps only per-class/method decompilation, not `load_apk` (source-derived). - **A per-call MCP/CLI argument.** There is no tool-schema change. ## Contract and boundary impact - **Semantic owner and earliest changed stage:** `src/android/JadxConfiguration.ts`, at provider configuration before target admission. - **Contribution scope fit and linked maintainer decision:** within the existing JADX provider boundary, with no new authority; not applicable. - **CLI and MCP/tool-catalog contract:** - No tool or schema change. - `provider_timeout` `details.timeout_ms` now reports the selected value. - An invalid value returns `capability_unavailable` (`open_options_invalid`) before Java starts. - The JADX doctor configuration check gains `details.operation_timeout_ms` (additive). - **Provider, bridge, target-format, or platform compatibility:** the bridge and jadx-headless-mcp 0.7.1 are unchanged. Behavior on real JADX is not verified (see Evidence). - **Evidence, artifact, provenance, or reconstruction contract:** unchanged. Partial observations and cleanup on timeout are asserted by the new tests. - **Target selection, authority, upstream behavior, and cleanup details:** - Cancellation precedence is unchanged. - The deadline path releases the owned process group and workspace before provider shutdown (asserted). - An invalid value fails before any handle, workspace, probe or launch. - **Generated metadata, package, or installation impact:** - Only the authored skill reference text changes. `generate-skill-metadata.mjs --check` passes, and no skill version bump is needed. - No catalog change is expected, and `skills/` is not committed. - The reviewed `rea setup` plan can now forward an explicitly set `REA_JADX_OPERATION_TIMEOUT_MS` into client registrations. The ambient environment is never persisted. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [x] Read existing files or captured data. (existing JADX analysis behavior, unchanged) - [x] Launch or attach to a process. (existing JADX engine launch; only its deadline is now selectable) - [ ] Inject instrumentation or run scripts/code. - [x] Change process memory, registers, files, or configuration. (existing reviewed `rea setup` client registration may now include an explicitly set `REA_JADX_OPERATION_TIMEOUT_MS`, like `REA_JADX_HEAP_MIB`) - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage **Tests added or updated:** - `tests/boundary/process/jadxIntegration.test.ts`, which uses the real owned-subprocess fake JADX MCP producer: - **Queued deadline:** two queued stalled `inspect_android_package` requests with `REA_JADX_OPERATION_TIMEOUT_MS=1500`. Each ends as `AnalysisTimeoutError` with `timeoutMs: 1500` and its own engine launch (2 launches). Each keeps the `rea_jvm_status` partial observation and projects `provider_timeout` with `details.timeout_ms: 1500`. Ownership is released before `provider.close()`. - **Maximum value:** a successful operation under `2147483647`, so there is no 1 ms timer clamp. - **Invalid values:** `""` and `2147483648` are refused with no Java probe and no launch. - **Session boundary:** each upstream call rejects with `SdkErrorCode.RequestTimeout` and `data.timeout: 300` when `timeoutMs: 300`. This is a module-level test because the former fixed 120 s call limit is unreachable in a workflow test. - `tests/boundary/android/jadxConfiguration.test.ts`: effective `operation_timeout_ms` for unset (120000), `1`, `900000` and `2147483647`. The full invalid matrix (`""`, `0`, `-1`, `1.5`, `1e3`, `" 5"`, `abc`, `2147483648`) returns `open_options_invalid` with `failure_kind: operation_timeout`. - `tests/boundary/android/jadxDoctor.test.ts`: the default and explicit `details.operation_timeout_ms`, the registration environment carrying the explicit value, and invalid-value remediation naming the setting. - `tests/fixtures/android/jadx.ts`: optional settings overrides. Since 6373f60d6 (review follow-up), the fixture no longer inherits `REA_JADX_*` settings from the developer's shell, so an exported deadline or heap value cannot change tests that never selected one. **Base reproduction:** on base `fe2a398dd` with only `src/android/` reverted, 8 of the new or changed tests fail. The two deadline tests fail by hitting vitest's 30 s timeout, because the setting was ignored and the fixed 120 s limits applied. The other 67 pass, including the largest-deadline success control, which is expected because the base ignores the setting. **Example output:** - Timeout projection: `{"code":"provider_timeout","details":{"operation":"inspect_android_package","timeout_ms":1500}}` - Invalid value: `REA_JADX_OPERATION_TIMEOUT_MS must be a decimal millisecond count from 1 to 2147483647; received abc.` **Remaining proof gaps:** - No full JDK or real jadx-headless-mcp run, so there is no evidence that a longer deadline lets the reporter's APK finish loading. The real cold-load cost was not measured. - Windows and macOS were not run; these integration tests skip on win32. - Client-side tool timeouts in Codex, Kimi and Claude were not exercised. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Run on Linux with Node 24.18.0 and npm 11.16.0: - `npm run test:focused --` on the 3 JADX test files plus 13 related Android, doctor, capability and module-boundary test files (16 files listed below): 16 files, 268 tests passed. - Files: `tests/boundary/process/jadxIntegration.test.ts`, `tests/boundary/android/jadxConfiguration.test.ts`, `tests/boundary/android/jadxDoctor.test.ts`, `src/application/CapabilityInventory.test.ts`, `src/doctorRuntime.test.ts`, `tests/acceptance/nonBinaryComposition.test.ts`, `tests/boundary/android/JadxAnalysis.test.ts`, `tests/boundary/android/jadxMcpTransport.test.ts`, `tests/boundary/android/jadxProtocol.test.ts`, `tests/boundary/mcp/androidLateCompletionMcp.test.ts`, `tests/boundary/mcp/androidPackageSummaryMcp.test.ts`, `tests/boundary/process/androidAnalysisMcp.test.ts`, `tests/boundary/process/androidSearchEvidenceBudget.test.ts`, `tests/boundary/process/jadxHashCleanup.test.ts`, `tests/boundary/providers/android/androidLateCompletion.test.ts`, `tests/evaluation/moduleBoundaries.test.ts`. - The same 3 JADX files with only `src/android/` reverted to base: 8 failed, 67 passed (as described above). - `npx tsc -p tsconfig.json --noEmit`: clean. - `npm run check`: passed. Lint reports 0 errors, and the touched files have the same per-rule warning counts as base. - `npm run docs:check`: passed (includes the skill metadata and doc-facts checks). - `npm run verify:test-discovery`: discovered all 1417 test files exactly once. - `npx oxfmt --check` on the changed files: passed. - The checks above ran on 4f2c54ba6. After the test-only follow-up 6373f60d6: - With `REA_JADX_OPERATION_TIMEOUT_MS=1 REA_JADX_HEAP_MIB=abc REA_JADX_ACTIVE_PROCESSOR_COUNT=0` exported, `npm run test:focused --` on the 7 fixture-based Android boundary files passed 63/63. Before the fix, `jadxIntegration.test.ts` alone had 38 failures under the same exports. - In a clean shell, 9 Android test files passed 95/95. `npx tsc -p tsconfig.json --noEmit` was clean, and `npm run check:fast` passed. - **Not run:** - `npm run check:pr` - `npm run verify:package` (downloads `skills@1.7.2`; CI runs it) - `npm run verify:android` (needs a full JDK and downloaded public fixtures) ## Compatibility, safety, and release - **Breaking changes or migration steps:** none. Unset keeps the 120000 ms default and identical behavior. The only new failure is an invalid value of the new variable. - **Real Hopper/Ghidra, browser, or OS coverage:** Linux only, with the synthetic JADX producer. No real JDK or JADX. - **Package or release metadata impact:** skill reference text only. - **Security, privacy, process, or containment review:** - The value is non-secret and appears in errors and diagnostics, like `REA_JADX_HEAP_MIB`. - A longer deadline lets a stalled engine run longer, but it is still finite, explicitly selected, cancellable, and cleaned up with verified ownership. - Performance: one string parse per operation or inspection on the default path; not measured. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @SandstromPL - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 01:13:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels   
area: bridge

   
area: bridge

   
area: build

   
area: build

   
area: build

   
area: cli

   
area: domain

   
area: evidence

   
area: mcp

   
area: native

   
area: providers

   
area: runtime

   
area: server

   
area: setup

   
area: tests

   
bug

   
design

   
documentation

   
enhancement

   
enhancement

   
enhancement

   
experiment

   
help wanted

   
i18n

   
invalid

   
P0: critical

   
P1: high

   
P2: medium

   
P2: medium

   
P2: medium

   
P3: low

   
performance

   
provider-request

   
pull-request
Mirrored from GitHub Pull Request

  
question

   
roadmap

   
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6259
No description provided.