mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6259] [MERGED] fix(javascript): keep encoded URL slashes inside one runtime path segment #7234
Closed
opened 2026-11-01 21:46:21 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7234
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6259
Author: @kaoru0822-kitauji
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:fix/5878-url-prefix-encoded-slash📝 Commits (1)
b9129b1fix(javascript): keep encoded URL slashes inside one runtime path segment📊 Changes
4 files changed (+407 additions, -54 deletions)
View changed files
📝
docs/javascript-runtime-reconciliation.md(+7 -1)📝
src/domain/javascript/javascriptRuntimeLoadState.ts(+7 -6)📝
src/domain/javascript/javascriptRuntimeStaticCandidates.ts(+114 -47)➕
tests/boundary/cli/runtimeUrlPrefixMappingCli.test.ts(+279 -0)📄 Description
What broke: A
url-prefixruntime mapping decoded%2Finto a path separator.reconcile-javascript-runtimethen matched the script URL…/assets/child%2Fpart.jsto the static filechild/part.jswith medium confidence and emitted an inferredobserved_asedge.Fix: The mapping now decodes each URL path segment on its own. A segment that decodes to contain
/(or has malformed or non-UTF-8 escapes) has no artifact path, so the script staysunknown/no-authorized-location-mapping. Static nodes beneath that mapping's prefix also stayunknownin load state instead of becomingnot-observed-in-capture.Risk: Low. The change only affects HTTP(S) script and worker URLs whose path below the prefix contains
%2F/%2f. Ordinary paths, encoded spaces, Unicode,%25(%252F→ literalchild%2Fpart.js) and the existing%5Cliteral-backslash contract match as before.Summary
Fixes #5878.
Before this change,
pathBelowUrlPrefixcalleddecodeURIComponenton the whole pathname suffix. The encoded slash inchild%2Fpart.js, which is a byte inside one URL segment, became an artifact directory separator. Now an encoded slash stays inside its segment. That location has no artifact path under the prefix-only mapping, so REA returns the existing uncertain outcome and noobserved_asedge. It does not add a new status.Problem and expected behavior
Smallest trigger: one application layer with
child/part.js(and optionally a literalchild%2Fpart.js), aurl-prefixmappinghttps://app.example.test/assets/→"", and a source-free browser script athttps://app.example.test/assets/child%2Fpart.js. The violated invariant is that a prefix-only mapping translates URL path segments to artifact path segments, so it must not invent hierarchy from bytes inside one segment. The static resolvers already reject encoded separators (admitsCanonicalPathSyntax,javascriptSourceMapPaths). This was the one runtime mapping path that decoded them unguarded.Change and scope
src/domain/javascript/javascriptRuntimeStaticCandidates.ts(the owner of runtime-location → artifact-path translation):translateRuntimeLocationis now the single place that relates one runtime location to one mapping. It returnsoutside,untranslatableortranslated.mappedRuntimePaths(matching) and the load-state scope both use it. Before, each consumer repeated its ownfile-root/url-prefixdispatch.pathBelowUrlPrefixdecodes segment by segment (decodeUrlPathSegments). A URL beneath the prefix whose suffix cannot be translated isuntranslatable, notoutside. A URL equal to the prefix (for example the page itself) staysoutside, as before.StaticRuntimeScoperecordsuntranslatedArtifactPrefixes, but only for script and worker entities, since only those can correspond to load-state nodes.staticNodeRuntimeScopereturnsoutside | within | uncertain.src/domain/javascript/javascriptRuntimeLoadState.ts:uncertainnodes stayunknown/static-or-runtime-coverage-incomplete. Without this, the fix would swap a falseloadedfor a falsenot-observed-in-capturewhenever another script under the same prefix made the capture complete. Many static servers servechild/part.jsforchild%2Fpart.js, so absence there is unproven.docs/javascript-runtime-reconciliation.md: documents segment-wise decoding,%5Cas a literal name byte, and the load-state consequence.file-rootmappings are unchanged, because they compare native paths and do not decode. #5872 (Electronfile:target admission) is a separate defect. Percent-encoding case equivalence between the prefix and the URL (%2fvs%2Finside the prefix itself) is unchanged.Contribution scope: not applicable. This is an ordinary fix within existing boundaries.
Contract and boundary impact
Semantic owner and earliest changed stage:
javascriptRuntimeStaticCandidates.tsURL-prefix translation, during reconciliation matching and load-state scoping.Contribution scope fit and linked maintainer decision: not applicable (ordinary fix).
CLI and MCP/tool-catalog contract: no schema change. For affected URLs,
reconciliations[]items change frommatchedtounknown/no-authorized-location-mapping, there is noobserved_asedge, andstatic_load_statesfor nodes beneath that prefix becomeunknown/static-or-runtime-coverage-incomplete.Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: the runtime URL and static paths are preserved unchanged. Only the inferred cross-layer correspondence is withheld.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata, package, or installation impact: none.
Read existing files or captured data.
Evidence and regression coverage
Tests added:
tests/boundary/cli/runtimeUrlPrefixMappingCli.test.ts, which runs the built public CLI (node scripts/rea.mjs reconcile-javascript-runtime … --json) on real directory analysis and synthetic browser Evidence:child/part.jsandchild/part.js?v=%2F#f%2F→ matchedchild/part.js.child%2Fpart.jsandchild%2fpart.js→unknown/no-authorized-location-mapping, 0observed_as.child%252Fpart.js→ matched literalchild%2Fpart.js.sp%20ace.js→sp ace.js.%C3%A9.js→é.js.child/%E0.js→ unknown.other.jsonly) giveschild/part.js=not-observed-in-capture. Addingchild%2Fpart.jsgiveschild/part.js=unknown/static-or-runtime-coverage-incomplete, andother.jsstaysloaded.%5Cliteral-backslash and%2e%2eescape case injavascriptRuntimeReconciliation.test.tsis unchanged and passes.Base reproduction: the issue's focused test, run on base
c537c52c9with the built CLI, printed the issue's three rows exactly, including{"suffix":"child%2Fpart.js","status":"matched",…,"paths":["child/part.js"],"observed_as":1}. After the fix it stops at that row. Withsrc/reverted and rebuilt, both new tests fail. With the fix, both pass.User-visible CLI output: the affected script item is now
{"status":"unknown","basis":"none","reason":"no-authorized-location-mapping"}with noobserved_asedge.Remaining proof gaps: no live browser or Electron runtime was used, and runtime Evidence is synthetic. Worker entities share the same code path, but no worker case was exercised. MCP shares the same application service, but it was not run separately for this case.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
All on base
c537c52c9, macOS arm64, Node 24.18.0:%2Frow no longer matches with the fix.vitest run tests/boundary/cli/runtimeUrlPrefixMappingCli.test.ts: 2/2 passed with the fix; 2/2 failed withsrc/reverted.cdpScriptMetadata,electronCli,jsonInputStatus,runtimeUrlPrefixMappingCli,javascriptRuntimeContentPriority,javascriptRuntimeReconciliation,javascriptApplicationWorkflows,javascriptRuntimeObservation,javascriptRuntimeUnresolvedTarget,javascriptSelectedPathEvidence,browserMcp,electronMcp,javascriptRuntimeReconciliationAmbiguity): 174 passed, 1 failed. The failure isjavascriptRuntimeObservation.test.ts > includes targets outside the old caller root filter. It also fails locally with this PR'ssrc/changes reverted, so it is not caused by this change.npm run check:fast: passed.npm run format:check: passed.npm run docs:check: passed.Compatibility, safety, and release
unknowninstead of an inferred match).Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.