[PR #4550] [CLOSED] fix(ghidra): preserve Allegrex inspection descriptor ownership and primary failures #6303

New issue

Closed

opened 2026-10-31 01:13:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-10-31 01:13:25 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4550
Author: @Swatantra-66
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: fix/psp-extension-descriptor-ownership

---

📝 Commits (1)

• 893a3ad fix(ghidra): preserve Allegrex inspection descriptor ownership and primary failures

📊 Changes

2 files changed (+499 additions, -57 deletions)

View changed files

➕ src/ghidra/GhidraPspExtension.test.ts (+378 -0)
📝 src/ghidra/GhidraPspExtension.ts (+121 -57)

📄 Description

Summary

Preserves descriptor ownership and primary read failure provenance during Ghidra Allegrex extension fingerprinting and analysis profile resolution.

Fixes #4521.

Problem and expected behavior

Prior to this change:

1. inspectGhidraPspExtension read and hashed each installed extension component using a raw file descriptor inside finally { await handle.close(); }. If a read failed and handle.close() also rejected, the close failure masked the primary read error, and no descriptor owner was retained for caller retry.
2. resolveGhidraPspExtension replaced real capability failures with AnalysisCancelledError whenever signal?.aborted was truthy, discarding genuine producer errors if cancellation occurred concurrently with or following the failure.

Expected behavior:

• Scope file access through the canonical withOwnedRegularFile descriptor boundary.
• Retain the unclosed descriptor via retainFailedClose and preserve the primary read failure when close rejects (RegularFileCleanupFailure).
• Normalize cancellation at the producer boundary without masking genuine capability failures, attaching cleanup metadata when physical close fails.

Change and scope

• Migrated inspectGhidraPspExtension to withOwnedRegularFile with options { symlinks: "reject", signal, retainFailedClose }.
• Supported backward-compatible signalOrOptions?: AbortSignal | InspectGhidraPspExtensionOptions.
• In resolveGhidraPspExtension, added isPspExtensionCancellation helper checking only genuine cancellation causes (RegularFileCancelled, AnalysisCancelledError, AbortError, or cause === signal.reason).
• Extracted primary read failure from RegularFileCleanupFailure for the user message and attached typed { cleanup: { reason, resources } } metadata.
• Added comprehensive unit tests in src/ghidra/GhidraPspExtension.test.ts covering descriptor ownership, failure provenance, cleanup metadata, and descriptor release in test finally blocks.

Contract and boundary impact

• Semantic owner and earliest changed stage: inspectGhidraPspExtension / resolveGhidraPspExtension file inspection stage.
• Contribution scope fit and linked maintainer decision: ordinary fix within existing boundaries; not applicable.
• CLI and MCP/tool-catalog contract: none (internal Ghidra profile resolution).
• Provider, bridge, target-format, or platform compatibility: Ghidra Allegrex PSP extension on supported hosts.
• Evidence, artifact, provenance, or reconstruction contract: preserves exact physical read failure provenance and cleanup uncertainty.
• Target selection, authority, upstream behavior, and cleanup details (if applicable): none.
• Generated metadata impact: none.

Expected effects:

• Read existing files or captured data.
• Launch or attach to a process.
• Inject instrumentation or run scripts/code.
• Change process memory, registers, files, or configuration.
• Contact network services.
• Recover protected code or work around protections.
• Documentation or usability only; no target interaction.
• Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

• Tests added or updated: src/ghidra/GhidraPspExtension.test.ts (7 tests).
• Base reproduction or other evidence: simulated handle read error + close rejection throwing RegularFileCleanupFailure and calling retainFailedClose.
• User-visible CLI/MCP output (if applicable): user-facing message retains Corrupted component bytes rather than close error.
• Remaining proof gaps: real Linux x64 Ghidra provider host verification (tested cross-platform via unit tests).

For evidence-bearing changes:

• Observed, derived, and inferred claims remain distinguishable.
• Artifact identity, source provenance, and failed attempts remain preserved.
• Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

• npm run test:local -- src/ghidra/GhidraPspExtension.test.ts — 7/7 passed (143ms)
• npm run test:local -- src/ghidra/GhidraMipsProfile.test.ts — 64/64 passed (40ms)
• npm run check:fast — turbo typecheck & lint passed (0 errors)

Compatibility, safety, and release

• Breaking changes or migration steps: none; backward-compatible with caller passing AbortSignal directly.
• Real Hopper/Ghidra, browser, or OS coverage: local unit tests executed on Windows host; Linux Ghidra engine verified in CI.
• Package or release metadata impact: none.
• Security, privacy, process, or containment review: descriptors are guaranteed closed and unclosed owners retained for caller retry.

Author readiness

Human owner: @Swatantra-66

• I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
• I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
• I declare this PR ready for initial maintainer review.

Before merge

• This PR addresses a concrete problem or an agreed enhancement.
• Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked, or the reason for not linking one is stated above.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4550 **Author:** [@Swatantra-66](https://github.com/Swatantra-66) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/psp-extension-descriptor-ownership` --- ### 📝 Commits (1) - [`893a3ad`](https://github.com/morluto/rea/commit/893a3ad5e1022de75a9108ae19d0b0e218ac2d50) fix(ghidra): preserve Allegrex inspection descriptor ownership and primary failures ### 📊 Changes **2 files changed** (+499 additions, -57 deletions) <details> <summary>View changed files</summary> ➕ `src/ghidra/GhidraPspExtension.test.ts` (+378 -0) 📝 `src/ghidra/GhidraPspExtension.ts` (+121 -57) </details> ### 📄 Description ## Summary Preserves descriptor ownership and primary read failure provenance during Ghidra Allegrex extension fingerprinting and analysis profile resolution. Fixes #4521. ## Problem and expected behavior Prior to this change: 1. `inspectGhidraPspExtension` read and hashed each installed extension component using a raw file descriptor inside `finally { await handle.close(); }`. If a read failed and `handle.close()` also rejected, the close failure masked the primary read error, and no descriptor owner was retained for caller retry. 2. `resolveGhidraPspExtension` replaced real capability failures with `AnalysisCancelledError` whenever `signal?.aborted` was truthy, discarding genuine producer errors if cancellation occurred concurrently with or following the failure. Expected behavior: - Scope file access through the canonical `withOwnedRegularFile` descriptor boundary. - Retain the unclosed descriptor via `retainFailedClose` and preserve the primary read failure when close rejects (`RegularFileCleanupFailure`). - Normalize cancellation at the producer boundary without masking genuine capability failures, attaching cleanup metadata when physical close fails. ## Change and scope - Migrated `inspectGhidraPspExtension` to `withOwnedRegularFile` with options `{ symlinks: "reject", signal, retainFailedClose }`. - Supported backward-compatible `signalOrOptions?: AbortSignal | InspectGhidraPspExtensionOptions`. - In `resolveGhidraPspExtension`, added `isPspExtensionCancellation` helper checking only genuine cancellation causes (`RegularFileCancelled`, `AnalysisCancelledError`, `AbortError`, or `cause === signal.reason`). - Extracted primary read failure from `RegularFileCleanupFailure` for the user message and attached typed `{ cleanup: { reason, resources } }` metadata. - Added comprehensive unit tests in `src/ghidra/GhidraPspExtension.test.ts` covering descriptor ownership, failure provenance, cleanup metadata, and descriptor release in test finally blocks. ## Contract and boundary impact - Semantic owner and earliest changed stage: `inspectGhidraPspExtension` / `resolveGhidraPspExtension` file inspection stage. - Contribution scope fit and linked maintainer decision: ordinary fix within existing boundaries; not applicable. - CLI and MCP/tool-catalog contract: none (internal Ghidra profile resolution). - Provider, bridge, target-format, or platform compatibility: Ghidra Allegrex PSP extension on supported hosts. - Evidence, artifact, provenance, or reconstruction contract: preserves exact physical read failure provenance and cleanup uncertainty. - Target selection, authority, upstream behavior, and cleanup details (if applicable): none. - Generated metadata impact: none. Expected effects: - [x] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: `src/ghidra/GhidraPspExtension.test.ts` (7 tests). - Base reproduction or other evidence: simulated handle read error + close rejection throwing `RegularFileCleanupFailure` and calling `retainFailedClose`. - User-visible CLI/MCP output (if applicable): user-facing message retains `Corrupted component bytes` rather than close error. - Remaining proof gaps: real Linux x64 Ghidra provider host verification (tested cross-platform via unit tests). For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npm run test:local -- src/ghidra/GhidraPspExtension.test.ts` — 7/7 passed (143ms) - `npm run test:local -- src/ghidra/GhidraMipsProfile.test.ts` — 64/64 passed (40ms) - `npm run check:fast` — turbo typecheck & lint passed (0 errors) ## Compatibility, safety, and release - Breaking changes or migration steps: none; backward-compatible with caller passing `AbortSignal` directly. - Real Hopper/Ghidra, browser, or OS coverage: local unit tests executed on Windows host; Linux Ghidra engine verified in CI. - Package or release metadata impact: none. - Security, privacy, process, or containment review: descriptors are guaranteed closed and unclosed owners retained for caller retry. ## Author readiness Human owner: @Swatantra-66 - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. ## Before merge - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-10-31 01:13:25 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-01 21:11:07 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

bsakaguchi referenced this issue 2026-11-01 21:46:37 +00:00

[PR #6303] [CLOSED] fix(cli): advertise the observe-web-execution duration maximum #7269

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6303

No description provided.