[PR #6303] [CLOSED] fix(cli): advertise the observe-web-execution duration maximum #7269

New issue

Closed

opened 2026-11-01 21:46:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6303
Author: @hmm-1947
Created: 10/22/2026
Status: ❌ Closed

Base: main ← Head: fix/observe-web-execution-duration-maximum

📝 Commits (2)

23bd557 fix(cli): advertise the observe-web-execution duration maximum
da839bb test(cli): verify observe-web-execution --schema advertises the enforced maximum

📊 Changes

5 files changed (+108 additions, -7 deletions)

View changed files

📝 src/cli/webRuntimeCommands.ts (+6 -1)
➕ src/cliObservationOptions.test.ts (+58 -0)
📝 src/cliObservationOptions.ts (+8 -5)
📝 src/domain/webExecution.ts (+7 -1)
➕ tests/boundary/cli/observeWebExecutionSchema.test.ts (+29 -0)

📄 Description

Summary

Fixes #6290. observe-web-execution --schema advertised observationMs.maximum: 9007199254740991, but the shared input schema rejects values above 2147483647 with invalid_request. The command now advertises the limit it enforces.

Problem and expected behavior

A caller following input discovery could choose a value the command then refuses (for example 2147483648). Expected: the advertised range matches the enforced range, the boundary 2147483647 is still accepted, and the above-limit invalid_request refusal is unchanged.

Change and scope

observationDuration takes an optional maximum. observe-web-execution passes MAX_WEB_EXECUTION_OBSERVATION_MS, now exported from src/domain/webExecution.ts and used by observeWebExecutionInputSchema, so the CLI and domain limits share one constant. Other observationDuration callers are unchanged. No handler or provider behavior changes.

Contribution scope: ordinary fix within existing boundaries; not applicable.

Contract and boundary impact

Semantic owner and earliest changed stage: CLI option registration (src/cli/webRuntimeCommands.ts), advertised schema only
Contribution scope fit and linked maintainer decision: not applicable
CLI and MCP/tool-catalog contract: observe-web-execution --schema now reports observationMs.maximum 2147483647; MCP unchanged
Provider, bridge, target-format, or platform compatibility: none
Evidence, artifact, provenance, or reconstruction contract: none
Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable
Generated metadata, package, or installation impact: unknown; no generated catalog edits made

Expected effects:

Documentation or usability only; no target interaction.

Evidence and regression coverage

Source-derived and executed locally.

Tests added or updated: tests/boundary/cli/observeWebExecutionSchema.test.ts (runs observe-web-execution --schema --json through the CLI and asserts observationMs.maximum is 2147483647), src/cliObservationOptions.test.ts (helper)
Base reproduction or other evidence: with the third argument removed from the command registration, the new CLI test fails with expected 9007199254740991 to be 2147483647
User-visible CLI/MCP output (if applicable): observationMs schema maximum changes from 9007199254740991 to 2147483647
Remaining proof gaps: the issue's end-to-end loopback boundary commands were not re-run; full npm run check not run

Validation performed

npx vitest run tests/boundary/cli/observeWebExecutionSchema.test.ts src/cliObservationOptions.test.ts tests/boundary/cli/cliInputSchemaRequired.test.ts — 3 files, 13 tests passed
npx tsc --noEmit -p tsconfig.json — no errors
npx oxlint on changed files — 0 errors; 1 existing unused-import warning in src/cli/webRuntimeCommands.ts (browserCliError), not introduced here

Compatibility, safety, and release

Breaking changes or migration steps: none; enforced limit unchanged
Real Hopper/Ghidra, browser, or OS coverage: none; not needed for a schema advertisement
Package or release metadata impact: none known
Security, privacy, process, or containment review: none; no behavior change

Author readiness

Human owner: @hmm-1947

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6303 **Author:** [@hmm-1947](https://github.com/hmm-1947) **Created:** 10/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/observe-web-execution-duration-maximum` --- ### 📝 Commits (2) - [`23bd557`](https://github.com/morluto/rea/commit/23bd55747366f96f06336cf948c114679a24d4f4) fix(cli): advertise the observe-web-execution duration maximum - [`da839bb`](https://github.com/morluto/rea/commit/da839bb000d65719808b33618833455bf13cb870) test(cli): verify observe-web-execution --schema advertises the enforced maximum ### 📊 Changes **5 files changed** (+108 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cli/webRuntimeCommands.ts` (+6 -1) ➕ `src/cliObservationOptions.test.ts` (+58 -0) 📝 `src/cliObservationOptions.ts` (+8 -5) 📝 `src/domain/webExecution.ts` (+7 -1) ➕ `tests/boundary/cli/observeWebExecutionSchema.test.ts` (+29 -0) </details> ### 📄 Description ## Summary Fixes #6290. `observe-web-execution --schema` advertised `observationMs.maximum: 9007199254740991`, but the shared input schema rejects values above 2147483647 with `invalid_request`. The command now advertises the limit it enforces. ## Problem and expected behavior A caller following input discovery could choose a value the command then refuses (for example 2147483648). Expected: the advertised range matches the enforced range, the boundary 2147483647 is still accepted, and the above-limit `invalid_request` refusal is unchanged. ## Change and scope `observationDuration` takes an optional maximum. `observe-web-execution` passes `MAX_WEB_EXECUTION_OBSERVATION_MS`, now exported from `src/domain/webExecution.ts` and used by `observeWebExecutionInputSchema`, so the CLI and domain limits share one constant. Other `observationDuration` callers are unchanged. No handler or provider behavior changes. Contribution scope: ordinary fix within existing boundaries; not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: CLI option registration (`src/cli/webRuntimeCommands.ts`), advertised schema only - Contribution scope fit and linked maintainer decision: not applicable - CLI and MCP/tool-catalog contract: `observe-web-execution --schema` now reports `observationMs.maximum` 2147483647; MCP unchanged - Provider, bridge, target-format, or platform compatibility: none - Evidence, artifact, provenance, or reconstruction contract: none - Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable - Generated metadata, package, or installation impact: unknown; no generated catalog edits made Expected effects: - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage Source-derived and executed locally. - Tests added or updated: `tests/boundary/cli/observeWebExecutionSchema.test.ts` (runs `observe-web-execution --schema --json` through the CLI and asserts `observationMs.maximum` is 2147483647), `src/cliObservationOptions.test.ts` (helper) - Base reproduction or other evidence: with the third argument removed from the command registration, the new CLI test fails with `expected 9007199254740991 to be 2147483647` - User-visible CLI/MCP output (if applicable): `observationMs` schema `maximum` changes from 9007199254740991 to 2147483647 - Remaining proof gaps: the issue's end-to-end loopback boundary commands were not re-run; full `npm run check` not run ## Validation performed - `npx vitest run tests/boundary/cli/observeWebExecutionSchema.test.ts src/cliObservationOptions.test.ts tests/boundary/cli/cliInputSchemaRequired.test.ts` — 3 files, 13 tests passed - `npx tsc --noEmit -p tsconfig.json` — no errors - `npx oxlint` on changed files — 0 errors; 1 existing unused-import warning in `src/cli/webRuntimeCommands.ts` (`browserCliError`), not introduced here ## Compatibility, safety, and release - Breaking changes or migration steps: none; enforced limit unchanged - Real Hopper/Ghidra, browser, or OS coverage: none; not needed for a schema advertisement - Package or release metadata impact: none known - Security, privacy, process, or containment review: none; no behavior change ## Author readiness Human owner: @hmm-1947 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:37 +00:00