mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4580] [CLOSED] fix(uninstall): preserve the configuration as it was before uninstall edits it #6320
Closed
opened 2026-10-31 01:13:32 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6320
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4580
Author: @Adolanium
Created: 10/16/2026
Status: ❌ Closed
Base:
main← Head:fix/uninstall-current-config-backup📝 Commits (2)
2dfc2d0fix(uninstall): preserve the configuration as it was before uninstall edits it70bff72test(uninstall): cover backups that fail verification after copying📊 Changes
11 files changed (+384 additions, -82 deletions)
View changed files
📝
docs/installation.md(+6 -4)📝
docs/user-visible-errors.csv(+2 -2)📝
src/application/Setup.configuration.test.ts(+20 -1)📝
src/application/SetupClientConfiguration.ts(+14 -22)📝
src/application/SetupClients.ts(+20 -15)📝
src/application/SetupRecoveryBackup.ts(+62 -11)📝
src/application/SetupTypes.ts(+7 -6)📝
src/application/Uninstall.ts(+52 -14)📝
tests/boundary/filesystem/clientConfigurationTransactions.test.ts(+161 -2)📝
tests/boundary/filesystem/clientLifecycle.test.ts(+10 -5)📝
tests/boundary/filesystem/setupClientConfigCleanupOwnership.test.ts(+30 -0)📄 Description
Summary
Fixes #4581.
rea uninstalldid not preserve a client configuration as it was just before uninstall edited it. After an earlier setup,.rea.backupholds the bytes from before setup, and uninstall's failure messages told the user to restore that file, which drops every edit made since setup. Uninstall now preserves the current bytes through the same recovery-backup owner setup uses, and both failure messages name the backup that was actually used. Setup's readback-failure message had the same hardcoded.rea.backupwording and is fixed here too.Problem and expected behavior
docs/installation.mdsays setup and uninstall keep the first.rea.backup, and that setup preserves a verified.rea.backup.<sha256>.recoverycopy when that snapshot differs from the current configuration.removeClientinsrc/application/Uninstall.tscopied the configuration to${configPath}.rea.backupwithCOPYFILE_EXCLand treatedEEXISTas success. After setup, that file already exists with the pre-setup bytes, so uninstall made no copy of the bytes it was about to edit. If the update failed and the restore also failed, the message saidRestore its .rea.backup manually. Following it loses the REA registration and any user edits made after setup.failedConfigurationMessageinsrc/application/SetupClients.tsreturnedRepair the configuration file or restore its .rea.backupfor everyreadbackfailure. When setup had used a recovery copy, that also named the older snapshot. The samereadbackreason is also returned before any write, where no backup was made.Change and scope
src/application/SetupRecoveryBackup.ts:preserveRecoveryBackupis replaced bypreserveCurrentRecoveryBackup. It runs the select, exclusive copy, and verify steps thatpersistClientConfigurationused to run inline, and returns the verified backup path or a typed failure (unreadable,occupied,copy,unverified). Its options take the copy function, so uninstall keeps its injectableUninstallFileSystem.copy, and an optional resource scope.selectCurrentRecoveryBackuptakes the same optional scope for its backup reads.src/application/SetupClientConfiguration.ts:persistClientConfigurationcalls the new function.rollbackOrReadbackFailurenow carriesbackupPathon areadbackresult.src/application/Uninstall.ts: a newbackupClientConfigurationcallspreserveCurrentRecoveryBackupwith theoriginaltext uninstall already read. The update and restore failure messages name the returned path. An occupied recovery path blocks the edit and names that path. The backup reads use uninstall'sArtifactResourceScope, the same owner its configuration reads use. If a backup file handle fails to close, the scope keeps it forclose(), and that client fails with the backup message instead of the error escapingrunUninstall.docs/user-visible-errors.csv: the setupreadbackand uninstall restore rows now show the new messages.src/application/SetupTypes.ts,src/application/SetupClients.ts:readbackgets its own result member with an optionalbackupPath. With a path, the message names it. Without one, it no longer mentions a backup or claims a write happened.Uninstall still has no preview step, so the recovery path is not shown before approval as it is in setup. Uninstall's preflight
inspectClientdoes not check the recovery path; an occupied path is reported when that client is reached.Contribution scope: not applicable. This is a fix within the existing setup and uninstall boundary.
Contract and boundary impact
SetupRecoveryBackup.tsowns backup selection and preservation for both setup and uninstall; the change is at the backup step before uninstall edits a client configuration.detailtext and setupremediationtext change.ClientConfigurationResultwithreason: "readback"may now carrybackupPath.<config>.rea.backup.<sha256>.recoverynext to a client configuration, the same file setup already creates. It never replaces an existing file there.docs/public/product-catalog.json), package, or installation impact:docs/installation.mdnow says uninstall also preserves the recovery copy, and that when an edit made a backup, uninstall update and restore failures and setup readback and rollback failures name the backup holding the bytes from just before the edit.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
tests/boundary/filesystem/clientConfigurationTransactions.test.ts: a newuninstall backups after edits made since setupblock. Each case runs real setup, edits the configured file, then uninstalls. It checks that a successful uninstall leaves the edited bytes in the recovery path and the pre-setup bytes in.rea.backup; that an update failure and an update-plus-restore failure name the recovery path in the message, and that path holds the edited bytes; and that an occupied recovery path blocks the edit and is named.tests/boundary/filesystem/setupClientConfigCleanupOwnership.test.ts: a new case holds the.rea.backupread handle open during uninstall. It checks that the client fails with the backup message, the configuration is unchanged, and the host'sclose()releases the same handle.tests/boundary/filesystem/clientLifecycle.test.ts: the existing update and restore message cases now expect the.rea.backuppath for a first uninstall.src/application/Setup.configuration.test.ts: thereadbackmessage without a backup, and a new case where areadbackresult carries a recovery path.src/from upstream/main (8ab502439), all four new uninstall cases, the two updated uninstall message cases, the backup-handle cleanup case, and both setupreadbackcases failed. With the fix they pass.Configuration could not be updated or restored. Restore the backup at <config>.rea.backup.<sha256>.recovery manually, then rerun uninstall.clientLifecycle.test.tsfail on this machine both before and after the change, so the symlinked-configuration path was not exercised here. No end-to-endrea uninstallCLI run was made; the tests callsystemUninstallHost(...).removeClient.For evidence-bearing changes:
Validation performed
npm run test:focused -- tests/boundary/filesystem/clientConfigurationTransactions.test.ts tests/boundary/filesystem/clientLifecycle.test.ts src/application/Setup.configuration.test.ts— exited 1 before running tests because the Windows native artifacts (native/windows/build/manifest.json) are missing in this checkout.npx vitest run tests/boundary/filesystem/clientConfigurationTransactions.test.ts tests/boundary/filesystem/clientLifecycle.test.ts src/application/Setup.configuration.test.ts src/application/Setup.recovery.test.ts tests/boundary/filesystem/clientConfigurationBom.test.ts tests/boundary/filesystem/setupClientConfigCleanupOwnership.test.ts tests/boundary/filesystem/setupSkillCleanupOwnership.test.ts— 129 passed, 3 skipped, 2 failed. The 2 failures are the symlink tests named above, which also fail on upstream/main on this machine.npx vitest run tests/boundary/filesystem/clientConfigurationTransactions.test.ts tests/boundary/filesystem/clientLifecycle.test.ts tests/boundary/filesystem/setupClientConfigCleanupOwnership.test.ts src/application/Setup.configuration.test.tswith the new tests on upstream/main source (8ab502439) — 11 failed: the 9 regression cases above and the 2 symlink tests.npx vitest runon the other 14 client configuration boundary files plussrc/cliLogging.test.tsandsrc/setupEnvironment.test.ts— 300 passed, 1 skipped, 42 failed, both with the fix and on8ab502439. The failures are Windows path-separator and stdio connection failures that this change does not touch.npx tsc --noEmit --pretty false— no errors.70bff7240:npx vitest run tests/boundary/filesystem/clientConfigurationTransactions.test.ts— 18 passed, 2 skipped; with the verify step removed frompreserveCurrentRecoveryBackup, the two new cases fail.npm run check:fast— passed.npm run docs:check— did not run because the Windows native artifacts are missing.f26973a52(conflicts with the newtarget_unavailableresult inSetupClientConfiguration.tsandSetupClients.ts, resolved by keeping that check and adding its message case to theswitch):npx tsc --noEmit— no errors;npm run check:fast— passed;npx vitest runonclientConfigurationTransactions,clientLifecycle,setupClientConfigCleanupOwnershipandSetup.configuration— 97 passed, 3 skipped, 2 failed (the same two symlink tests, which also fail on unmodifiedf26973a52here).npx oxlinton the changed files — 0 errors. Existing size and complexity warnings remain;removeClientcomplexity went from 25 to 22.npx oxfmt --checkon the changed files — passed.Compatibility, safety, and release
reason: "readback"still get it;backupPathis optional.Author readiness
Human owner: @Adolanium
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.