[PR #4582] [CLOSED] fix(firmware): document safe-link normalization of absolute symlinks #6323

New issue

Closed

opened 2026-10-31 01:13:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:13:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4582
Author: @nikhilsaxena04
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: fix/4175-firmware-symlink-provenance

📝 Commits (3)

b48656b fix(firmware): document safe-link normalization of absolute symlinks
2006f8a docs(firmware): remove shared Unblob symlink claim
d680861 fix(firmware): scope symlink provenance to provider evidence

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 docs/firmware-analysis.md (+4 -0)

📄 Description

Summary

Documents provider-neutral firmware symlink provenance: link_target is what the active provider reports and may not preserve original on-disk metadata. Shared limitations and generic gap continuations no longer assert Unblob-specific normalization for other engines.

Conditional Unblob normalized-target Evidence disclosure belongs to #4573; this PR avoids duplicating that capability in shared consumers.

Validation and limits

The final tree passed check:fast and formatting/diff checks. npm run test:focused -- tests/boundary/firmware/firmwareIntegration.test.ts compiled successfully, but all 35 provider-dependent cases were skipped because the local firmware provider was unavailable. This pass therefore establishes static/compile checks, not real firmware extraction behavior. No claim of 35 executed passing cases or complete provider coverage is made.

Author readiness

Human owner: @nikhilsaxena04

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4582 **Author:** [@nikhilsaxena04](https://github.com/nikhilsaxena04) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/4175-firmware-symlink-provenance` --- ### 📝 Commits (3) - [`b48656b`](https://github.com/morluto/rea/commit/b48656bf33bcb512100e62202afb01799d6cfc56) fix(firmware): document safe-link normalization of absolute symlinks - [`2006f8a`](https://github.com/morluto/rea/commit/2006f8a8530083e9541f826d6caab2c8c572e913) docs(firmware): remove shared Unblob symlink claim - [`d680861`](https://github.com/morluto/rea/commit/d680861c0e77b4e0d33a194b088ca4be112380fd) fix(firmware): scope symlink provenance to provider evidence ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/firmware-analysis.md` (+4 -0) </details> ### 📄 Description ## Summary Documents provider-neutral firmware symlink provenance: link_target is what the active provider reports and may not preserve original on-disk metadata. Shared limitations and generic gap continuations no longer assert Unblob-specific normalization for other engines. Conditional Unblob normalized-target Evidence disclosure belongs to #4573; this PR avoids duplicating that capability in shared consumers. ## Validation and limits The final tree passed check:fast and formatting/diff checks. `npm run test:focused -- tests/boundary/firmware/firmwareIntegration.test.ts` compiled successfully, but all 35 provider-dependent cases were skipped because the local firmware provider was unavailable. This pass therefore establishes static/compile checks, not real firmware extraction behavior. No claim of 35 executed passing cases or complete provider coverage is made. ## Author readiness Human owner: @nikhilsaxena04 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:13:34 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:46:44 +00:00

[PR #6323] [MERGED] docs(testing): note Windows source-checkout suite expectations #7283

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6323

No description provided.

Rows
Columns