[PR #4703] [MERGED] test(kuna): preserve caller and producer graph failure context #6365

New issue

Closed

opened 2026-10-31 01:13:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:13:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4703
Author: @N0zoM1z0
Created: 10/17/2026
Status: ✅ Merged
Merged: 10/17/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/kuna-call-graph-test-attribution-20261017

📝 Commits (1)

9eb671f test(kuna): preserve caller and producer graph failure context

📊 Changes

1 file changed (+12 additions, -3 deletions)

View changed files

📝 tests/boundary/providers/kuna/kunaReferences.test.ts (+12 -3)

📄 Description

Summary

Fixes #4701. Three malformed-call-graph retry tests still expect the internal parser operation after main began attributing failures to their logical caller. Assert procedure_callees using the caller's selected operation, and additionally verify the original kuna:call-graph operation remains in diagnostics and the cause.

One test file only. All three malformed shapes, corrected-response retry, two-command cache check and client cleanup remain active. The lower-level parser golden continues asserting its own producer operation. No production, schema, authority, cache lifetime or provider capability change; additional maintainer scope approval is not applicable.

Validation performed

Clean main 988494abdbb27fb91ca6bd80362c9f1a332f86c3: npm run test:focused -- tests/boundary/providers/kuna/kunaReferences.test.ts reproduces 3 failed / 14 passed. The failure is the operation assertion, not a Kuna lookup change.
npm run test:focused -- tests/boundary/providers/kuna/*.test.ts: 26 files / 266 tests passed, including malformed input, retry, cache/target identity, cancellation, deadlines, capacity and cleanup ownership.
Complete npm run check:ci: passed, including typecheck/lint, Knip, module boundaries and architecture guards. git diff --check: passed.

These tests use the existing owned subprocess fixtures; actual Kuna runtime behavior is unverified by this test-only repair. Heavy tasks ran serially on two CPU cores with a 3 GiB Node heap: full Kuna selection 75.23 s wall / 124.30 s reaped CPU / 1.88 GiB sampled family RSS; static gate 44.00 s / 76.94 s / 4.80 GiB. No OOM/guard stop. RSS sampling is 200 ms and excludes assistant/shared services; cache/host conditions are uncontrolled. Before/after selections differ, so no speedup is claimed; agent/model tokens and controlled cold/warm costs are unmeasured.

Final verification: complete exact-head CI passed, including all five built-dependent shards, Source/static checks and required gates, on 9eb671f267181236cf926141d118e29156e8221d. Greptile reviewed that head at 5/5 with no actionable issue or open thread. Codex explicitly reported repository code-review usage limits; a fresh Codex review is unavailable.

Author readiness

Human owner: @N0zoM1z0

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Human owner explicitly reviewed the diff/evidence, accepted owner responsibility and dictated initial readiness in the live conversation (2026-10-17).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4703 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/17/2026 **Status:** ✅ Merged **Merged:** 10/17/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/kuna-call-graph-test-attribution-20261017` --- ### 📝 Commits (1) - [`9eb671f`](https://github.com/morluto/rea/commit/9eb671f267181236cf926141d118e29156e8221d) test(kuna): preserve caller and producer graph failure context ### 📊 Changes **1 file changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/providers/kuna/kunaReferences.test.ts` (+12 -3) </details> ### 📄 Description ## Summary Fixes #4701. Three malformed-call-graph retry tests still expect the internal parser operation after main began attributing failures to their logical caller. Assert `procedure_callees` using the caller's selected operation, and additionally verify the original `kuna:call-graph` operation remains in diagnostics and the cause. One test file only. All three malformed shapes, corrected-response retry, two-command cache check and client cleanup remain active. The lower-level parser golden continues asserting its own producer operation. No production, schema, authority, cache lifetime or provider capability change; additional maintainer scope approval is not applicable. ## Validation performed - Clean main `988494abdbb27fb91ca6bd80362c9f1a332f86c3`: `npm run test:focused -- tests/boundary/providers/kuna/kunaReferences.test.ts` reproduces **3 failed / 14 passed**. The failure is the operation assertion, not a Kuna lookup change. - `npm run test:focused -- tests/boundary/providers/kuna/*.test.ts`: **26 files / 266 tests passed**, including malformed input, retry, cache/target identity, cancellation, deadlines, capacity and cleanup ownership. - Complete `npm run check:ci`: **passed**, including typecheck/lint, Knip, module boundaries and architecture guards. `git diff --check`: passed. These tests use the existing owned subprocess fixtures; actual Kuna runtime behavior is unverified by this test-only repair. Heavy tasks ran serially on two CPU cores with a 3 GiB Node heap: full Kuna selection 75.23 s wall / 124.30 s reaped CPU / 1.88 GiB sampled family RSS; static gate 44.00 s / 76.94 s / 4.80 GiB. No OOM/guard stop. RSS sampling is 200 ms and excludes assistant/shared services; cache/host conditions are uncontrolled. Before/after selections differ, so no speedup is claimed; agent/model tokens and controlled cold/warm costs are unmeasured. Final verification: [complete exact-head CI passed](https://github.com/morluto/rea/actions/runs/39010297775), including all five built-dependent shards, Source/static checks and required gates, on `9eb671f267181236cf926141d118e29156e8221d`. Greptile reviewed that head at 5/5 with no actionable issue or open thread. Codex explicitly reported repository code-review usage limits; a fresh Codex review is unavailable. ## Author readiness Human owner: @N0zoM1z0 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. Human owner explicitly reviewed the diff/evidence, accepted owner responsibility and dictated initial readiness in the live conversation (2026-10-17). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:13:53 +00:00