morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #6365] [MERGED] test(javascript): cover Request endpoint identity and provenance #7312

New issue

Closed

opened 2026-11-01 21:46:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6365
Author: @AyoubElleuch
Created: 10/22/2026
Status: ✅ Merged
Merged: 11/4/2026
Merged by: @morluto

Base: main ← Head: fix/fetch-request-literal

📝 Commits (3)

d50fd3d fix(javascript): resolve inline Request URLs in fetch calls
6b92529 test(javascript): reconcile Request endpoint coverage with main
9276957 chore: merge upstream fixes into Request regression coverage

📊 Changes

2 files changed (+79 additions, -1 deletions)

View changed files

📝 src/domain/javascript/javascriptStaticAnalysis.partialEndpoints.test.ts (+62 -0)
📝 tests/boundary/filesystem/javascript-applications/javascriptArtifactGraphEndpoints.test.ts (+17 -1)

📄 Description

Summary

Follow-up coverage for #6359 and the merged fix in #6364.

This PR now adds regression coverage for built-in Request constructor identity and exact endpoint Evidence through artifact graph projection. Upstream's Request implementation is preserved unchanged. The merge conflict came from both PRs editing the same endpoint scanner; the resolution uses upstream's shared isFetchCall / requestConstructorUrl helpers and removes the superseded inline implementation.

Change and scope

Cover window.Request, globalThis.Request, self.Request, global-object fetch calls, and optional fetch calls.
Keep lexical shadowing, replaced constructors, dynamic URL arguments, and spread arguments partial.
Verify /api/chat reaches the artifact graph as exact, observed AST Evidence.
Remove cases already covered by upstream's inline constructor, function-parameter shadowing, and non-fetch API tests.

The final diff against upstream is limited to two test files. Production code, schemas, providers, authority, and installation behavior are unchanged. A maintainer scope decision is not applicable.

Validation

Windows x64, repository-pinned Node.js 24.22.1 and npm 11.16.0; merged upstream snapshot fc2dddc1d.

npm run test:local -- src/domain/javascript/javascriptStaticAnalysis.partialEndpoints.test.ts src/domain/javascript/javascriptSemanticAmbientWrites.test.ts src/domain/javascript/javascriptStaticAnalysisCalleeBoundary.test.ts — 108 passed.
npm run test:focused -- tests/boundary/filesystem/javascript-applications/javascriptArtifactGraphEndpoints.test.ts — 4 passed.
npm run check and git diff --check — passed.
An earlier combined run against merged 3d4f55652 also selected javascriptStaticAnalysis.mapEndpoints.test.ts: 191 passed and 5 failed. The same five Map cases failed on exact, unmodified upstream baselines 3d4f55652 and fc2dddc1d (83 passed, 5 failed in that file). These failures remain unresolved and are outside the Request coverage change.

No real-provider or separate CLI/MCP transport run; the full suite was not run locally. The filesystem boundary test exercises production static analysis and graph projection.

Author readiness

Human owner: @AyoubElleuch

AI assistance: GPT-6.1 Sol.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6365 **Author:** [@AyoubElleuch](https://github.com/AyoubElleuch) **Created:** 10/22/2026 **Status:** ✅ Merged **Merged:** 11/4/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/fetch-request-literal` --- ### 📝 Commits (3) - [`d50fd3d`](https://github.com/morluto/rea/commit/d50fd3d85d7c63bf27845271e0c7b48aa36b4c26) fix(javascript): resolve inline Request URLs in fetch calls - [`6b92529`](https://github.com/morluto/rea/commit/6b9252965cbe18b615774474a45662ee306be374) test(javascript): reconcile Request endpoint coverage with main - [`9276957`](https://github.com/morluto/rea/commit/92769571c10c3c76a87f4975499032b70c3725fd) chore: merge upstream fixes into Request regression coverage ### 📊 Changes **2 files changed** (+79 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptStaticAnalysis.partialEndpoints.test.ts` (+62 -0) 📝 `tests/boundary/filesystem/javascript-applications/javascriptArtifactGraphEndpoints.test.ts` (+17 -1) </details> ### 📄 Description ## Summary Follow-up coverage for #6359 and the merged fix in #6364. This PR now adds regression coverage for built-in Request constructor identity and exact endpoint Evidence through artifact graph projection. Upstream's Request implementation is preserved unchanged. The merge conflict came from both PRs editing the same endpoint scanner; the resolution uses upstream's shared `isFetchCall` / `requestConstructorUrl` helpers and removes the superseded inline implementation. ## Change and scope - Cover `window.Request`, `globalThis.Request`, `self.Request`, global-object fetch calls, and optional fetch calls. - Keep lexical shadowing, replaced constructors, dynamic URL arguments, and spread arguments partial. - Verify `/api/chat` reaches the artifact graph as exact, observed AST Evidence. - Remove cases already covered by upstream's inline constructor, function-parameter shadowing, and non-fetch API tests. The final diff against upstream is limited to two test files. Production code, schemas, providers, authority, and installation behavior are unchanged. A maintainer scope decision is not applicable. ## Validation Windows x64, repository-pinned Node.js 24.22.1 and npm 11.16.0; merged upstream snapshot `fc2dddc1d`. - `npm run test:local -- src/domain/javascript/javascriptStaticAnalysis.partialEndpoints.test.ts src/domain/javascript/javascriptSemanticAmbientWrites.test.ts src/domain/javascript/javascriptStaticAnalysisCalleeBoundary.test.ts` — 108 passed. - `npm run test:focused -- tests/boundary/filesystem/javascript-applications/javascriptArtifactGraphEndpoints.test.ts` — 4 passed. - `npm run check` and `git diff --check` — passed. - An earlier combined run against merged `3d4f55652` also selected `javascriptStaticAnalysis.mapEndpoints.test.ts`: 191 passed and 5 failed. The same five Map cases failed on exact, unmodified upstream baselines `3d4f55652` and `fc2dddc1d` (83 passed, 5 failed in that file). These failures remain unresolved and are outside the Request coverage change. No real-provider or separate CLI/MCP transport run; the full suite was not run locally. The filesystem boundary test exercises production static analysis and graph projection. ## Author readiness Human owner: @AyoubElleuch AI assistance: GPT-6.1 Sol. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-11-01 21:46:57 +00:00

bsakaguchi referenced this issue

2026-11-03 00:29:32 +00:00

[GH-ISSUE #5653] [Tracker] New issue intake by area (October 2026) #3423

bsakaguchi changed title from ~~[PR #6365] test(javascript): cover Request endpoint identity and provenance~~ to [PR #6365] [MERGED] test(javascript): cover Request endpoint identity and provenance

2026-11-04 12:19:37 +00:00

bsakaguchi closed this issue

2026-11-04 12:19:37 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7312

No description provided.

Rows
Columns